New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 647344 link

Starred by 2 users

Issue metadata

Status: Started
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 2
Type: Bug-Regression

Blocking:
issue 624697



Sign in to add a comment

test failure for PluginsTest.Plugins on Win 10 Fast Ring, revision e7ac1bbe93e087b173d503ca13b1e3b6f703b785

Project Member Reported by wfh@chromium.org, Sep 15 2016

Issue description

Version: e7ac1bbe93e087b173d503ca13b1e3b6f703b785
OS: Windows 10

What steps will reproduce the problem?
(1) browser_tests --gtest_filter=PluginsTest.Plugins
(2)
(3)


Please use labels and text to provide additional information.

 

Comment 1 by wfh@chromium.org, Sep 15 2016

Owner: tasak@chromium.org
Status: Assigned (was: Untriaged)
https://build.chromium.org/p/chromium.fyi/builders/Win%2010%20Fast%20Ring/builds/2635

possibly e7ac1bbe93e087b173d503ca13b1e3b6f703b785

tasak can you take a look at this? Something has turned the win10 FYI bot red.

Comment 2 by wfh@chromium.org, Sep 15 2016

Cc: dominickn@chromium.org robho...@gmail.com hirosh...@chromium.org noyau@chromium.org r...@igalia.com satay...@samsung.com yutak@chromium.org msten...@opera.com ricea@chromium.org

Comment 3 by wfh@chromium.org, Sep 15 2016

[ RUN      ] PluginsTest.Plugins
[7188:14640:0915/062348:ERROR:dxva_video_decode_accelerator_win.cc(297)] EGL_EXT_device_query missing
[7188:14640:0915/062348:ERROR:mf_helpers.cc(12)] Error in dxva_video_decode_accelerator_win.cc on line 297
[12948:6812:0915/062349:INFO:CONSOLE(1206)] "Running TestCase PluginsTest.Plugins", source: test_api.js (1206)
[12948:6812:0915/062349:ERROR:CONSOLE(48)] "Mocha test failed: PluginTest PluginsUpdated
AssertionError: expected 1 to equal 2
    at Function.assert.strictEqual (chai.js:2277:32)
    at assertEquals (test_api.js:890:17)
    at Context.<anonymous> (plugins_browsertest.js:166:7)
", source: mocha_adapter.js (48)
[12948:6812:0915/062349:ERROR:web_ui_test_handler.cc(76)] Test Errors: 1/2 tests had failed assertions.
[12948:6812:0915/062349:ERROR:web_ui_browser_test.cc(473)] CONDITION FAILURE: encountered javascript console error(s):
[12948:6812:0915/062349:ERROR:web_ui_browser_test.cc(475)] JS ERROR: '[12948:6812:0915/062349:ERROR:CONSOLE(48)] "Mocha test failed: PluginTest PluginsUpdated
AssertionError: expected 1 to equal 2
    at Function.assert.strictEqual (chai.js:2277:32)
    at assertEquals (test_api.js:890:17)
    at Context.<anonymous> (plugins_browsertest.js:166:7)
", source: mocha_adapter.js (48)
'
[12948:6812:0915/062349:ERROR:web_ui_browser_test.cc(477)] JS call assumed failed, because JS console error(s) found.
e:\b\c\b\win_10_fast_ring\src\out\release_x64\gen\chrome\test\data\webui\plugins_browsertest-gen.cc(31): error: Value of: RunJavascriptTestF( true, "PluginsTest", "Plugins")
  Actual: false
Expected: true
[12948:6812:0915/062349:WARNING:url_request_context_getter.cc(43)] URLRequestContextGetter leaking due to no owning thread.
[  FAILED  ] PluginsTest.Plugins, where TypeParam =  and GetParam() =  (950 ms)

Comment 4 by wfh@chromium.org, Sep 15 2016

Cc: tasak@chromium.org
Owner: wfh@chromium.org
Status: Started (was: Assigned)
Summary: test failure for PluginsTest.Plugins on Win 10 Fast Ring, revision e7ac1bbe93e087b173d503ca13b1e3b6f703b785 (was: buildbot warning in Chromium FYI on Win 10 Fast Ring, revision e7ac1bbe93e087b173d503ca13b1e3b6f703b785)
got one good build after the failure:

https://build.chromium.org/p/chromium.fyi/builders/Win%2010%20Fast%20Ring/builds/2639

so this looks like a flake, or the code was already reverted. Either way I'm rebooting and clobbering the bot to see if I can get it green again.

I'll close this when I see no more failures for this test.

Comment 5 by tasak@google.com, Sep 16 2016

Looking...

I think, my patch is innocent.
I added some code, but currently the code is hidden behind a flag and it is not possible to invoke the code from PluginsTest.

Comment 6 by tasak@google.com, Sep 16 2016

Cc: -hirosh...@chromium.org wfh@chromium.org
Owner: hirosh...@chromium.org
Status: Assigned (was: Started)
I finished manual bisect.

I suspect: aaf5ece46ff3b24c2f5ff0054600900f60c70ce4
https://chromium.googlesource.com/chromium/src/+/aaf5ece46ff3b24c2f5ff0054600900f60c70ce4

When I reverted aaf5ece46ff3b24c2f5ff0054600900f60c70ce4, the test passed.

I added console.log(document.body.innerHTML) to the test and found that no plugin data was added. I guess, setUp has not been finished yet when running PluginTest.

The patch said, removing <link>'s EventSender. I guess, if the test depends on <link> and EventSender, .... the test will fail... I think, we need to update the test.

Status: Started (was: Assigned)
There has been a race between plugin intialization and document.onload, and and my CL changed the timing of document.onload.
Perhaps the test depends on specific timing of those events.
Blocking: 624697

Comment 9 by msten...@opera.com, Nov 17 2016

Cc: -msten...@opera.com

Comment 10 by r...@igalia.com, Nov 17 2016

Cc: -r...@igalia.com
You started fixing this bug over two years ago. Are you still working on it? You can update the status to "archived", "wontfix", or "closed". You can remove yourself as owner and change status to "untriaged", but if this is still a real bug, please do not sit on it.

Sign in to add a comment