telemetry_UnitTests failures on x86-generic-telemetry and amd64-generic-telemetry |
|||||||
Issue description
We have the following three failures:
(1) telemetry.internal.backends.chrome.cros_unittest.CrOSCryptohomeTest.testCryptohome failed unexpectedly
(2) telemetry.internal.backends.chrome.cros_unittest.CrOSLoginTest.testLoginStatus
(3) telemetry.internal.backends.chrome.cros_unittest.CrOSLoginTest.testLogout
They all fail with `AttributeError: 'NoneType' object has no attribute 'port_pair'`:
09/15 10:12:23.527 INFO |run_chromeos_tests:0052| Failure while starting browser backend.
09/15 10:12:23.527 INFO |run_chromeos_tests:0052| Traceback (most recent call last):
09/15 10:12:23.527 INFO |run_chromeos_tests:0052| File "/usr/local/telemetry/src/third_party/catapult/telemetry/telemetry/internal/browser/browser.py", line 55, in __init__
09/15 10:12:23.527 INFO |run_chromeos_tests:0052| self._browser_backend.Start()
09/15 10:12:23.528 INFO |run_chromeos_tests:0052| File "/usr/local/telemetry/src/third_party/catapult/common/py_trace_event/py_trace_event/trace_event_impl/decorators.py", line 52, in traced_function
09/15 10:12:23.528 INFO |run_chromeos_tests:0052| return func(*args, **kwargs)
09/15 10:12:23.528 INFO |run_chromeos_tests:0052| File "/usr/local/telemetry/src/third_party/catapult/telemetry/telemetry/internal/backends/chrome/cros_browser_backend.py", line 117, in Start
09/15 10:12:23.528 INFO |run_chromeos_tests:0052| startup_args = [a.replace(',', '\\,') for a in self.GetBrowserStartupArgs()]
09/15 10:12:23.529 INFO |run_chromeos_tests:0052| File "/usr/local/telemetry/src/third_party/catapult/common/py_trace_event/py_trace_event/trace_event_impl/decorators.py", line 52, in traced_function
09/15 10:12:23.529 INFO |run_chromeos_tests:0052| return func(*args, **kwargs)
09/15 10:12:23.529 INFO |run_chromeos_tests:0052| File "/usr/local/telemetry/src/third_party/catapult/telemetry/telemetry/internal/backends/chrome/cros_browser_backend.py", line 55, in GetBrowserStartupArgs
09/15 10:12:23.530 INFO |run_chromeos_tests:0052| args = super(CrOSBrowserBackend, self).GetBrowserStartupArgs()
09/15 10:12:23.530 INFO |run_chromeos_tests:0052| File "/usr/local/telemetry/src/third_party/catapult/common/py_trace_event/py_trace_event/trace_event_impl/decorators.py", line 52, in traced_function
09/15 10:12:23.530 INFO |run_chromeos_tests:0052| return func(*args, **kwargs)
09/15 10:12:23.530 INFO |run_chromeos_tests:0052| File "/usr/local/telemetry/src/third_party/catapult/telemetry/telemetry/internal/backends/chrome/chrome_browser_backend.py", line 88, in GetBrowserStartupArgs
09/15 10:12:23.531 INFO |run_chromeos_tests:0052| args.extend(self.GetReplayBrowserStartupArgs())
09/15 10:12:23.531 INFO |run_chromeos_tests:0052| File "/usr/local/telemetry/src/third_party/catapult/common/py_trace_event/py_trace_event/trace_event_impl/decorators.py", line 52, in traced_function
09/15 10:12:23.531 INFO |run_chromeos_tests:0052| return func(*args, **kwargs)
09/15 10:12:23.532 INFO |run_chromeos_tests:0052| File "/usr/local/telemetry/src/third_party/catapult/telemetry/telemetry/internal/backends/chrome/chrome_browser_backend.py", line 126, in GetReplayBrowserStartupArgs
09/15 10:12:23.532 INFO |run_chromeos_tests:0052| proxy_port = network_backend.forwarder.port_pair.remote_port
09/15 10:12:23.532 INFO |run_chromeos_tests:0052| AttributeError: 'NoneType' object has no attribute 'port_pair'
,
Sep 15 2016
The only CL that was rolled that seems related is https://codereview.chromium.org/2335403003/
,
Sep 15 2016
I believe that is the culprit. But please don't revert that CL since it will affect many performance suite that uses telemetry. Achuith: can you take a look at fixing?
,
Sep 15 2016
I think the fix is in https://chromium-review.googlesource.com/#/c/374542/
,
Sep 15 2016
Ned, that code (chrome.py) doesn't run here - the failures are in telemetry unit tests that are running on chromeos without this wrapper. I'm on vacation until 9/28, so maybe Ben or Ahmed can take a look. It shouldn't be very hard to resolve.
,
Sep 15 2016
Ahmed, to run this test on your DUT, I think you do something like: python /usr/local/telemetry/src/third_party/catapult/telemetry/bin/run_tests testCryptohome
,
Sep 20 2016
Any progress on this? The tests are still faling: https://build.chromium.org/p/chromiumos.chromium/builders/x86-generic-telemetry/builds/10518 Results: https://pantheon.corp.google.com/storage/browser/chromeos-image-archive/x86-generic-telemetry/R55-8820.0.0-b10518/vm_test_results_1/test_harness/all/SimpleTestVerify/1_autotest_tests/results-2-telemetry_UnitTests Error snippet from the client logs matches the initial comment.
,
Sep 21 2016
,
Sep 23 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/883442d271d1257505fb99d0802b5a1a0c201d51 commit 883442d271d1257505fb99d0802b5a1a0c201d51 Author: catapult-deps-roller <catapult-deps-roller@chromium.org> Date: Fri Sep 23 01:28:56 2016 Roll src/third_party/catapult/ b803018ac..7bd10eda4 (9 commits). https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/b803018ac776..7bd10eda47f1 $ git log b803018ac..7bd10eda4 --date=short --no-merges --format='%ad %ae %s' 2016-09-22 nednguyen Make use_live_traffic in FakeNetworkController default to False 2016-09-22 jbudorick [Android] Attempt to grab the forwarder daemon logs on map failure. 2016-09-22 aiolos Remove warning when a ref build is set as monitored. 2016-09-22 charliea [trace model] Add .range accessor for Event 2016-09-22 nednguyen [Telemetry] Enable typ's discovery flags for telemetry's unittest_runner framework 2016-09-22 sullivan Add ability to query for test patterns of length 8. 2016-09-22 bccheng Explicitly initialize the network controller 2016-09-22 nednguyen Add logging to _FileLock to debug race condition when multiple processes download a same file 2016-09-22 nednguyen [Telemetry] Start ts_proxy_server with host=None when --use-live-site flag is enabled BUG= 634052 , 643649 ,647340,643320 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=catapult-sheriff@chromium.org Review-Url: https://codereview.chromium.org/2365803002 Cr-Commit-Position: refs/heads/master@{#420534} [modify] https://crrev.com/883442d271d1257505fb99d0802b5a1a0c201d51/DEPS
,
Apr 25 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9649adfea00cc80e604b54c94492d9833d8f13ea commit 9649adfea00cc80e604b54c94492d9833d8f13ea Author: catapult-deps-roller@chromium.org <catapult-deps-roller@chromium.org> Date: Tue Apr 25 05:15:19 2017 Roll src/third_party/catapult/ 892a0b6a4..5592ae343 (1 commit) https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/892a0b6a45cc..5592ae343004 $ git log 892a0b6a4..5592ae343 --date=short --no-merges --format='%ad %ae %s' 2017-04-24 achuith Disable testTraceCaptureUponFailure on chromeos. Created with: roll-dep src/third_party/catapult BUG=647340 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: I1b4136ceecbac675b4997f050d54c511c0f086df Reviewed-on: https://chromium-review.googlesource.com/486165 Reviewed-by: <catapult-deps-roller@chromium.org> Commit-Queue: <catapult-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#466876} [modify] https://crrev.com/9649adfea00cc80e604b54c94492d9833d8f13ea/DEPS
,
Jan 16
,
Jan 16
|
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by afakhry@chromium.org
, Sep 15 2016