PluginsTest.Plugins fails often on linux_chromium_rel_ng |
||||||
Issue descriptionbrowser_tests:PluginsTest.Plugins is extremely flaky, especially on linux_chromium_rel_ng (where it forces many runs to build without the patch) http://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=browser_tests%20(with%20patch)&tests=PluginsTest.Plugins e.g. https://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/298303 [29626:29626:0915/054705:INFO:CONSOLE(1206)] "Running TestCase PluginsTest.Plugins", source: test_api.js (1206) [29626:29626:0915/054705:ERROR:CONSOLE(48)] "Mocha test failed: PluginTest PluginsUpdated AssertionError: expected 1 to equal 2 at Function.assert.strictEqual (chai.js:2277:32) at assertEquals (test_api.js:890:17) at Context.<anonymous> (plugins_browsertest.js:166:7) ", source: mocha_adapter.js (48) [29626:29626:0915/054705:ERROR:web_ui_test_handler.cc(76)] Test Errors: 1/2 tests had failed assertions. [29626:29626:0915/054705:ERROR:web_ui_browser_test.cc(473)] CONDITION FAILURE: encountered javascript console error(s): [29626:29626:0915/054705:ERROR:web_ui_browser_test.cc(475)] JS ERROR: '[29626:29626:0915/054705:ERROR:CONSOLE(48)] "Mocha test failed: PluginTest PluginsUpdated AssertionError: expected 1 to equal 2 at Function.assert.strictEqual (chai.js:2277:32) at assertEquals (test_api.js:890:17) at Context.<anonymous> (plugins_browsertest.js:166:7) ", source: mocha_adapter.js (48) ' [29626:29626:0915/054705:ERROR:web_ui_browser_test.cc(477)] JS call assumed failed, because JS console error(s) found. gen/chrome/test/data/webui/plugins_browsertest-gen.cc:31: Failure Value of: RunJavascriptTestF( true, "PluginsTest", "Plugins") Actual: false Expected: true [29626:29626:0915/054706:WARNING:url_request_context_getter.cc(43)] URLRequestContextGetter leaking due to no owning thread. [ FAILED ] PluginsTest.Plugins, where TypeParam = and GetParam() = (1038 ms) I don't see an obvious culprit, so I'm going to disable the test and assign to an owner of that directory.
,
Sep 15 2016
,
Sep 15 2016
yeah, this is flaking out a ton here: https://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng definitely disable and we'll look into it
,
Sep 15 2016
Did this started being flaky lately? The test was added in Apr 2016. Anyway I'll take a look since I authored this test.
,
Sep 15 2016
dpapad@: yeah, no idea why it blowed up now. it seems like almost 100% failure rate on try bots. weirrrrrd
,
Sep 15 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4400be71e9c873b28217a644e85e6929a11d151e commit 4400be71e9c873b28217a644e85e6929a11d151e Author: jbroman <jbroman@chromium.org> Date: Thu Sep 15 18:33:14 2016 Disable browser_tests:PluginsTest.Plugins due to frequent failures. TBR=dbeam@chromium.org BUG= 647305 NOTRY=true Review-Url: https://codereview.chromium.org/2347553004 Cr-Commit-Position: refs/heads/master@{#418910} [modify] https://crrev.com/4400be71e9c873b28217a644e85e6929a11d151e/chrome/test/data/webui/plugins_browsertest.js
,
Sep 15 2016
Issue 647356 has been merged into this issue.
,
Nov 21 2016
,
Dec 1 2016
I would check for a race condition between the test and the browser site. I would try putting Promise guards around the getPluginsData and getShowDetails return statements that resolve when setPluginsData and setShowDetails is called and after the value is set. This seems to fix timeouts in BluetoothInternalsTest (CL: https://codereview.chromium.org/2532383005/). I've found in my issue that the web page has the opportunity to run before the test has fully initialized the TestBrowserProxy. This gives you null value in your code here (https://cs.chromium.org/chromium/src/chrome/test/data/webui/plugins_browsertest.js?rcl=0&l=69). I've run into a weird bug where calling "return Promise.resolve({someValue: null})" stalls the entire Promise chain. It could be my configuration but I've reproduced the bug with my issue (https://bugs.chromium.org/p/chromium/issues/detail?id=667970) on both Linux and Mac and with your PluginsTest code.
,
Dec 8 2016
Thanks for the info. I am now able to reproduce this flaky failure.
,
Dec 9 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a659660131175f540fc06e3384c7e8eb7cf55ace commit a659660131175f540fc06e3384c7e8eb7cf55ace Author: dpapad <dpapad@chromium.org> Date: Fri Dec 09 18:23:55 2016 Fix PluginsTest.Plugins race condition and re-enable. BUG= 647305 Review-Url: https://codereview.chromium.org/2563743002 Cr-Commit-Position: refs/heads/master@{#437590} [modify] https://crrev.com/a659660131175f540fc06e3384c7e8eb7cf55ace/chrome/test/data/webui/plugins_browsertest.js
,
Mar 23 2017
The chrome://plugins code has been removed at https://codereview.chromium.org/2630443002. |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by jbroman@chromium.org
, Sep 15 2016