New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 647293 link

Starred by 2 users
Status: Fixed
Owner:
█ kapishnikov@chromium.org
Last visit > 30 days ago
Closed: Sep 2016
Cc:
pauljensen@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug



Sign in to add a comment

jar_src should allow the caller to specify an explicit list of java files instead of a whole directory

Project Member Reported by kapishnikov@chromium.org, Sep 15 2016 
Currently a caller of jar_src.py specifies a directory where the ".java" files are located. The script takes all files from that directory. This causes issues if the directory on the on a bot is not clean, e.g. see
https://bugs.chromium.org/p/chromium/issues/detail?id=637887

Another example of the failure:
https://build.chromium.org/p/tryserver.chromium.android/builders/android_cronet/builds/1205
where generate_javadoc.py references classes that were deleted.
Project Member

Comment 1 by bugdroid1@chromium.org, Sep 21 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/624c32473d6d601e104bca2d91d68a0fa0266c0e

commit 624c32473d6d601e104bca2d91d68a0fa0266c0e
Author: kapishnikov <kapishnikov@chromium.org>
Date: Wed Sep 21 19:56:18 2016

Add support for "src_files" and "srcjar_deps" to "src_jar" GN template

Added a mandatory parameter to src_jar gn template that explicitly lists
all files that should be jarred. The script validates that one and only
one file with a given name exists in all search directories.

Added support for optional srcjar_deps attribute that can be used to
list dependencies that generate srcjar files and should be included
in the resulting jar file.

Added optional attribute 'source_deps' that allows packaging sources
of the dependent targets.

BUG= 647293 ,637887

Review-Url: https://codereview.chromium.org/2347233002
Cr-Commit-Position: refs/heads/master@{#420140}

[modify] https://crrev.com/624c32473d6d601e104bca2d91d68a0fa0266c0e/components/cronet/android/BUILD.gn
[modify] https://crrev.com/624c32473d6d601e104bca2d91d68a0fa0266c0e/components/cronet/tools/jar_src.py

Comment 2 by kapishnikov@chromium.org, Sep 21 2016

Status: Fixed (was: Available)

Comment 3 by jbudorick@chromium.org, Dec 14 2016 

 Issue 674292  has been merged into this issue.

Comment 4 by jbudorick@chromium.org, Dec 14 2016 

re #3: disregard, wrong bug number.
►

Sign in to add a comment