New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 647290 link

Starred by 1 user
Status: Fixed
Owner:
mfo...@chromium.org
Closed: Mar 2017
Cc:
█ apaci...@chromium.org
█ imch...@chromium.org
█ zhaobin@chromium.org
btolsch@chromium.org
mfo...@chromium.org
powerb@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug



Sign in to add a comment

[Presentation API] PresentationSession => PresentationConnection

Project Member Reported by mfo...@chromium.org, Sep 15 2016 
presentation.mojom and related APIs still use "Session" to refer to a PresentationConnection.  This terminology is from an older version of the spec and is not current.

This tracks the work to use "Connection" consistently in content/presentation (and downstream, if necessary).

Comment 1 by mfo...@chromium.org, Sep 15 2016

Components: Blink>PresentationAPI

Comment 2 by sko...@chromium.org, Sep 21 2016

Status: Available (was: Untriaged)

Comment 3 by mfo...@chromium.org, Mar 9 2017

Cc: -binzhao@chromium.org zhaobin@chromium.org
Owner: mfo...@chromium.org
Status: Started (was: Available)
Project Member

Comment 4 by bugdroid1@chromium.org, Mar 20 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/11fc4df8400a28054b5f5081e67985e83c387643

commit 11fc4df8400a28054b5f5081e67985e83c387643
Author: mfoltz <mfoltz@chromium.org>
Date: Mon Mar 20 23:49:18 2017

[Presentation API] Remove references to presentation sessions.

"Sessions" are from an early draft of the Presentation API and they are confusing to define APIs around as they are not defined by the current spec.

This mechanical change updates the PresentationService mojo API, and upstream and downstream APIs, to remove references to them.

Renamings in presentation.mojom:

  PresentationSessionInfo => PresentationInfo
  SESSION_REQUEST_CANCELLED => PRESENTATION_REQUEST_CANCELLED
  OnDefaultSessionStarted => OnDefaultPresentationStarted
  StartSession => StartPresentation
  JoinSession => ReconnectPresentation
  OnDefaultSessionStarted => OnDefaultPresentationStarted

In WebPresentationClient:

  terminateConnection => terminatePresentation
  closeSession => closeConnection

In WebPresentationController:

  didStartDefaultSession => didStartDefaultPresentation
  didChangeSessionState => didChangeConnectionState
  didReceiveSessionTextMessage => didReceiveConnectionTextMessage
  didReceiveSessionBinaryMessage => didReceiveConnectionBinaryMessage

In WebPresentationReceiver:

  didChangeSessionState => didChangeConnectionState

In PresentationServiceDelegate:

  PresentationSessionStartedCallback => PresentationConnectionCallback
  PresentationSessionErrorCallback => PresentationConnectionErrorCallback

BUG= 647290 

Review-Url: https://codereview.chromium.org/2737413003
Cr-Commit-Position: refs/heads/master@{#458243}

[modify] https://crrev.com/11fc4df8400a28054b5f5081e67985e83c387643/chrome/browser/media/android/router/media_router_dialog_controller_android.cc
[modify] https://crrev.com/11fc4df8400a28054b5f5081e67985e83c387643/chrome/browser/media/router/browser_presentation_connection_proxy.h
[modify] https://crrev.com/11fc4df8400a28054b5f5081e67985e83c387643/chrome/browser/media/router/create_presentation_connection_request.cc
[modify] https://crrev.com/11fc4df8400a28054b5f5081e67985e83c387643/chrome/browser/media/router/create_presentation_connection_request.h
[modify] https://crrev.com/11fc4df8400a28054b5f5081e67985e83c387643/chrome/browser/media/router/create_presentation_connection_request_unittest.cc
[modify] https://crrev.com/11fc4df8400a28054b5f5081e67985e83c387643/chrome/browser/media/router/media_route.h
[modify] https://crrev.com/11fc4df8400a28054b5f5081e67985e83c387643/chrome/browser/media/router/media_router_base_unittest.cc
[modify] https://crrev.com/11fc4df8400a28054b5f5081e67985e83c387643/chrome/browser/media/router/media_router_dialog_controller_unittest.cc
[modify] https://crrev.com/11fc4df8400a28054b5f5081e67985e83c387643/chrome/browser/media/router/mojo/media_router.mojom
[modify] https://crrev.com/11fc4df8400a28054b5f5081e67985e83c387643/chrome/browser/media/router/mojo/media_router.typemap
[modify] https://crrev.com/11fc4df8400a28054b5f5081e67985e83c387643/chrome/browser/media/router/mojo/media_router_mojo_impl_unittest.cc
[modify] https://crrev.com/11fc4df8400a28054b5f5081e67985e83c387643/chrome/browser/media/router/offscreen_presentation_manager.cc
[modify] https://crrev.com/11fc4df8400a28054b5f5081e67985e83c387643/chrome/browser/media/router/offscreen_presentation_manager.h
[modify] https://crrev.com/11fc4df8400a28054b5f5081e67985e83c387643/chrome/browser/media/router/offscreen_presentation_manager_unittest.cc
[modify] https://crrev.com/11fc4df8400a28054b5f5081e67985e83c387643/chrome/browser/media/router/presentation_service_delegate_impl.cc
[modify] https://crrev.com/11fc4df8400a28054b5f5081e67985e83c387643/chrome/browser/media/router/presentation_service_delegate_impl.h
[modify] https://crrev.com/11fc4df8400a28054b5f5081e67985e83c387643/chrome/browser/media/router/presentation_service_delegate_impl_unittest.cc
[modify] https://crrev.com/11fc4df8400a28054b5f5081e67985e83c387643/chrome/browser/ui/webui/media_router/media_router_dialog_controller_impl_unittest.cc
[modify] https://crrev.com/11fc4df8400a28054b5f5081e67985e83c387643/chrome/browser/ui/webui/media_router/media_router_ui.cc
[modify] https://crrev.com/11fc4df8400a28054b5f5081e67985e83c387643/chrome/browser/ui/webui/media_router/media_router_ui_unittest.cc
[modify] https://crrev.com/11fc4df8400a28054b5f5081e67985e83c387643/chrome/browser/ui/webui/media_router/media_router_webui_message_handler.h
[modify] https://crrev.com/11fc4df8400a28054b5f5081e67985e83c387643/content/browser/presentation/presentation_service_impl.cc
[modify] https://crrev.com/11fc4df8400a28054b5f5081e67985e83c387643/content/browser/presentation/presentation_service_impl.h
[modify] https://crrev.com/11fc4df8400a28054b5f5081e67985e83c387643/content/browser/presentation/presentation_service_impl_unittest.cc
[modify] https://crrev.com/11fc4df8400a28054b5f5081e67985e83c387643/content/common/presentation/presentation.typemap
[modify] https://crrev.com/11fc4df8400a28054b5f5081e67985e83c387643/content/common/presentation/presentation_struct_traits.cc
[modify] https://crrev.com/11fc4df8400a28054b5f5081e67985e83c387643/content/common/presentation/presentation_struct_traits.h
[modify] https://crrev.com/11fc4df8400a28054b5f5081e67985e83c387643/content/public/browser/presentation_service_delegate.h
[modify] https://crrev.com/11fc4df8400a28054b5f5081e67985e83c387643/content/public/common/BUILD.gn
[add] https://crrev.com/11fc4df8400a28054b5f5081e67985e83c387643/content/public/common/presentation_info.cc
[rename] https://crrev.com/11fc4df8400a28054b5f5081e67985e83c387643/content/public/common/presentation_info.h
[delete] https://crrev.com/79fa3471cea36082fa33d26b452878490b9cba84/content/public/common/presentation_session.cc
[modify] https://crrev.com/11fc4df8400a28054b5f5081e67985e83c387643/content/renderer/presentation/presentation_connection_proxy.cc
[modify] https://crrev.com/11fc4df8400a28054b5f5081e67985e83c387643/content/renderer/presentation/presentation_dispatcher.cc
[modify] https://crrev.com/11fc4df8400a28054b5f5081e67985e83c387643/content/renderer/presentation/presentation_dispatcher.h
[modify] https://crrev.com/11fc4df8400a28054b5f5081e67985e83c387643/content/renderer/presentation/presentation_dispatcher_unittest.cc
[modify] https://crrev.com/11fc4df8400a28054b5f5081e67985e83c387643/third_party/WebKit/LayoutTests/presentation/presentation-controller-terminate-connection.html
[modify] https://crrev.com/11fc4df8400a28054b5f5081e67985e83c387643/third_party/WebKit/LayoutTests/presentation/presentation-onreceiverconnection.html
[modify] https://crrev.com/11fc4df8400a28054b5f5081e67985e83c387643/third_party/WebKit/LayoutTests/presentation/presentation-start-error.html
[modify] https://crrev.com/11fc4df8400a28054b5f5081e67985e83c387643/third_party/WebKit/LayoutTests/presentation/resources/presentation-service-mock.js
[modify] https://crrev.com/11fc4df8400a28054b5f5081e67985e83c387643/third_party/WebKit/Source/modules/presentation/ExistingPresentationConnectionCallbacks.cpp
[modify] https://crrev.com/11fc4df8400a28054b5f5081e67985e83c387643/third_party/WebKit/Source/modules/presentation/ExistingPresentationConnectionCallbacks.h
[modify] https://crrev.com/11fc4df8400a28054b5f5081e67985e83c387643/third_party/WebKit/Source/modules/presentation/PresentationConnection.cpp
[modify] https://crrev.com/11fc4df8400a28054b5f5081e67985e83c387643/third_party/WebKit/Source/modules/presentation/PresentationConnection.h
[modify] https://crrev.com/11fc4df8400a28054b5f5081e67985e83c387643/third_party/WebKit/Source/modules/presentation/PresentationConnectionCallbacks.cpp
[modify] https://crrev.com/11fc4df8400a28054b5f5081e67985e83c387643/third_party/WebKit/Source/modules/presentation/PresentationConnectionCallbacks.h
[modify] https://crrev.com/11fc4df8400a28054b5f5081e67985e83c387643/third_party/WebKit/Source/modules/presentation/PresentationController.cpp
[modify] https://crrev.com/11fc4df8400a28054b5f5081e67985e83c387643/third_party/WebKit/Source/modules/presentation/PresentationController.h
[modify] https://crrev.com/11fc4df8400a28054b5f5081e67985e83c387643/third_party/WebKit/Source/modules/presentation/PresentationError.cpp
[modify] https://crrev.com/11fc4df8400a28054b5f5081e67985e83c387643/third_party/WebKit/Source/modules/presentation/PresentationReceiver.cpp
[modify] https://crrev.com/11fc4df8400a28054b5f5081e67985e83c387643/third_party/WebKit/Source/modules/presentation/PresentationReceiver.h
[modify] https://crrev.com/11fc4df8400a28054b5f5081e67985e83c387643/third_party/WebKit/Source/modules/presentation/PresentationReceiverTest.cpp
[modify] https://crrev.com/11fc4df8400a28054b5f5081e67985e83c387643/third_party/WebKit/Source/modules/presentation/PresentationRequest.cpp
[modify] https://crrev.com/11fc4df8400a28054b5f5081e67985e83c387643/third_party/WebKit/public/BUILD.gn
[modify] https://crrev.com/11fc4df8400a28054b5f5081e67985e83c387643/third_party/WebKit/public/platform/modules/presentation/WebPresentationClient.h
[modify] https://crrev.com/11fc4df8400a28054b5f5081e67985e83c387643/third_party/WebKit/public/platform/modules/presentation/WebPresentationConnectionCallbacks.h
[modify] https://crrev.com/11fc4df8400a28054b5f5081e67985e83c387643/third_party/WebKit/public/platform/modules/presentation/WebPresentationController.h
[modify] https://crrev.com/11fc4df8400a28054b5f5081e67985e83c387643/third_party/WebKit/public/platform/modules/presentation/WebPresentationError.h
[rename] https://crrev.com/11fc4df8400a28054b5f5081e67985e83c387643/third_party/WebKit/public/platform/modules/presentation/WebPresentationInfo.h
[modify] https://crrev.com/11fc4df8400a28054b5f5081e67985e83c387643/third_party/WebKit/public/platform/modules/presentation/WebPresentationReceiver.h
[modify] https://crrev.com/11fc4df8400a28054b5f5081e67985e83c387643/third_party/WebKit/public/platform/modules/presentation/presentation.mojom

Comment 5 by mfo...@chromium.org, Mar 20 2017

Status: Fixed (was: Started)
Hoping this sticks *crosses fingers*
►

Sign in to add a comment