New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 647286 link

Starred by 3 users
Status: Fixed
Owner:
patricia...@chromium.org
Closed: May 2018
Cc:
pbos@chromium.org
█ tdander...@chromium.org
est...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 2
Type: Bug

Blocking:
issue 801583



Sign in to add a comment

vector icons: support arbitrarily many versions for a single icon

Project Member Reported by est...@chromium.org, Sep 15 2016 
currently each icon gets at most two representations: one used at 1x scale and one used at all other scales. If you want an icon to be used at 16x16 in one place and 20x20 in another UI surface, if you want to tweak the icon for display at 20x20 then you have to add a separate icon definition for it. It would be nicer if a single icon definition incorporated 16x16, 20x20, 32x32 and 40x40 for this situation. One extra benefit is that we'd reuse the 20x20 specific definition for a 16dp icon @1.25dsf, instead of using the 32x32 and scaling down.

see for example the help icons added here[1] or ash::kSystemMenuBusinessIcon etc.

[1] https://chromiumcodereview.appspot.com/2327943002/

Comment 1 by tdander...@chromium.org, Sep 15 2016

Labels: Hotlist-VectorIcons

Comment 2 by patricia...@chromium.org, Mar 1 2018

Blocking: 801583
Cc: est...@chromium.org
Owner: patricia...@chromium.org
Project Member

Comment 3 by bugdroid1@chromium.org, Mar 13 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/43696b7f48e3de69b9ee12701feb27fd4254053d

commit 43696b7f48e3de69b9ee12701feb27fd4254053d
Author: Patti <patricialor@chromium.org>
Date: Tue Mar 13 02:51:02 2018

Vector Icons: Add VectorIconRep for a sized representation of a VectorIcon.

VectorIcons currently have two representations - a version used at 100% scale
(its |path_1x|) and a version used at all other scale factors (|path|). This
isn't scaleable and can't support having more than two icon representations per
VectorIcon, so add gfx::VectorIconRep to prepare for this.

Bug:  647286 
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: Iff59deb2064ce0f0995016fee9dcdeda16999605
Reviewed-on: https://chromium-review.googlesource.com/942647
Commit-Queue: Patti <patricialor@chromium.org>
Reviewed-by: Evan Stade <estade@chromium.org>
Reviewed-by: Christopher Grant <cjgrant@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542703}
[modify] https://crrev.com/43696b7f48e3de69b9ee12701feb27fd4254053d/chrome/browser/vr/elements/vector_icon.cc
[modify] https://crrev.com/43696b7f48e3de69b9ee12701feb27fd4254053d/components/vector_icons/aggregate_vector_icons.py
[modify] https://crrev.com/43696b7f48e3de69b9ee12701feb27fd4254053d/components/vector_icons/cc_macros.h
[modify] https://crrev.com/43696b7f48e3de69b9ee12701feb27fd4254053d/ui/gfx/paint_vector_icon.cc
[modify] https://crrev.com/43696b7f48e3de69b9ee12701feb27fd4254053d/ui/gfx/paint_vector_icon_unittest.cc
[modify] https://crrev.com/43696b7f48e3de69b9ee12701feb27fd4254053d/ui/gfx/vector_icon_types.h
Project Member

Comment 4 by bugdroid1@chromium.org, Mar 23 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/877c14658b8234f20d24545d7684191b3de9b387

commit 877c14658b8234f20d24545d7684191b3de9b387
Author: Patti <patricialor@chromium.org>
Date: Thu Mar 22 23:47:46 2018

Vector Icons: Merge 1x and non-1x icons into one file.

In order to support a future state where vector icons can have an arbitrary
number of vector icon representations, merge all icon representations into the
same file. This means future icon directories will be cleaner and avoids the
problem of having duplicate icon size declarations in the filename and in the
icon file itself.

Bug:  647286 
Change-Id: Ie0c68b10752dea87870d85a4669463196bc433b2
Reviewed-on: https://chromium-review.googlesource.com/961626
Reviewed-by: Sam McNally <sammc@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Evan Stade <estade@chromium.org>
Commit-Queue: Patti <patricialor@chromium.org>
Cr-Commit-Position: refs/heads/master@{#545291}
[modify] https://crrev.com/877c14658b8234f20d24545d7684191b3de9b387/ash/components/shortcut_viewer/vector_icons/BUILD.gn
[delete] https://crrev.com/7b485fc777e2aedf7031f8dd62ade73f8becd2ee/ash/components/shortcut_viewer/vector_icons/ksv_arrow_down.1x.icon
[modify] https://crrev.com/877c14658b8234f20d24545d7684191b3de9b387/ash/components/shortcut_viewer/vector_icons/ksv_arrow_down.icon
[delete] https://crrev.com/7b485fc777e2aedf7031f8dd62ade73f8becd2ee/ash/components/shortcut_viewer/vector_icons/ksv_arrow_left.1x.icon
[modify] https://crrev.com/877c14658b8234f20d24545d7684191b3de9b387/ash/components/shortcut_viewer/vector_icons/ksv_arrow_left.icon
[delete] https://crrev.com/7b485fc777e2aedf7031f8dd62ade73f8becd2ee/ash/components/shortcut_viewer/vector_icons/ksv_arrow_right.1x.icon
[modify] https://crrev.com/877c14658b8234f20d24545d7684191b3de9b387/ash/components/shortcut_viewer/vector_icons/ksv_arrow_right.icon
[delete] https://crrev.com/7b485fc777e2aedf7031f8dd62ade73f8becd2ee/ash/components/shortcut_viewer/vector_icons/ksv_arrow_up.1x.icon
[modify] https://crrev.com/877c14658b8234f20d24545d7684191b3de9b387/ash/components/shortcut_viewer/vector_icons/ksv_arrow_up.icon
[delete] https://crrev.com/7b485fc777e2aedf7031f8dd62ade73f8becd2ee/ash/components/shortcut_viewer/vector_icons/ksv_brightness_down.1x.icon
[modify] https://crrev.com/877c14658b8234f20d24545d7684191b3de9b387/ash/components/shortcut_viewer/vector_icons/ksv_brightness_down.icon
[delete] https://crrev.com/7b485fc777e2aedf7031f8dd62ade73f8becd2ee/ash/components/shortcut_viewer/vector_icons/ksv_brightness_up.1x.icon
[modify] https://crrev.com/877c14658b8234f20d24545d7684191b3de9b387/ash/components/shortcut_viewer/vector_icons/ksv_brightness_up.icon
[delete] https://crrev.com/7b485fc777e2aedf7031f8dd62ade73f8becd2ee/ash/components/shortcut_viewer/vector_icons/ksv_browser_back.1x.icon
[modify] https://crrev.com/877c14658b8234f20d24545d7684191b3de9b387/ash/components/shortcut_viewer/vector_icons/ksv_browser_back.icon
[delete] https://crrev.com/7b485fc777e2aedf7031f8dd62ade73f8becd2ee/ash/components/shortcut_viewer/vector_icons/ksv_browser_forward.1x.icon
[modify] https://crrev.com/877c14658b8234f20d24545d7684191b3de9b387/ash/components/shortcut_viewer/vector_icons/ksv_browser_forward.icon
[delete] https://crrev.com/7b485fc777e2aedf7031f8dd62ade73f8becd2ee/ash/components/shortcut_viewer/vector_icons/ksv_fullscreen.1x.icon
[modify] https://crrev.com/877c14658b8234f20d24545d7684191b3de9b387/ash/components/shortcut_viewer/vector_icons/ksv_fullscreen.icon
[delete] https://crrev.com/7b485fc777e2aedf7031f8dd62ade73f8becd2ee/ash/components/shortcut_viewer/vector_icons/ksv_mute.1x.icon
[modify] https://crrev.com/877c14658b8234f20d24545d7684191b3de9b387/ash/components/shortcut_viewer/vector_icons/ksv_mute.icon
[delete] https://crrev.com/7b485fc777e2aedf7031f8dd62ade73f8becd2ee/ash/components/shortcut_viewer/vector_icons/ksv_overview.1x.icon
[modify] https://crrev.com/877c14658b8234f20d24545d7684191b3de9b387/ash/components/shortcut_viewer/vector_icons/ksv_overview.icon
[delete] https://crrev.com/7b485fc777e2aedf7031f8dd62ade73f8becd2ee/ash/components/shortcut_viewer/vector_icons/ksv_reload.1x.icon
[modify] https://crrev.com/877c14658b8234f20d24545d7684191b3de9b387/ash/components/shortcut_viewer/vector_icons/ksv_reload.icon
[delete] https://crrev.com/7b485fc777e2aedf7031f8dd62ade73f8becd2ee/ash/components/shortcut_viewer/vector_icons/ksv_search_back.1x.icon
[modify] https://crrev.com/877c14658b8234f20d24545d7684191b3de9b387/ash/components/shortcut_viewer/vector_icons/ksv_search_back.icon
[delete] https://crrev.com/7b485fc777e2aedf7031f8dd62ade73f8becd2ee/ash/components/shortcut_viewer/vector_icons/ksv_search_bar.1x.icon
[modify] https://crrev.com/877c14658b8234f20d24545d7684191b3de9b387/ash/components/shortcut_viewer/vector_icons/ksv_search_bar.icon
[delete] https://crrev.com/7b485fc777e2aedf7031f8dd62ade73f8becd2ee/ash/components/shortcut_viewer/vector_icons/ksv_search_close.1x.icon
[modify] https://crrev.com/877c14658b8234f20d24545d7684191b3de9b387/ash/components/shortcut_viewer/vector_icons/ksv_search_close.icon
[delete] https://crrev.com/7b485fc777e2aedf7031f8dd62ade73f8becd2ee/ash/components/shortcut_viewer/vector_icons/ksv_search_no_result.1x.icon
[modify] https://crrev.com/877c14658b8234f20d24545d7684191b3de9b387/ash/components/shortcut_viewer/vector_icons/ksv_search_no_result.icon
[delete] https://crrev.com/7b485fc777e2aedf7031f8dd62ade73f8becd2ee/ash/components/shortcut_viewer/vector_icons/ksv_separator_plus.1x.icon
[modify] https://crrev.com/877c14658b8234f20d24545d7684191b3de9b387/ash/components/shortcut_viewer/vector_icons/ksv_separator_plus.icon
[delete] https://crrev.com/7b485fc777e2aedf7031f8dd62ade73f8becd2ee/ash/components/shortcut_viewer/vector_icons/ksv_volume_down.1x.icon
[modify] https://crrev.com/877c14658b8234f20d24545d7684191b3de9b387/ash/components/shortcut_viewer/vector_icons/ksv_volume_down.icon
[delete] https://crrev.com/7b485fc777e2aedf7031f8dd62ade73f8becd2ee/ash/components/shortcut_viewer/vector_icons/ksv_volume_up.1x.icon
[modify] https://crrev.com/877c14658b8234f20d24545d7684191b3de9b387/ash/components/shortcut_viewer/vector_icons/ksv_volume_up.icon
[modify] https://crrev.com/877c14658b8234f20d24545d7684191b3de9b387/ash/public/cpp/vector_icons/BUILD.gn
[delete] https://crrev.com/7b485fc777e2aedf7031f8dd62ade73f8becd2ee/ash/public/cpp/vector_icons/notification_cellular_alert.1x.icon
[modify] https://crrev.com/877c14658b8234f20d24545d7684191b3de9b387/ash/public/cpp/vector_icons/notification_cellular_alert.icon
[delete] https://crrev.com/7b485fc777e2aedf7031f8dd62ade73f8becd2ee/ash/public/cpp/vector_icons/window_control_back.1x.icon
[modify] https://crrev.com/877c14658b8234f20d24545d7684191b3de9b387/ash/public/cpp/vector_icons/window_control_back.icon
[delete] https://crrev.com/7b485fc777e2aedf7031f8dd62ade73f8becd2ee/ash/public/cpp/vector_icons/window_control_close.1x.icon
[modify] https://crrev.com/877c14658b8234f20d24545d7684191b3de9b387/ash/public/cpp/vector_icons/window_control_close.icon
[delete] https://crrev.com/7b485fc777e2aedf7031f8dd62ade73f8becd2ee/ash/public/cpp/vector_icons/window_control_dezoom.1x.icon
[modify] https://crrev.com/877c14658b8234f20d24545d7684191b3de9b387/ash/public/cpp/vector_icons/window_control_dezoom.icon
[delete] https://crrev.com/7b485fc777e2aedf7031f8dd62ade73f8becd2ee/ash/public/cpp/vector_icons/window_control_left_snapped.1x.icon
[modify] https://crrev.com/877c14658b8234f20d24545d7684191b3de9b387/ash/public/cpp/vector_icons/window_control_left_snapped.icon
[delete] https://crrev.com/7b485fc777e2aedf7031f8dd62ade73f8becd2ee/ash/public/cpp/vector_icons/window_control_maximize.1x.icon
[modify] https://crrev.com/877c14658b8234f20d24545d7684191b3de9b387/ash/public/cpp/vector_icons/window_control_maximize.icon
[delete] https://crrev.com/7b485fc777e2aedf7031f8dd62ade73f8becd2ee/ash/public/cpp/vector_icons/window_control_menu.1x.icon
[modify] https://crrev.com/877c14658b8234f20d24545d7684191b3de9b387/ash/public/cpp/vector_icons/window_control_menu.icon
[delete] https://crrev.com/7b485fc777e2aedf7031f8dd62ade73f8becd2ee/ash/public/cpp/vector_icons/window_control_minimize.1x.icon
[modify] https://crrev.com/877c14658b8234f20d24545d7684191b3de9b387/ash/public/cpp/vector_icons/window_control_minimize.icon
[delete] https://crrev.com/7b485fc777e2aedf7031f8dd62ade73f8becd2ee/ash/public/cpp/vector_icons/window_control_restore.1x.icon
[modify] https://crrev.com/877c14658b8234f20d24545d7684191b3de9b387/ash/public/cpp/vector_icons/window_control_restore.icon
[delete] https://crrev.com/7b485fc777e2aedf7031f8dd62ade73f8becd2ee/ash/public/cpp/vector_icons/window_control_right_snapped.1x.icon
[modify] https://crrev.com/877c14658b8234f20d24545d7684191b3de9b387/ash/public/cpp/vector_icons/window_control_right_snapped.icon
[delete] https://crrev.com/7b485fc777e2aedf7031f8dd62ade73f8becd2ee/ash/public/cpp/vector_icons/window_control_zoom.1x.icon
[modify] https://crrev.com/877c14658b8234f20d24545d7684191b3de9b387/ash/public/cpp/vector_icons/window_control_zoom.icon
[modify] https://crrev.com/877c14658b8234f20d24545d7684191b3de9b387/ash/resources/vector_icons/BUILD.gn
[delete] https://crrev.com/7b485fc777e2aedf7031f8dd62ade73f8becd2ee/ash/resources/vector_icons/captive_portal.1x.icon
[modify] https://crrev.com/877c14658b8234f20d24545d7684191b3de9b387/ash/resources/vector_icons/captive_portal.icon
[delete] https://crrev.com/7b485fc777e2aedf7031f8dd62ade73f8becd2ee/ash/resources/vector_icons/check_circle.1x.icon
[modify] https://crrev.com/877c14658b8234f20d24545d7684191b3de9b387/ash/resources/vector_icons/check_circle.icon
[delete] https://crrev.com/7b485fc777e2aedf7031f8dd62ade73f8becd2ee/ash/resources/vector_icons/ime_menu_emoticon.1x.icon
[modify] https://crrev.com/877c14658b8234f20d24545d7684191b3de9b387/ash/resources/vector_icons/ime_menu_emoticon.icon
[delete] https://crrev.com/7b485fc777e2aedf7031f8dd62ade73f8becd2ee/ash/resources/vector_icons/ime_menu_microphone.1x.icon
[modify] https://crrev.com/877c14658b8234f20d24545d7684191b3de9b387/ash/resources/vector_icons/ime_menu_microphone.icon
[delete] https://crrev.com/7b485fc777e2aedf7031f8dd62ade73f8becd2ee/ash/resources/vector_icons/ime_menu_on_screen_keyboard.1x.icon
[modify] https://crrev.com/877c14658b8234f20d24545d7684191b3de9b387/ash/resources/vector_icons/ime_menu_on_screen_keyboard.icon
[delete] https://crrev.com/7b485fc777e2aedf7031f8dd62ade73f8becd2ee/ash/resources/vector_icons/ime_menu_write.1x.icon
[modify] https://crrev.com/877c14658b8234f20d24545d7684191b3de9b387/ash/resources/vector_icons/ime_menu_write.icon
[delete] https://crrev.com/7b485fc777e2aedf7031f8dd62ade73f8becd2ee/ash/resources/vector_icons/lock_screen_alert.1x.icon
[modify] https://crrev.com/877c14658b8234f20d24545d7684191b3de9b387/ash/resources/vector_icons/lock_screen_alert.icon
[delete] https://crrev.com/7b485fc777e2aedf7031f8dd62ade73f8becd2ee/ash/resources/vector_icons/lock_screen_arrow.1x.icon
[modify] https://crrev.com/877c14658b8234f20d24545d7684191b3de9b387/ash/resources/vector_icons/lock_screen_arrow.icon
[delete] https://crrev.com/7b485fc777e2aedf7031f8dd62ade73f8becd2ee/ash/resources/vector_icons/lock_screen_backspace.1x.icon
[modify] https://crrev.com/877c14658b8234f20d24545d7684191b3de9b387/ash/resources/vector_icons/lock_screen_backspace.icon
[delete] https://crrev.com/7b485fc777e2aedf7031f8dd62ade73f8becd2ee/ash/resources/vector_icons/lock_screen_caps_lock.1x.icon
[modify] https://crrev.com/877c14658b8234f20d24545d7684191b3de9b387/ash/resources/vector_icons/lock_screen_caps_lock.icon
[delete] https://crrev.com/7b485fc777e2aedf7031f8dd62ade73f8becd2ee/ash/resources/vector_icons/lock_screen_dropdown.1x.icon
[modify] https://crrev.com/877c14658b8234f20d24545d7684191b3de9b387/ash/resources/vector_icons/lock_screen_dropdown.icon
[delete] https://crrev.com/7b485fc777e2aedf7031f8dd62ade73f8becd2ee/ash/resources/vector_icons/login_screen_enterprise.1x.icon
[modify] https://crrev.com/877c14658b8234f20d24545d7684191b3de9b387/ash/resources/vector_icons/login_screen_enterprise.icon
[delete] https://crrev.com/7b485fc777e2aedf7031f8dd62ade73f8becd2ee/ash/resources/vector_icons/network_badge_add_other.1x.icon
[modify] https://crrev.com/877c14658b8234f20d24545d7684191b3de9b387/ash/resources/vector_icons/network_badge_add_other.icon
[delete] https://crrev.com/7b485fc777e2aedf7031f8dd62ade73f8becd2ee/ash/resources/vector_icons/network_badge_captive_portal.1x.icon
[modify] https://crrev.com/877c14658b8234f20d24545d7684191b3de9b387/ash/resources/vector_icons/network_badge_captive_portal.icon
[delete] https://crrev.com/7b485fc777e2aedf7031f8dd62ade73f8becd2ee/ash/resources/vector_icons/network_badge_off.1x.icon
[modify] https://crrev.com/877c14658b8234f20d24545d7684191b3de9b387/ash/resources/vector_icons/network_badge_off.icon
[delete] https://crrev.com/7b485fc777e2aedf7031f8dd62ade73f8becd2ee/ash/resources/vector_icons/network_badge_roaming.1x.icon
[modify] https://crrev.com/877c14658b8234f20d24545d7684191b3de9b387/ash/resources/vector_icons/network_badge_roaming.icon
[delete] https://crrev.com/7b485fc777e2aedf7031f8dd62ade73f8becd2ee/ash/resources/vector_icons/network_badge_secure.1x.icon
[modify] https://crrev.com/877c14658b8234f20d24545d7684191b3de9b387/ash/resources/vector_icons/network_badge_secure.icon
[delete] https://crrev.com/7b485fc777e2aedf7031f8dd62ade73f8becd2ee/ash/resources/vector_icons/network_badge_technology_1x.1x.icon
[modify] https://crrev.com/877c14658b8234f20d24545d7684191b3de9b387/ash/resources/vector_icons/network_badge_technology_1x.icon
[delete] https://crrev.com/7b485fc777e2aedf7031f8dd62ade73f8becd2ee/ash/resources/vector_icons/network_badge_technology_3g.1x.icon
[modify] https://crrev.com/877c14658b8234f20d24545d7684191b3de9b387/ash/resources/vector_icons/network_badge_technology_3g.icon
[delete] https://crrev.com/7b485fc777e2aedf7031f8dd62ade73f8becd2ee/ash/resources/vector_icons/network_badge_technology_4g.1x.icon
[modify] https://crrev.com/877c14658b8234f20d24545d7684191b3de9b387/ash/resources/vector_icons/network_badge_technology_4g.icon
[delete] https://crrev.com/7b485fc777e2aedf7031f8dd62ade73f8becd2ee/ash/resources/vector_icons/network_badge_technology_edge.1x.icon
[modify] https://crrev.com/877c14658b8234f20d24545d7684191b3de9b387/ash/resources/vector_icons/network_badge_technology_edge.icon
[delete] https://crrev.com/7b485fc777e2aedf7031f8dd62ade73f8becd2ee/ash/resources/vector_icons/network_badge_technology_evdo.1x.icon
[modify] https://crrev.com/877c14658b8234f20d24545d7684191b3de9b387/ash/resources/vector_icons/network_badge_technology_evdo.icon
[delete] https://crrev.com/7b485fc777e2aedf7031f8dd62ade73f8becd2ee/ash/resources/vector_icons/network_badge_technology_gprs.1x.icon
[modify] https://crrev.com/877c14658b8234f20d24545d7684191b3de9b387/ash/resources/vector_icons/network_badge_technology_gprs.icon
[delete] https://crrev.com/7b485fc777e2aedf7031f8dd62ade73f8becd2ee/ash/resources/vector_icons/network_badge_technology_hspa.1x.icon
[modify] https://crrev.com/877c14658b8234f20d24545d7684191b3de9b387/ash/resources/vector_icons/network_badge_technology_hspa.icon
[delete] https://crrev.com/7b485fc777e2aedf7031f8dd62ade73f8becd2ee/ash/resources/vector_icons/network_badge_technology_hspa_plus.1x.icon
[modify] https://crrev.com/877c14658b8234f20d24545d7684191b3de9b387/ash/resources/vector_icons/network_badge_technology_hspa_plus.icon
[delete] https://crrev.com/7b485fc777e2aedf7031f8dd62ade73f8becd2ee/ash/resources/vector_icons/network_badge_technology_lte.1x.icon
[modify] https://crrev.com/877c14658b8234f20d24545d7684191b3de9b387/ash/resources/vector_icons/network_badge_technology_lte.icon
[delete] https://crrev.com/7b485fc777e2aedf7031f8dd62ade73f8becd2ee/ash/resources/vector_icons/network_badge_technology_lte_advanced.1x.icon
[modify] https://crrev.com/877c14658b8234f20d24545d7684191b3de9b387/ash/resources/vector_icons/network_badge_technology_lte_advanced.icon
[delete] https://crrev.com/7b485fc777e2aedf7031f8dd62ade73f8becd2ee/ash/resources/vector_icons/network_badge_vpn.1x.icon
[modify] https://crrev.com/877c14658b8234f20d24545d7684191b3de9b387/ash/resources/vector_icons/network_badge_vpn.icon
[delete] https://crrev.com/7b485fc777e2aedf7031f8dd62ade73f8becd2ee/ash/resources/vector_icons/network_ethernet.1x.icon
[modify] https://crrev.com/877c14658b8234f20d24545d7684191b3de9b387/ash/resources/vector_icons/network_ethernet.icon
[delete] https://crrev.com/7b485fc777e2aedf7031f8dd62ade73f8becd2ee/ash/resources/vector_icons/network_mobile_not_connected_x.1x.icon
[modify] https://crrev.com/877c14658b8234f20d24545d7684191b3de9b387/ash/resources/vector_icons/network_mobile_not_connected_x.icon
[delete] https://crrev.com/7b485fc777e2aedf7031f8dd62ade73f8becd2ee/ash/resources/vector_icons/network_vpn.1x.icon
[modify] https://crrev.com/877c14658b8234f20d24545d7684191b3de9b387/ash/resources/vector_icons/network_vpn.icon
[delete] https://crrev.com/7b485fc777e2aedf7031f8dd62ade73f8becd2ee/ash/resources/vector_icons/palette_action_capture_region.1x.icon
[modify] https://crrev.com/877c14658b8234f20d24545d7684191b3de9b387/ash/resources/vector_icons/palette_action_capture_region.icon
[delete] https://crrev.com/7b485fc777e2aedf7031f8dd62ade73f8becd2ee/ash/resources/vector_icons/palette_action_capture_screen.1x.icon
[modify] https://crrev.com/877c14658b8234f20d24545d7684191b3de9b387/ash/resources/vector_icons/palette_action_capture_screen.icon
[delete] https://crrev.com/7b485fc777e2aedf7031f8dd62ade73f8becd2ee/ash/resources/vector_icons/palette_action_create_note.1x.icon
[modify] https://crrev.com/877c14658b8234f20d24545d7684191b3de9b387/ash/resources/vector_icons/palette_action_create_note.icon
[delete] https://crrev.com/7b485fc777e2aedf7031f8dd62ade73f8becd2ee/ash/resources/vector_icons/palette_mode_laser_pointer.1x.icon
[modify] https://crrev.com/877c14658b8234f20d24545d7684191b3de9b387/ash/resources/vector_icons/palette_mode_laser_pointer.icon
[delete] https://crrev.com/7b485fc777e2aedf7031f8dd62ade73f8becd2ee/ash/resources/vector_icons/palette_mode_magnify.1x.icon
[modify] https://crrev.com/877c14658b8234f20d24545d7684191b3de9b387/ash/resources/vector_icons/palette_mode_magnify.icon
[delete] https://crrev.com/7b485fc777e2aedf7031f8dd62ade73f8becd2ee/ash/resources/vector_icons/palette_mode_metalayer.1x.icon
[modify] https://crrev.com/877c14658b8234f20d24545d7684191b3de9b387/ash/resources/vector_icons/palette_mode_metalayer.icon
[delete] https://crrev.com/7b485fc777e2aedf7031f8dd62ade73f8becd2ee/ash/resources/vector_icons/palette_tray_icon_capture_region.1x.icon
[modify] https://crrev.com/877c14658b8234f20d24545d7684191b3de9b387/ash/resources/vector_icons/palette_tray_icon_capture_region.icon
[delete] https://crrev.com/7b485fc777e2aedf7031f8dd62ade73f8becd2ee/ash/resources/vector_icons/palette_tray_icon_default.1x.icon
[modify] https://crrev.com/877c14658b8234f20d24545d7684191b3de9b387/ash/resources/vector_icons/palette_tray_icon_default.icon
[delete] https://crrev.com/7b485fc777e2aedf7031f8dd62ade73f8becd2ee/ash/resources/vector_icons/palette_tray_icon_laser_pointer.1x.icon
[modify] https://crrev.com/877c14658b8234f20d24545d7684191b3de9b387/ash/resources/vector_icons/palette_tray_icon_laser_pointer.icon
[delete] https://crrev.com/7b485fc777e2aedf7031f8dd62ade73f8becd2ee/ash/resources/vector_icons/palette_tray_icon_magnify.1x.icon
[modify] https://crrev.com/877c14658b8234f20d24545d7684191b3de9b387/ash/resources/vector_icons/palette_tray_icon_magnify.icon
[delete] https://crrev.com/7b485fc777e2aedf7031f8dd62ade73f8becd2ee/ash/resources/vector_icons/palette_tray_icon_metalayer.1x.icon
[modify] https://crrev.com/877c14658b8234f20d24545d7684191b3de9b387/ash/resources/vector_icons/palette_tray_icon_metalayer.icon
[delete] https://crrev.com/7b485fc777e2aedf7031f8dd62ade73f8becd2ee/ash/resources/vector_icons/shelf_add_person_button.1x.icon
[modify] https://crrev.com/877c14658b8234f20d24545d7684191b3de9b387/ash/resources/vector_icons/shelf_add_person_button.icon
[delete] https://crrev.com/7b485fc777e2aedf7031f8dd62ade73f8becd2ee/ash/resources/vector_icons/shelf_back.1x.icon
[modify] https://crrev.com/877c14658b8234f20d24545d7684191b3de9b387/ash/resources/vector_icons/shelf_back.icon
[delete] https://crrev.com/7b485fc777e2aedf7031f8dd62ade73f8becd2ee/ash/resources/vector_icons/shelf_browse_as_guest_button.1x.icon
[modify] https://crrev.com/877c14658b8234f20d24545d7684191b3de9b387/ash/resources/vector_icons/shelf_browse_as_guest_button.icon
[delete] https://crrev.com/7b485fc777e2aedf7031f8dd62ade73f8becd2ee/ash/resources/vector_icons/shelf_cancel_button.1x.icon
[modify] https://crrev.com/877c14658b8234f20d24545d7684191b3de9b387/ash/resources/vector_icons/shelf_cancel_button.icon
[delete] https://crrev.com/7b485fc777e2aedf7031f8dd62ade73f8becd2ee/ash/resources/vector_icons/shelf_keyboard.1x.icon
[modify] https://crrev.com/877c14658b8234f20d24545d7684191b3de9b387/ash/resources/vector_icons/shelf_keyboard.icon
[delete] https://crrev.com/7b485fc777e2aedf7031f8dd62ade73f8becd2ee/ash/resources/vector_icons/shelf_logout.1x.icon
[modify] https://crrev.com/877c14658b8234f20d24545d7684191b3de9b387/ash/resources/vector_icons/shelf_logout.icon
[delete] https://crrev.com/7b485fc777e2aedf7031f8dd62ade73f8becd2ee/ash/resources/vector_icons/shelf_notifications.1x.icon
[modify] https://crrev.com/877c14658b8234f20d24545d7684191b3de9b387/ash/resources/vector_icons/shelf_notifications.icon
[delete] https://crrev.com/7b485fc777e2aedf7031f8dd62ade73f8becd2ee/ash/resources/vector_icons/shelf_overflow.1x.icon
[modify] https://crrev.com/877c14658b8234f20d24545d7684191b3de9b387/ash/resources/vector_icons/shelf_overflow.icon
[delete] https://crrev.com/7b485fc777e2aedf7031f8dd62ade73f8becd2ee/ash/resources/vector_icons/shelf_overview.1x.icon
[modify] https://crrev.com/877c14658b8234f20d24545d7684191b3de9b387/ash/resources/vector_icons/shelf_overview.icon
[delete] https://crrev.com/7b485fc777e2aedf7031f8dd62ade73f8becd2ee/ash/resources/vector_icons/shelf_shutdown_button.1x.icon
[modify] https://crrev.com/877c14658b8234f20d24545d7684191b3de9b387/ash/resources/vector_icons/shelf_shutdown_button.icon
[delete] https://crrev.com/7b485fc777e2aedf7031f8dd62ade73f8becd2ee/ash/resources/vector_icons/shelf_sign_out_button.1x.icon
[modify] https://crrev.com/877c14658b8234f20d24545d7684191b3de9b387/ash/resources/vector_icons/shelf_sign_out_button.icon
[delete] https://crrev.com/7b485fc777e2aedf7031f8dd62ade73f8becd2ee/ash/resources/vector_icons/shelf_unlock_button.1x.icon
[modify] https://crrev.com/877c14658b8234f20d24545d7684191b3de9b387/ash/resources/vector_icons/shelf_unlock_button.icon
[delete] https://crrev.com/7b485fc777e2aedf7031f8dd62ade73f8becd2ee/ash/resources/vector_icons/system_menu_accessibility.1x.icon
[modify] https://crrev.com/877c14658b8234f20d24545d7684191b3de9b387/ash/resources/vector_icons/system_menu_accessibility.icon
[delete] https://crrev.com/7b485fc777e2aedf7031f8dd62ade73f8becd2ee/ash/resources/vector_icons/system_menu_accessibility_auto_click.1x.icon
[modify] https://crrev.com/877c14658b8234f20d24545d7684191b3de9b387/ash/resources/vector_icons/system_menu_accessibility_auto_click.icon
[delete] https://crrev.com/7b485fc777e2aedf7031f8dd62ade73f8becd2ee/ash/resources/vector_icons/system_menu_accessibility_chromevox.1x.icon
[modify] https://crrev.com/877c14658b8234f20d24545d7684191b3de9b387/ash/resources/vector_icons/system_menu_accessibility_chromevox.icon
[delete] https://crrev.com/7b485fc777e2aedf7031f8dd62ade73f8becd2ee/ash/resources/vector_icons/system_menu_accessibility_contrast.1x.icon
[modify] https://crrev.com/877c14658b8234f20d24545d7684191b3de9b387/ash/resources/vector_icons/system_menu_accessibility_contrast.icon
[delete] https://crrev.com/7b485fc777e2aedf7031f8dd62ade73f8becd2ee/ash/resources/vector_icons/system_menu_accessibility_docked_magnifier.1x.icon
[modify] https://crrev.com/877c14658b8234f20d24545d7684191b3de9b387/ash/resources/vector_icons/system_menu_accessibility_docked_magnifier.icon
[delete] https://crrev.com/7b485fc777e2aedf7031f8dd62ade73f8becd2ee/ash/resources/vector_icons/system_menu_accessibility_fullscreen_magnifier.1x.icon
[modify] https://crrev.com/877c14658b8234f20d24545d7684191b3de9b387/ash/resources/vector_icons/system_menu_accessibility_fullscreen_magnifier.icon
[delete] https://crrev.com/7b485fc777e2aedf7031f8dd62ade73f8becd2ee/ash/resources/vector_icons/system_menu_accessibility_select_to_speak.1x.icon
[modify] https://crrev.com/877c14658b8234f20d24545d7684191b3de9b387/ash

Comment 5 by pbos@chromium.org, Mar 28 2018

Cc: pbos@chromium.org
Project Member

Comment 6 by bugdroid1@chromium.org, Apr 23 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5084aac830ad6c7c85c11adac1a034bb1410b733

commit 5084aac830ad6c7c85c11adac1a034bb1410b733
Author: Patti <patricialor@chromium.org>
Date: Mon Apr 23 02:18:47 2018

Vector Icons: Dynamically choose a VectorIconRep to draw based on px available.

Add support for an arbitrary number of sized versions (VectorIconRep) for a
single icon (VectorIcon). The icon drawn will be chosen from these versions,
depending on the pixel size requested. This also takes into account the scale
factor, so an icon designed for display at 20 pixels will be drawn for a
requested icon dip size of 16 and a scale factor of 125%.

With the exception of the largest icon, icons may never be upscaled, only
downscaled, so if the scale factor is 1.2 and the requested dip size is 16 and
we have a selection of icons with the following sizes: {48, 20, 16}, the 20px
icon will be drawn.

Bug:  647286 
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I399741a07d41d193ecac8310850e97c2b5d2706e
Reviewed-on: https://chromium-review.googlesource.com/983193
Reviewed-by: Christopher Grant <cjgrant@chromium.org>
Reviewed-by: Michael Wasserman <msw@chromium.org>
Reviewed-by: Evan Stade <estade@chromium.org>
Commit-Queue: Patti <patricialor@chromium.org>
Cr-Commit-Position: refs/heads/master@{#552619}
[modify] https://crrev.com/5084aac830ad6c7c85c11adac1a034bb1410b733/chrome/browser/ui/cocoa/download/download_shelf_controller.mm
[modify] https://crrev.com/5084aac830ad6c7c85c11adac1a034bb1410b733/chrome/browser/ui/views/download/download_shelf_view.cc
[modify] https://crrev.com/5084aac830ad6c7c85c11adac1a034bb1410b733/chrome/browser/ui/views/find_bar_view.cc
[modify] https://crrev.com/5084aac830ad6c7c85c11adac1a034bb1410b733/chrome/browser/ui/views/infobars/infobar_view.cc
[modify] https://crrev.com/5084aac830ad6c7c85c11adac1a034bb1410b733/chrome/browser/ui/views/page_info/chosen_object_view.cc
[modify] https://crrev.com/5084aac830ad6c7c85c11adac1a034bb1410b733/chrome/browser/vr/elements/vector_icon.cc
[modify] https://crrev.com/5084aac830ad6c7c85c11adac1a034bb1410b733/chrome/browser/vr/elements/vector_icon_unittest.cc
[modify] https://crrev.com/5084aac830ad6c7c85c11adac1a034bb1410b733/chrome/browser/vr/ui_scene_creator.cc
[modify] https://crrev.com/5084aac830ad6c7c85c11adac1a034bb1410b733/components/vector_icons/BUILD.gn
[modify] https://crrev.com/5084aac830ad6c7c85c11adac1a034bb1410b733/components/vector_icons/aggregate_vector_icons.py
[modify] https://crrev.com/5084aac830ad6c7c85c11adac1a034bb1410b733/components/vector_icons/cc_macros.h
[rename] https://crrev.com/5084aac830ad6c7c85c11adac1a034bb1410b733/components/vector_icons/close_rounded.icon
[modify] https://crrev.com/5084aac830ad6c7c85c11adac1a034bb1410b733/ui/gfx/paint_vector_icon.cc
[modify] https://crrev.com/5084aac830ad6c7c85c11adac1a034bb1410b733/ui/gfx/paint_vector_icon.h
[modify] https://crrev.com/5084aac830ad6c7c85c11adac1a034bb1410b733/ui/gfx/paint_vector_icon_unittest.cc
[modify] https://crrev.com/5084aac830ad6c7c85c11adac1a034bb1410b733/ui/gfx/vector_icon_types.h
[modify] https://crrev.com/5084aac830ad6c7c85c11adac1a034bb1410b733/ui/views/bubble/bubble_frame_view.cc
[modify] https://crrev.com/5084aac830ad6c7c85c11adac1a034bb1410b733/ui/views/controls/button/image_button_factory_unittest.cc
Project Member

Comment 7 by bugdroid1@chromium.org, Apr 26 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/eff689830ac5d5f9527ffbe18c78fc74ab636d97

commit eff689830ac5d5f9527ffbe18c78fc74ab636d97
Author: Patti <patricialor@chromium.org>
Date: Thu Apr 26 03:49:52 2018

Vector Icons: Update documentation for .1x.icon removal.

gfx::VectorIcons were refactored in r552619 to allow arbitrarily many versions
for the same icon. Update documentation to reflect this.

Bug:  647286 
Change-Id: I2b82a7c1c9832ed2a7bf4c83bd3223b7d73f1110
Reviewed-on: https://chromium-review.googlesource.com/1023625
Commit-Queue: Patti <patricialor@chromium.org>
Reviewed-by: Evan Stade <estade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553902}
[modify] https://crrev.com/eff689830ac5d5f9527ffbe18c78fc74ab636d97/components/vector_icons/README.md
Project Member

Comment 8 by bugdroid1@chromium.org, Apr 27 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ca89dad5312e5fff80fa319d583e98c9cb26d9d9

commit ca89dad5312e5fff80fa319d583e98c9cb26d9d9
Author: Patti <patricialor@chromium.org>
Date: Fri Apr 27 04:46:17 2018

Omnibox/Views: Merge extra 20x20 icons into their .icon file or remove them.

Now that a fix for  crbug.com/647286  has landed in r552619, the additional icons
added for 20x20 sizes in the omnibox can be merged back into the same icon file.
Note that only the 20x20 HTTP icon (http.icon) is merged, because scaling down
the existing 32x32 HTTP icon for use at 20x20 looks blurry. All other icons in
this patch look fine scaled.

Screenshots -
https://drive.google.com/file/d/1ROQ7L7fpb04wQ1MJZvx3mcKYnaFd5rwY/view?usp=sharing

Bug: 801583,  647286 
Change-Id: I5a7adedbe0358aaa321210cd601a88a782b51a76
Reviewed-on: https://chromium-review.googlesource.com/1023357
Commit-Queue: Patti <patricialor@chromium.org>
Reviewed-by: Evan Stade <estade@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#554307}
[modify] https://crrev.com/ca89dad5312e5fff80fa319d583e98c9cb26d9d9/chrome/app/vector_icons/BUILD.gn
[delete] https://crrev.com/ecc3b70bf2b7ed45546eead45383e83d0a85aec7/chrome/app/vector_icons/credit_card_20.icon
[modify] https://crrev.com/ca89dad5312e5fff80fa319d583e98c9cb26d9d9/chrome/browser/ui/toolbar/chrome_toolbar_model_delegate.cc
[modify] https://crrev.com/ca89dad5312e5fff80fa319d583e98c9cb26d9d9/chrome/browser/ui/views/autofill/save_card_icon_view.cc
[modify] https://crrev.com/ca89dad5312e5fff80fa319d583e98c9cb26d9d9/components/omnibox/browser/BUILD.gn
[modify] https://crrev.com/ca89dad5312e5fff80fa319d583e98c9cb26d9d9/components/omnibox/browser/autocomplete_match.cc
[delete] https://crrev.com/ecc3b70bf2b7ed45546eead45383e83d0a85aec7/components/omnibox/browser/vector_icons/extension_app_20.icon
[modify] https://crrev.com/ca89dad5312e5fff80fa319d583e98c9cb26d9d9/components/toolbar/BUILD.gn
[modify] https://crrev.com/ca89dad5312e5fff80fa319d583e98c9cb26d9d9/components/toolbar/toolbar_model_impl.cc
[modify] https://crrev.com/ca89dad5312e5fff80fa319d583e98c9cb26d9d9/components/toolbar/vector_icons/http.icon
[delete] https://crrev.com/ecc3b70bf2b7ed45546eead45383e83d0a85aec7/components/toolbar/vector_icons/http_20.icon
[delete] https://crrev.com/ecc3b70bf2b7ed45546eead45383e83d0a85aec7/components/toolbar/vector_icons/https_invalid_20.icon
[delete] https://crrev.com/ecc3b70bf2b7ed45546eead45383e83d0a85aec7/components/toolbar/vector_icons/https_valid_20.icon
[delete] https://crrev.com/ecc3b70bf2b7ed45546eead45383e83d0a85aec7/components/toolbar/vector_icons/product_20.icon

Comment 9 by patricia...@chromium.org, May 30 2018

Status: Fixed (was: Assigned)
►

Sign in to add a comment