Log UMA stats for CUPS functionality. Metrics TBD.
Preliminary list can be found here: https://docs.google.com/spreadsheets/d/1MLWXpbfAJDqqGrEAsJtjxyafgYZQqKzzrk-P-W-SrBI/edit#gid=0
Updating to justincarlson@. Latest doc at: https://docs.google.com/document/d/1ovw0u78Xsu0K4dEqng84GQZ7kN2YGNR_Iq4hRRRRECY/edit
Final doc for review at: go/chromeos-cups-metrics.
I'm taking this over for M60.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1b56803c0e2a1ff75797486f44712e951ee4f1a2 commit 1b56803c0e2a1ff75797486f44712e951ee4f1a2 Author: Sean Kau <skau@chromium.org> Date: Wed Aug 02 02:17:12 2017 Record the printer removal PrinterEvent. This CL implements the infrastructure for logging PrinterEventProtos. Only removals are logged right now. Successful setup and setup abandonment will be added in follow up CLs. Bug: 647283 Change-Id: I9b3dbd37ee0db486d1c55686f729f65009d03cb8 Reviewed-on: https://chromium-review.googlesource.com/590584 Commit-Queue: Sean Kau <skau@chromium.org> Reviewed-by: Steven Bennetts <stevenjb@chromium.org> Reviewed-by: Steven Holte <holte@chromium.org> Reviewed-by: Xiaoqian Dai <xdai@chromium.org> Cr-Commit-Position: refs/heads/master@{#491222} [modify] https://crrev.com/1b56803c0e2a1ff75797486f44712e951ee4f1a2/chrome/browser/chromeos/BUILD.gn [add] https://crrev.com/1b56803c0e2a1ff75797486f44712e951ee4f1a2/chrome/browser/chromeos/printing/printer_event_tracker.cc [add] https://crrev.com/1b56803c0e2a1ff75797486f44712e951ee4f1a2/chrome/browser/chromeos/printing/printer_event_tracker.h [add] https://crrev.com/1b56803c0e2a1ff75797486f44712e951ee4f1a2/chrome/browser/chromeos/printing/printer_event_tracker_factory.cc [add] https://crrev.com/1b56803c0e2a1ff75797486f44712e951ee4f1a2/chrome/browser/chromeos/printing/printer_event_tracker_factory.h [add] https://crrev.com/1b56803c0e2a1ff75797486f44712e951ee4f1a2/chrome/browser/chromeos/printing/printer_event_tracker_unittest.cc [add] https://crrev.com/1b56803c0e2a1ff75797486f44712e951ee4f1a2/chrome/browser/chromeos/printing/printer_metrics_provider.cc [add] https://crrev.com/1b56803c0e2a1ff75797486f44712e951ee4f1a2/chrome/browser/chromeos/printing/printer_metrics_provider.h [modify] https://crrev.com/1b56803c0e2a1ff75797486f44712e951ee4f1a2/chrome/browser/metrics/chrome_metrics_service_client.cc [modify] https://crrev.com/1b56803c0e2a1ff75797486f44712e951ee4f1a2/chrome/browser/ui/webui/settings/chromeos/cups_printers_handler.cc
One last CL needed, logging abandoned set ups.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d54f3fa15646a377b15ac046d4e860b872ab5e33 commit d54f3fa15646a377b15ac046d4e860b872ab5e33 Author: Sean Kau <skau@chromium.org> Date: Thu Aug 17 18:54:16 2017 Default PrinterEventTracker logging to false. Bug: 647283 Change-Id: I09665f40ebfd6c7cec747a9ad8daa8cccaf0c5ce Reviewed-on: https://chromium-review.googlesource.com/619327 Reviewed-by: Lei Zhang <thestig@chromium.org> Commit-Queue: Sean Kau <skau@chromium.org> Cr-Commit-Position: refs/heads/master@{#495260} [modify] https://crrev.com/d54f3fa15646a377b15ac046d4e860b872ab5e33/chrome/browser/chromeos/printing/printer_event_tracker.h [modify] https://crrev.com/d54f3fa15646a377b15ac046d4e860b872ab5e33/chrome/browser/chromeos/printing/printer_event_tracker_unittest.cc
Closing bug for merge. Abandonment will be tracked in this follow up. https://bugs.chromium.org/p/chromium/issues/detail?id=756576
Approving merge to M61 Chrome OS.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b3f2ea848d84ff941910fae2c1b05e4ef51f98d0 commit b3f2ea848d84ff941910fae2c1b05e4ef51f98d0 Author: Sean Kau <skau@chromium.org> Date: Thu Aug 17 20:48:14 2017 Record the printer removal PrinterEvent. This CL implements the infrastructure for logging PrinterEventProtos. Only removals are logged right now. Successful setup and setup abandonment will be added in follow up CLs. TBR=skau@chromium.org (cherry picked from commit 1b56803c0e2a1ff75797486f44712e951ee4f1a2) Bug: 647283 Change-Id: I9b3dbd37ee0db486d1c55686f729f65009d03cb8 Reviewed-on: https://chromium-review.googlesource.com/590584 Commit-Queue: Sean Kau <skau@chromium.org> Reviewed-by: Steven Bennetts <stevenjb@chromium.org> Reviewed-by: Steven Holte <holte@chromium.org> Reviewed-by: Xiaoqian Dai <xdai@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#491222} Reviewed-on: https://chromium-review.googlesource.com/619614 Reviewed-by: Sean Kau <skau@chromium.org> Cr-Commit-Position: refs/branch-heads/3163@{#644} Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528} [modify] https://crrev.com/b3f2ea848d84ff941910fae2c1b05e4ef51f98d0/chrome/browser/chromeos/BUILD.gn [add] https://crrev.com/b3f2ea848d84ff941910fae2c1b05e4ef51f98d0/chrome/browser/chromeos/printing/printer_event_tracker.cc [add] https://crrev.com/b3f2ea848d84ff941910fae2c1b05e4ef51f98d0/chrome/browser/chromeos/printing/printer_event_tracker.h [add] https://crrev.com/b3f2ea848d84ff941910fae2c1b05e4ef51f98d0/chrome/browser/chromeos/printing/printer_event_tracker_factory.cc [add] https://crrev.com/b3f2ea848d84ff941910fae2c1b05e4ef51f98d0/chrome/browser/chromeos/printing/printer_event_tracker_factory.h [add] https://crrev.com/b3f2ea848d84ff941910fae2c1b05e4ef51f98d0/chrome/browser/chromeos/printing/printer_event_tracker_unittest.cc [add] https://crrev.com/b3f2ea848d84ff941910fae2c1b05e4ef51f98d0/chrome/browser/chromeos/printing/printer_metrics_provider.cc [add] https://crrev.com/b3f2ea848d84ff941910fae2c1b05e4ef51f98d0/chrome/browser/chromeos/printing/printer_metrics_provider.h [modify] https://crrev.com/b3f2ea848d84ff941910fae2c1b05e4ef51f98d0/chrome/browser/metrics/chrome_metrics_service_client.cc [modify] https://crrev.com/b3f2ea848d84ff941910fae2c1b05e4ef51f98d0/chrome/browser/ui/webui/settings/chromeos/cups_printers_handler.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/73c4cc254b24cfab32bf76c8ad172d37930159a9 commit 73c4cc254b24cfab32bf76c8ad172d37930159a9 Author: Sean Kau <skau@chromium.org> Date: Thu Aug 17 21:43:40 2017 Fix merge for branch 3183. ProvideGeneralMetrics was renamed to ProvideCurrentSessionData. Bug: 647283 Change-Id: I35a9a26200141ab067d12b07f28b8b4e5d31134f Reviewed-on: https://chromium-review.googlesource.com/619591 Reviewed-by: Vladislav Kaznacheev <kaznacheev@chromium.org> Cr-Commit-Position: refs/branch-heads/3163@{#654} Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528} [modify] https://crrev.com/73c4cc254b24cfab32bf76c8ad172d37930159a9/chrome/browser/chromeos/printing/printer_metrics_provider.cc [modify] https://crrev.com/73c4cc254b24cfab32bf76c8ad172d37930159a9/chrome/browser/chromeos/printing/printer_metrics_provider.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ddb8e94611ec02f32bc4106d1ce54dc36eddd64a commit ddb8e94611ec02f32bc4106d1ce54dc36eddd64a Author: Sean Kau <skau@chromium.org> Date: Thu Aug 17 22:45:20 2017 Default PrinterEventTracker logging to false. TBR=skau@chromium.org (cherry picked from commit d54f3fa15646a377b15ac046d4e860b872ab5e33) Bug: 647283 Change-Id: I09665f40ebfd6c7cec747a9ad8daa8cccaf0c5ce Reviewed-on: https://chromium-review.googlesource.com/619327 Reviewed-by: Lei Zhang <thestig@chromium.org> Commit-Queue: Sean Kau <skau@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#495260} Reviewed-on: https://chromium-review.googlesource.com/619848 Reviewed-by: Sean Kau <skau@chromium.org> Cr-Commit-Position: refs/branch-heads/3163@{#662} Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528} [modify] https://crrev.com/ddb8e94611ec02f32bc4106d1ce54dc36eddd64a/chrome/browser/chromeos/printing/printer_event_tracker.h [modify] https://crrev.com/ddb8e94611ec02f32bc4106d1ce54dc36eddd64a/chrome/browser/chromeos/printing/printer_event_tracker_unittest.cc
Comment 1 by skau@chromium.org
, Sep 15 2016