New issue
Advanced search Search tips

Issue 647279 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug



Sign in to add a comment

OmniboxEditTests produce many mock warnings

Reported by dyaros...@yandex-team.ru, Sep 15 2016

Issue description



What steps will reproduce the problem?
(1) build components_unittests on the master branch
(2) run them with --gtest_filter=*OmniboxEdit*

What is the expected result?

No warnings from mock

What happens instead?

GMOCK WARNING:
Uninteresting mock function call - returning default value.
    Function call: GetBookmarkModel()
          Returns: NULL
NOTE: You can safely ignore the above warning unless this call should not happen.  Do not suppress it by blindly adding an EXPECT_CALL() if you don't mean to enforce the call.  See http://code.google.com/p/googlemock/wiki/CookBook#Knowing_When_to_Expect for details.

GMOCK WARNING:
Uninteresting mock function call - returning default value.
    Function call: GetInMemoryURLIndex()
          Returns: NULL
NOTE: You can safely ignore the above warning unless this call should not happen.  Do not suppress it by blindly adding an EXPECT_CALL() if you don't mean to enforce the call.  See http://code.google.com/p/googlemock/wiki/CookBook#Knowing_When_to_Expect for details.

GMOCK WARNING:
Uninteresting mock function call - returning default value.
    Function call: GetBookmarkModel()
          Returns: NULL
NOTE: You can safely ignore the above warning unless this call should not happen.  Do not suppress it by blindly adding an EXPECT_CALL() if you don't mean to enforce the call.  See http://code.google.com/p/googlemock/wiki/CookBook#Knowing_When_to_Expect for details.

GMOCK WARNING:
Uninteresting mock function call - returning default value.
    Function call: GetInMemoryURLIndex()
          Returns: NULL
NOTE: You can safely ignore the above warning unless this call should not happen.  Do not suppress it by blindly adding an EXPECT_CALL() if you don't mean to enforce the call.  See http://code.google.com/p/googlemock/wiki/CookBook#Knowing_When_to_Expect for details.

GMOCK WARNING:
Uninteresting mock function call - returning default value.
    Function call: GetEmbedderRepresentationOfAboutScheme()
          Returns: ""
NOTE: You can safely ignore the above warning unless this call should not happen.  Do not suppress it by blindly adding an EXPECT_CALL() if you don't mean to enforce the call.  See http://code.google.com/p/googlemock/wiki/CookBook#Knowing_When_to_Expect for details.

GMOCK WARNING:
Uninteresting mock function call - returning default value.
    Function call: GetEmbedderRepresentationOfAboutScheme()
          Returns: ""
NOTE: You can safely ignore the above warning unless this call should not happen.  Do not suppress it by blindly adding an EXPECT_CALL() if you don't mean to enforce the call.  See http://code.google.com/p/googlemock/wiki/CookBook#Knowing_When_to_Expect for details.

GMOCK WARNING:
Uninteresting mock function call - returning default value.
    Function call: GetHistoryService()
          Returns: NULL
NOTE: You can safely ignore the above warning unless this call should not happen.  Do not suppress it by blindly adding an EXPECT_CALL() if you don't mean to enforce the call.  See http://code.google.com/p/googlemock/wiki/CookBook#Knowing_When_to_Expect for details.

GMOCK WARNING:
Uninteresting mock function call - returning default value.
    Function call: GetInMemoryDatabase()
          Returns: NULL
NOTE: You can safely ignore the above warning unless this call should not happen.  Do not suppress it by blindly adding an EXPECT_CALL() if you don't mean to enforce the call.  See http://code.google.com/p/googlemock/wiki/CookBook#Knowing_When_to_Expect for details.

GMOCK WARNING:
Uninteresting mock function call - returning default value.
    Function call: IsOffTheRecord()
          Returns: false
NOTE: You can safely ignore the above warning unless this call should not happen.  Do not suppress it by blindly adding an EXPECT_CALL() if you don't mean to enforce the call.  See http://code.google.com/p/googlemock/wiki/CookBook#Knowing_When_to_Expect for details.

GMOCK WARNING:
Uninteresting mock function call - returning default value.
    Function call: SearchSuggestEnabled()
          Returns: false
NOTE: You can safely ignore the above warning unless this call should not happen.  Do not suppress it by blindly adding an EXPECT_CALL() if you don't mean to enforce the call.  See http://code.google.com/p/googlemock/wiki/CookBook#Knowing_When_to_Expect for details.

Something should be probably done.

 
Components: UI>Browser>Omnibox
Labels: TE-NeedsTriageHelp
Added TE-NeedsTriageHelp as it can't be triaged from TE end.
Owner: tommycli@chromium.org
Status: Started (was: Unconfirmed)
Labels: Hotlist-CodeHealth
Labels: -TE-NeedsTriageHelp OS-All
Status: Fixed (was: Started)
Bot is slow but patch has landed already: https://codereview.chromium.org/2950473003/

Sign in to add a comment