New issue
Advanced search Search tips

Issue 647273 link

Starred by 2 users
Status: Fixed
Owner:
iclell...@chromium.org
Closed: Oct 2016
Cc:
feature-...@grotations.appspotmail.com
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Chrome , Mac
Pri: 3
Type: Bug

Blocking:
issue 637148



Sign in to add a comment

Origin Trials test interface should not be attached directly to window.internals

Project Member Reported by iclell...@chromium.org, Sep 15 2016 
window.internals (and self.internals for workers) is a special object, constructed in a method which is not encountered outside of test code. Its peculiarities make it difficult to properly test the origin trial JS binding mechanisms.

We should move these test interfaces to a new object, which can be returned from a method on window.internals. (Consistent with DictionaryTest, etc).

(This is blocking  crbug.com/637148 , as it is not possible to use the current tests when we construct origin trial attributes on first access).
Project Member

Comment 1 by bugdroid1@chromium.org, Sep 16 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2076a9846ca82c6f6566d5fb7526729c853157ee

commit 2076a9846ca82c6f6566d5fb7526729c853157ee
Author: iclelland <iclelland@chromium.org>
Date: Fri Sep 16 18:33:42 2016

Add Origin Trials Test interface, rather than attaching trials directly to internals.

This makes the test interface almost exactly like any other origin trial, and
means that we don't have to do any special handling at internals construction
time to support it. Because it lives on window.internals.originTrialTest() now,
I renamed the various test methods and attributes to be more descriptive of what
they are actually testing, rather than prefixing them with 'frobulate' to avoid
polluting the internals namespace.

BUG= 647273 

Review-Url: https://codereview.chromium.org/2340323002
Cr-Commit-Position: refs/heads/master@{#419225}

[modify] https://crrev.com/2076a9846ca82c6f6566d5fb7526729c853157ee/third_party/WebKit/LayoutTests/http/tests/origin_trials/resources/disabled-worker.js
[modify] https://crrev.com/2076a9846ca82c6f6566d5fb7526729c853157ee/third_party/WebKit/LayoutTests/http/tests/origin_trials/resources/enabled-worker.js
[modify] https://crrev.com/2076a9846ca82c6f6566d5fb7526729c853157ee/third_party/WebKit/LayoutTests/http/tests/origin_trials/resources/origin_trials.js
[modify] https://crrev.com/2076a9846ca82c6f6566d5fb7526729c853157ee/third_party/WebKit/Source/core/BUILD.gn
[modify] https://crrev.com/2076a9846ca82c6f6566d5fb7526729c853157ee/third_party/WebKit/Source/core/core_idl_files.gni
[delete] https://crrev.com/b95699ec44649867daef03c0b65f9a46226a3a38/third_party/WebKit/Source/core/origin_trials/testing/InternalsFrobulate.cpp
[delete] https://crrev.com/b95699ec44649867daef03c0b65f9a46226a3a38/third_party/WebKit/Source/core/origin_trials/testing/InternalsFrobulate.h
[delete] https://crrev.com/b95699ec44649867daef03c0b65f9a46226a3a38/third_party/WebKit/Source/core/origin_trials/testing/InternalsFrobulate.idl
[delete] https://crrev.com/b95699ec44649867daef03c0b65f9a46226a3a38/third_party/WebKit/Source/core/origin_trials/testing/InternalsFrobulateInterfaceBindings.h
[delete] https://crrev.com/b95699ec44649867daef03c0b65f9a46226a3a38/third_party/WebKit/Source/core/origin_trials/testing/InternalsFrobulateInterfaceBindings.idl
[delete] https://crrev.com/b95699ec44649867daef03c0b65f9a46226a3a38/third_party/WebKit/Source/core/origin_trials/testing/WorkerInternalsFrobulate.h
[delete] https://crrev.com/b95699ec44649867daef03c0b65f9a46226a3a38/third_party/WebKit/Source/core/origin_trials/testing/WorkerInternalsFrobulate.idl
[modify] https://crrev.com/2076a9846ca82c6f6566d5fb7526729c853157ee/third_party/WebKit/Source/core/testing/Internals.cpp
[modify] https://crrev.com/2076a9846ca82c6f6566d5fb7526729c853157ee/third_party/WebKit/Source/core/testing/Internals.h
[modify] https://crrev.com/2076a9846ca82c6f6566d5fb7526729c853157ee/third_party/WebKit/Source/core/testing/Internals.idl
[add] https://crrev.com/2076a9846ca82c6f6566d5fb7526729c853157ee/third_party/WebKit/Source/core/testing/OriginTrialsTest.cpp
[add] https://crrev.com/2076a9846ca82c6f6566d5fb7526729c853157ee/third_party/WebKit/Source/core/testing/OriginTrialsTest.h
[add] https://crrev.com/2076a9846ca82c6f6566d5fb7526729c853157ee/third_party/WebKit/Source/core/testing/OriginTrialsTest.idl
[add] https://crrev.com/2076a9846ca82c6f6566d5fb7526729c853157ee/third_party/WebKit/Source/core/testing/OriginTrialsTestPartial.h
[add] https://crrev.com/2076a9846ca82c6f6566d5fb7526729c853157ee/third_party/WebKit/Source/core/testing/OriginTrialsTestPartial.idl
[modify] https://crrev.com/2076a9846ca82c6f6566d5fb7526729c853157ee/third_party/WebKit/Source/core/testing/WorkerInternals.cpp
[modify] https://crrev.com/2076a9846ca82c6f6566d5fb7526729c853157ee/third_party/WebKit/Source/core/testing/WorkerInternals.h
[modify] https://crrev.com/2076a9846ca82c6f6566d5fb7526729c853157ee/third_party/WebKit/Source/core/testing/WorkerInternals.idl
[modify] https://crrev.com/2076a9846ca82c6f6566d5fb7526729c853157ee/third_party/WebKit/Source/core/testing/v8/WebCoreTestSupport.cpp

Comment 2 by iclell...@chromium.org, Oct 14 2016

Status: Fixed (was: Started)
►

Sign in to add a comment