The close() method is currently defined on BaseAudioContext. This is strange because close() is not allowed on an OfflineAudioContext. It should be moved from BaseAudioContext to AudioContext. Moving this is a minor user-visible change, but no change in functionality. See issue: https://github.com/WebAudio/web-audio-api/issues/948 Resolved in: https://github.com/WebAudio/web-audio-api/pull/974
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/afc2a8c12033ede8c9cedb501299e47270f75cb8 commit afc2a8c12033ede8c9cedb501299e47270f75cb8 Author: rtoy <rtoy@chromium.org> Date: Fri Sep 16 19:19:35 2016 Move close() from BaseAudioContext to AudioContext OfflineAudioContext cannot be closed so it makes more sense to have close() be defined on AudioContext instead of BaseAudioContext. This is a very minor tweak to the API, so no Blink intent submitted. Spec issue: https://github.com/WebAudio/web-audio-api/issues/948 Resolved: https://github.com/WebAudio/web-audio-api/issues/974 Chrome feature: https://www.chromestatus.com/feature/5683205155848192 BUG= 647261 TEST=audiocontext-close.html Review-Url: https://codereview.chromium.org/2345693002 Cr-Commit-Position: refs/heads/master@{#419244} [modify] https://crrev.com/afc2a8c12033ede8c9cedb501299e47270f75cb8/third_party/WebKit/LayoutTests/virtual/stable/webexposed/global-interface-listing-expected.txt [modify] https://crrev.com/afc2a8c12033ede8c9cedb501299e47270f75cb8/third_party/WebKit/LayoutTests/webaudio/audiocontext-close-expected.txt [modify] https://crrev.com/afc2a8c12033ede8c9cedb501299e47270f75cb8/third_party/WebKit/LayoutTests/webaudio/audiocontext-close.html [modify] https://crrev.com/afc2a8c12033ede8c9cedb501299e47270f75cb8/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt [modify] https://crrev.com/afc2a8c12033ede8c9cedb501299e47270f75cb8/third_party/WebKit/Source/modules/webaudio/AudioContext.h [modify] https://crrev.com/afc2a8c12033ede8c9cedb501299e47270f75cb8/third_party/WebKit/Source/modules/webaudio/AudioContext.idl [modify] https://crrev.com/afc2a8c12033ede8c9cedb501299e47270f75cb8/third_party/WebKit/Source/modules/webaudio/BaseAudioContext.h [modify] https://crrev.com/afc2a8c12033ede8c9cedb501299e47270f75cb8/third_party/WebKit/Source/modules/webaudio/BaseAudioContext.idl [modify] https://crrev.com/afc2a8c12033ede8c9cedb501299e47270f75cb8/third_party/WebKit/Source/modules/webaudio/OfflineAudioContext.cpp [modify] https://crrev.com/afc2a8c12033ede8c9cedb501299e47270f75cb8/third_party/WebKit/Source/modules/webaudio/OfflineAudioContext.h
Comment 1 by rtoy@chromium.org
, Sep 15 2016Status: Started (was: Available)