New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 647151 link

Starred by 90 users

no-cache stylesheets are not lost between two frames

Reported by dkwak...@gmail.com, Sep 15 2016

Issue description

Chrome Version       :

Google Chrome	53.0.2785.101 (Officiƫle build) m (32-bits)
Revisie	d68319683072a27031ebac6ac151e59f4190cab7-refs/branch-heads/2785@{#838}
Besturingssysteem	Windows 
Blink	537.36 (@d68319683072a27031ebac6ac151e59f4190cab7)
JavaScript	V8 5.3.332.43
Flash	23.0.0.162
User-agent	Mozilla/5.0 (Windows NT 6.1; WOW64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/53.0.2785.101 Safari/537.36
Opdrachtregel	"C:\Program Files (x86)\Google\Chrome\Application\chrome.exe" --flag-switches-begin --flag-switches-end
Uitvoerbaar pad	C:\Program Files (x86)\Google\Chrome\Application\chrome.exe
Profielpad	C:\Users\GTM\AppData\Local\Google\Chrome\User Data\Default
Varianten	6a89113b-f23d1dea
b3888d8d-afba0f91
7c1bc906-f55a7974
ba3f87da-ca7d8d80
f049a919-3f4a17df
f15c1c09-ca7d8d80
93731dca-3f4a17df
9e5c75f1-c16ec2e6
f5dd6118-3d47f4f4
f79cb77b-3d47f4f4
b7786474-d93a0620
868bda90-ca7d8d80
4ea303a6-ecbb250e
7aa46da5-8279be7
9736de91-ca7d8d80
dbffab5d-ca7d8d80
867c4c68-ca7d8d80
6844d8aa-669a04e0
f47ae82a-86f22ee5
3ac60855-486e2a9c
f296190c-22cd16e0
4442aae2-a90023b1
ed1d377-e1cc0f14
75f0f0a0-d7f6b13c
e2b18481-bca011b3
e7e71889-4ad60575
Compiler	MSVC 2015

URLs (if applicable) :
Other browsers tested:
  Add OK or FAIL, along with the version, after other browsers where you
have tested this issue:
     Safari: Not tested
    Firefox: OK
         IE: OK

What steps will reproduce the problem?
(1) Deploy attached chromebug.war (which serves the testing pages with Cache-Control: no-cache)
(2) Open http://localhost/chromebug/testing.htm
(3) Click on 'Load Xform1': First frame has 'Load Xform' in red
(4) Click on 'Load Xform2': Second frame has 'Load Xform' in red
(5) Click on 'Load Xform1': First frame has 'Load Xform' in red *but* second frame has become black (stylesheet test.css is no longer applied).

What is the expected result?
- Styles of both frames remain red.

What happens instead?
- Style of the not selected frame becomes black.

Attached screenshot, war to reproduce and eclipse project.

This is a *regression* and seems to be introduced from '53.0.2785.101 m' release onwards.

 
chromebug.png
122 KB View Download

Comment 1 by dkwak...@gmail.com, Sep 15 2016

chromebug.war
3.3 KB Download
chromebug.zip
190 KB Download
We are also facing the issue. CSS styles are getting removed for the previous frames when loading a new frame.

Attaching the test files which needs to be placed in a webserver with Web content cache as "Cache-Control: no-cache"
Chrome Issue.mp4
1.9 MB View Download
Chrome issue.zip
1.1 KB Download

Comment 3 by dkwak...@gmail.com, Sep 15 2016

Title of bug is wrong, it must be without not: no-cache stylesheets are lost between two frames.

When using a max-age instead of no-cache it is working.

Comment 4 by dkwak...@gmail.com, Sep 15 2016

Another observation: When content is compressed it is working fine. So adding compression="force" for e.g. tomcat seems a workaround:

    <Connector port="80" protocol="HTTP/1.1"
               connectionTimeout="20000"
               redirectPort="8443" compression="force"/>

Comment 5 by dkwak...@gmail.com, Sep 16 2016

Workaround with compression does not work in all situations, because proxy servers can offload the compression.

Also when max-age is set to e.g. 30, same issue occurs after about 120 seconds!

Can someone tell how I can increase priority of this issue? 

Comment 6 by dkwak...@gmail.com, Sep 16 2016

Created a filter which removes server side the "If-Modified-Since" and "If-None-Match" header, and apply this to css files so no 304 will be returned but a 200. Put it in the WEB-INF/lib directory of your application and restart web/application server as workaround. 
chromeworkaround.jar
3.0 KB Download

Comment 7 by dkwak...@gmail.com, Sep 16 2016

The best workaround I found is to remove server side the following headers when css files are requested:

If-Modified-Since
If-None-Match

Added solution for servlet containers above. For apache similair way can be used, see: http://stackoverflow.com/a/20867608/227061. Probably for IIS also something like that can be done.

Comment 8 by dkwak...@gmail.com, Sep 16 2016

Previous workaround does not work when Proxy servers use "ETag" or "Last-Modified" to serve the page with a 304 from their own cache. Attached chromeworkaroundproxy jar solves this by removing these headers.
chromeworkaroundproxy.jar
4.2 KB Download

Comment 9 by dkwak...@gmail.com, Sep 16 2016

I think this bug is pretty important, because it surfaces after some time with max-age and depends on state of the cache and only for css files (as far as I know now). So users get strange pages and it is pretty difficult to find out where it comes from. 

Can someone of the chromium project please look into this?
Components: Internals>Network>Cache Blink>Loader

Comment 11 Deleted

Hi @chrome team: This is effecting our daily activities. Please look into this ASAP. 
Cc: hirosh...@chromium.org kouhei@chromium.org
Labels: -Pri-3 Pri-1
Status: Untriaged (was: Unconfirmed)
I can reproduce a variant of this on codereview.chromium.org which only uses max-age, but we seem to be requesting it with max-age=0.

Flipping between two tabs causes the styles.css to be lost.


Bumping priority and ccing current loading triager.

This definitely seems like a MemoryCache issue.
Unfortunately the repro stopped working for me. I think the request headers adding max-age=0 were the cause of this, but I'm not sure where that was coming from.

Comment 16 by dkwak...@gmail.com, Sep 19 2016

@csharrison: Did the attached reproduction scenario not work for you? Also take care to have no compression enabled (because then it will not occur).
I haven't had time to run the attached repro. If I have some time today I'll try to get to it.
 Issue 648057  has been merged into this issue.
 Issue 648023  has been merged into this issue.
Confirmed repro on 53.0.2785.116 (Official Build) (64-bit) Linux

attached: golang http server which serves local files w/ "Cache-Control: no-cache"
serve.go
365 bytes View Download
Still repros on ToT

Chromium	55.0.2866.0 (Developer Build) (64-bit)
Revision	cfc30f28e0bb2b16793188e670f109d81c8f153d-refs/heads/master@{#419610}
OS	Linux 

Owner: kouhei@chromium.org
Status: Started (was: Untriaged)
The root cause is that {CSS,XSL}StyleSheetResource::notifyFinished doesn't call markClientFinished on their clients.
Fix working locally. I'll upload the fix after writing layout test.
Probably regressed here:
https://codereview.chromium.org/2308393002/patch/1/10006

Thx for finding root cause.
Can this fix be make available in GA build i.e. Chrome 53??
Issue 646549 has been merged into this issue.
Same problem here while using `expires -1` on nginx, however, if there are multiple CSS, only the last one seems to be problematic. 

While the problem is fixed and released, what would be the recommended workaround on the server side? 

- Set a large cache value? It seems to only delay the bug.
- Ignore some browser requests headers?
- Adding a random URL parameter (http://foo.bar/file.css?c=random)?

 
Project Member

Comment 28 by bugdroid1@chromium.org, Sep 21 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3598c8bc9c56409f7c239c377fe6e42786d6aaa0

commit 3598c8bc9c56409f7c239c377fe6e42786d6aaa0
Author: kouhei <kouhei@chromium.org>
Date: Wed Sep 21 03:54:33 2016

{CSS,XSL}StyleSheetResource should mark their clients as finished on checkNotify

Before this CL, {CSS,XSL}StyleSheetResource::checkNotify didn't trigger markClientFinished as Resource::checkNotify did.
This CL aligns {CSS,XSL}StyleSheetResource::checkNotify to trigger it properly.

BUG= 647151 

Review-Url: https://codereview.chromium.org/2353903002
Cr-Commit-Position: refs/heads/master@{#419969}

[add] https://crrev.com/3598c8bc9c56409f7c239c377fe6e42786d6aaa0/third_party/WebKit/LayoutTests/http/tests/loading/css-no-cache-revalidation-expected.txt
[add] https://crrev.com/3598c8bc9c56409f7c239c377fe6e42786d6aaa0/third_party/WebKit/LayoutTests/http/tests/loading/css-no-cache-revalidation.html
[add] https://crrev.com/3598c8bc9c56409f7c239c377fe6e42786d6aaa0/third_party/WebKit/LayoutTests/http/tests/loading/resources/no-cache-css.php
[add] https://crrev.com/3598c8bc9c56409f7c239c377fe6e42786d6aaa0/third_party/WebKit/LayoutTests/http/tests/loading/resources/no-cache-xslt.php
[add] https://crrev.com/3598c8bc9c56409f7c239c377fe6e42786d6aaa0/third_party/WebKit/LayoutTests/http/tests/loading/resources/reference-css-no-cache.xhtml
[modify] https://crrev.com/3598c8bc9c56409f7c239c377fe6e42786d6aaa0/third_party/WebKit/Source/core/fetch/CSSStyleSheetResource.cpp
[modify] https://crrev.com/3598c8bc9c56409f7c239c377fe6e42786d6aaa0/third_party/WebKit/Source/core/fetch/XSLStyleSheetResource.cpp

Hi @Chrome team,

When can we expect this fix as part of Chrome 53 GA??
 Issue 645119  has been merged into this issue.
#29 I'll ask for beta -> stable merge once the metric look sane after Canary release.
This fix worked for us. We're hoping it can get merged into 53 asap.
Does this bug also refer to: CSS styles are cleared for current page when opening link in new tab or opening a new window

https://bugs.chromium.org/p/chromium/issues/detail?id=648237

Comment 34 by creis@chromium.org, Sep 21 2016

Cc: gov...@chromium.org
Labels: -Type-Bug M-54 M-53 Type-Bug-Regression
Adding govind@ for FYI about M53 regression.
Cc: ananthak@google.com
I posted a me-too comment in 648237. This fix worked for us as well.  Ditto for getting this into 53! 
Cc: thakis@chromium.org cbiesin...@chromium.org
 Issue 648712  has been merged into this issue.
 Issue 648237  has been merged into this issue.
Cc: ajha@chromium.org
 Issue 646395  has been merged into this issue.
Cc: bustamante@chromium.org ligim...@chromium.org
Re #31, how is this change looking in Canary?
Is the changes(fix) already present in Canary build? I ma validating in Canary(Version 55.0.2867.0). Still the issue is present.

Comment 42 by phistuck@gmail.com, Sep 22 2016

#41 - No, 2868 and later.
We have validated in Canary(Version 55.0.2868.0) and fix is working fine. Waiting for the stable release 53.

When can we except Chrome 53 with this fix?
I have also validated fix is working for our app in Canary 2868.
Please can I request this fix be deployed to Chrome 53?

The issue is causing terrible grief for users of our system.
Labels: Merge-Request-53

Comment 47 by dimu@chromium.org, Sep 22 2016

Labels: -Merge-Request-53 Merge-Review-53 Hotlist-Merge-Review
[Automated comment] Request affecting a post-stable build (M53), manual review required.
Cc: keta...@chromium.org amineer@chromium.org
Labels: OS-All
Per kouhei@ reply on internal mail thread, this bug affects to all os.
Labels: ReleaseBlock-Stable
This breaks all kinds of web pages.
Labels: -Pri-1 Pri-0
This breaks many pages across the Web. Increasing priority.
Cc: pbomm...@chromium.org

Comment 52 Deleted

Labels: -Merge-Review-53 Merge-Approved-53
Approving merge to M53 branch 2785 based on comment #43 and #44. Please merge ASAP. 

Also please request a merge to M54.

Comment 55 by s...@google.com, Sep 23 2016

Issue 647093 has been merged into this issue.
Labels: Merge-Request-54
Merge pushed to M53 2785.
Would you approve merge to M54 too?
bustamante@ for M54 approval.

Comment 58 by dimu@chromium.org, Sep 23 2016

Labels: -Merge-Request-54 Merge-Approved-54 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M54 (branch: 2840)
Project Member

Comment 59 by bugdroid1@chromium.org, Sep 23 2016

Labels: -merge-approved-53 merge-merged-2785
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/58cdb2e94ed67c3f5655d630fcacf1a26bcd203f

commit 58cdb2e94ed67c3f5655d630fcacf1a26bcd203f
Author: Kouhei Ueno <kouhei@chromium.org>
Date: Fri Sep 23 00:15:53 2016

{CSS,XSL}StyleSheetResource should mark their clients as finished on checkNotify

Before this CL, {CSS,XSL}StyleSheetResource::checkNotify didn't trigger markClientFinished as Resource::checkNotify did.
This CL aligns {CSS,XSL}StyleSheetResource::checkNotify to trigger it properly.

BUG= 647151 

Review-Url: https://codereview.chromium.org/2353903002
Cr-Commit-Position: refs/heads/master@{#419969}
(cherry picked from commit 3598c8bc9c56409f7c239c377fe6e42786d6aaa0)

Review URL: https://codereview.chromium.org/2362103002 .

Cr-Commit-Position: refs/branch-heads/2785@{#915}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}

[add] https://crrev.com/58cdb2e94ed67c3f5655d630fcacf1a26bcd203f/third_party/WebKit/LayoutTests/http/tests/loading/css-no-cache-revalidation-expected.txt
[add] https://crrev.com/58cdb2e94ed67c3f5655d630fcacf1a26bcd203f/third_party/WebKit/LayoutTests/http/tests/loading/css-no-cache-revalidation.html
[add] https://crrev.com/58cdb2e94ed67c3f5655d630fcacf1a26bcd203f/third_party/WebKit/LayoutTests/http/tests/loading/resources/no-cache-css.php
[add] https://crrev.com/58cdb2e94ed67c3f5655d630fcacf1a26bcd203f/third_party/WebKit/LayoutTests/http/tests/loading/resources/no-cache-xslt.php
[add] https://crrev.com/58cdb2e94ed67c3f5655d630fcacf1a26bcd203f/third_party/WebKit/LayoutTests/http/tests/loading/resources/reference-css-no-cache.xhtml
[modify] https://crrev.com/58cdb2e94ed67c3f5655d630fcacf1a26bcd203f/third_party/WebKit/Source/core/fetch/CSSStyleSheetResource.cpp
[modify] https://crrev.com/58cdb2e94ed67c3f5655d630fcacf1a26bcd203f/third_party/WebKit/Source/core/fetch/XSLStyleSheetResource.cpp

Status: Fixed (was: Started)
Pushed to M54 (branch: 2840)

Project Member

Comment 61 by bugdroid1@chromium.org, Sep 23 2016

Labels: -merge-approved-54 merge-merged-2840
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/54c7dbb6ffaf423ca61bf7382db7a506b4b759df

commit 54c7dbb6ffaf423ca61bf7382db7a506b4b759df
Author: Kouhei Ueno <kouhei@chromium.org>
Date: Fri Sep 23 00:24:54 2016

{CSS,XSL}StyleSheetResource should mark their clients as finished on checkNotify

Before this CL, {CSS,XSL}StyleSheetResource::checkNotify didn't trigger markClientFinished as Resource::checkNotify did.
This CL aligns {CSS,XSL}StyleSheetResource::checkNotify to trigger it properly.

BUG= 647151 

Review-Url: https://codereview.chromium.org/2353903002
Cr-Commit-Position: refs/heads/master@{#419969}
(cherry picked from commit 3598c8bc9c56409f7c239c377fe6e42786d6aaa0)

Review URL: https://codereview.chromium.org/2362983002 .

Cr-Commit-Position: refs/branch-heads/2840@{#504}
Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607}

[add] https://crrev.com/54c7dbb6ffaf423ca61bf7382db7a506b4b759df/third_party/WebKit/LayoutTests/http/tests/loading/css-no-cache-revalidation-expected.txt
[add] https://crrev.com/54c7dbb6ffaf423ca61bf7382db7a506b4b759df/third_party/WebKit/LayoutTests/http/tests/loading/css-no-cache-revalidation.html
[add] https://crrev.com/54c7dbb6ffaf423ca61bf7382db7a506b4b759df/third_party/WebKit/LayoutTests/http/tests/loading/resources/no-cache-css.php
[add] https://crrev.com/54c7dbb6ffaf423ca61bf7382db7a506b4b759df/third_party/WebKit/LayoutTests/http/tests/loading/resources/no-cache-xslt.php
[add] https://crrev.com/54c7dbb6ffaf423ca61bf7382db7a506b4b759df/third_party/WebKit/LayoutTests/http/tests/loading/resources/reference-css-no-cache.xhtml
[modify] https://crrev.com/54c7dbb6ffaf423ca61bf7382db7a506b4b759df/third_party/WebKit/Source/core/fetch/CSSStyleSheetResource.cpp
[modify] https://crrev.com/54c7dbb6ffaf423ca61bf7382db7a506b4b759df/third_party/WebKit/Source/core/fetch/XSLStyleSheetResource.cpp

This affects our large cloud system greatly (thousands of users), is there some way to know when a fix will be pushed out so we can tell our customers?
We don't comment on release dates, but as you can see above we merged the fix to the m53 branch.
Hi @Chrome Team,

We are waiting for the fix and this is not still available in the Stable 53 release. Can you please help us? 
Labels: TE-Verified-M55 TE-Verified-55.0.2873.0
As all the users, I have verified the fix on latest Chrome canary on Windows 7,10, Mac 10.11.6 and Linux using Chrome Version 55.0.2873.0.


Thank you very much Prudhvi.
Verified the bug on Windows(7,10), Mac(10.11.6) and Linux(14.04Lts) on Chrome version 54.0.2840.41.

Comment 68 by suva...@gmail.com, Sep 28 2016

Any idea when the release will be available to users?. Becasue of this we are having hard time in using chrome and started using other browser which is not a good sign.
Please can we have an update on when this will be released?  It is affecting all the users in my workplace and our primary web application.
Our hope is to have a new version deployed by this time next week.  Note that this may change if we encounter issues.  We understand the impact and are working to address ASAP.

Can anyone comment if they are struggling with this issue on Android?  Or are most having problems with desktop (e.g. Windows, Mac, Linux) OSes?
I don't know why you still wish to diagnose the issue when I've tested it in Canary and it's already fixed.. But I imagine most of us are using desktop browsers that are encountering the issue. That being said...

I just tried it on Android using the same version 53 of Chrome. After trying a couple times to reproduce it I was unable to get the stylesheets to "unload"/"get lost", or whatever is happening to them.

I then tried to reproduce it in Chrome on Desktop again, using the same exact steps and successfully "unloaded" the stylesheets in underlying tabs/windows.

Windows 10, but I know it is effecting Mac users as well. I have no information about their current OSX version or Chrome version, but I'd be willing to put a lot of money on the fact it's Chrome Stable v53, the same as the rest of us, since that's when Chrome developers released the kracken on our ships to begin with.
Thanks for the update amineer.

I can confirm we are using a mix of 32-bit/64-bit Chrome 53 on Windows 7.

Comment 73 by phistuck@gmail.com, Sep 28 2016

#71 - I do not think the Android question was about diagnosis, but about user impact - if most of the software that encounters this bug is mostly desktop software, the patch might only be released to desktop and leave Android alone.

While this issue is fixed in the canary, keep in mind that it might have broken something else, which is why a stable patch is taking a lot of time (it needs a lot of testing, since a billion of people or so will be getting it and you would not want them to miss an issue like this one, right? :)).
#73 - that is certainly one way to look at it..

It took days for them to acknowledge this issue. Once acknowledged, it took them all of an hour to fix it. Should this then take 2 weeks to "test"?

No, that doesn't make much sense to me. I believe they don't want to bother with a new release just for this issue because they deem it minor (just refresh, right). So they're not only testing this one fix, but all the other features they've added between 53 and 55.

Which goes back to a comment I left on a duplicate bug, this should have been hotfixed off of a stable branch and merged into development branches after the fix was deployed (53.0.2785 > 53.0.2786). It should not have been fixed in a development branch, which is the most likely hold up (53.0.2785 > 55.0.2873).

And besides, if their testing was so rigorous, how did this even get promoted to a stable release?

Comment 75 by phistuck@gmail.com, Sep 28 2016

Of course it is not the only fix (another fix that severely affects jQuery, without refreshing, is also there, for example), but they are definitely not adding every change that was made between 53 and 55. You can see the list of changes that the next stable patch release will be getting. It is not really that long -
https://chromium.googlesource.com/chromium/src/+log/53.0.2785.147
(Disregard version increments, of course and stop at "Incrementing VERSION to 53.0.2785.116").

And yes, it can take two weeks to test. It is being tested on multiple platforms (and versions) and on many websites.

And yes, the testing tries to be as rigorous as possible, but they are still human beings and the resources are limited. And I think you can agree this is an edge case.

Anyway, the issue tracker is not the place for this discussion. Signing off. ;)
phistuck@ nailed it with both of their comments, some minor details aside.  That said, I want to make something clear - it's not acceptable for us to ship regressions like this, and we're performing a post-mortem on the situation to avoid this occurring in the future by looking at things like better automated / manual regression testing, etc.  We really apologize for the inconvenience that this has caused all of our end users.
#76 - good to hear.

As I've reported elsewhere, I confirm that the problem occurs also with Android Chrome v53 and v54 beta, not v52.

lbarbareau@, where else have you reported that?  How frequently are you seeing this on Chrome for Android?  As of right now we have plans to release an updated desktop version but not an updated Android version as I'm seeing very few reports of this on Android vs. Windows / Mac; if you have a website where you can reliably reproduce this on Android I'd love to hear it.
Verified the fix on Windows(7, 10), Mac OSX 10.11.6 and Linux(ubuntu) with Chrome version 53.0.2785.143.
@amineer Here https://bugs.chromium.org/p/chromium/issues/detail?id=645119#c8

For us the same bug also occurs with frameset/frames into our web app but if I test the supplied chromebug.war, with Android Chrome 53.0.2785.124 and 54.0.2840.34 beta, I can see the lost of colors into the iframes when loading alternately each of them.


Chrome 54 beta has been releases with the fix.  Version 54.0.2840.41

Waiting for Chrome 53

Comment 82 by dkwak...@gmail.com, Sep 29 2016

Everyone having this issue: Attached new chromeworkaroundproxy.jar which also works for xls issues (source code is included, so you can use this as example for your own apache/iis fix).
chromeworkaroundproxy.jar
4.2 KB Download
I confirm the fix into Android Chrome beta 54.0.2840.42.


I wonder if anyone experiencing these problems uses @font-face?
When we do in sites susceptible to this bug, we also see this older bug: https://bugs.chromium.org/p/chromium/issues/detail?id=582198, sadly it is set to WontFix.
This patch is now pushing out to stable channel in version 53.0.2785.143 for Desktop (Win,Mac & Linux).
Confirming that on my end, this appears to be resolved in Win10 Chrome Desktop 53.0.2785.143. Thank you for escalating this and not making us wait until next week as previously stated.

Comment 87 by jsros...@gmail.com, Sep 29 2016

Confiming issue fixed on Win7 Desktop; Tks a lot!

Comment 88 by dkwak...@gmail.com, Sep 29 2016

Thanks for fixing! @all: When you are sure all your customers are upgraded to fixed chrome version you can remove the workaround jar from your system (better for performance).

Comment 89 by dkwak...@gmail.com, Sep 29 2016

Just interested: Where can we find the post-mortum / RCA when it is done?
Cc: ericwilligers@chromium.org
 Issue 650565  has been merged into this issue.

Comment 91 by tkent@chromium.org, Sep 30 2016

Cc: rnimmagadda@chromium.org
 Issue 649619  has been merged into this issue.
Cc: krajshree@chromium.org
 Issue 651391  has been merged into this issue.

Comment 93 by j...@softeam.de, Oct 4 2016

Thx to the team for fixing this (big) bug in about 3 weeks.
Project Member

Comment 94 by bugdroid1@chromium.org, Oct 27 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/54c7dbb6ffaf423ca61bf7382db7a506b4b759df

commit 54c7dbb6ffaf423ca61bf7382db7a506b4b759df
Author: Kouhei Ueno <kouhei@chromium.org>
Date: Fri Sep 23 00:24:54 2016

{CSS,XSL}StyleSheetResource should mark their clients as finished on checkNotify

Before this CL, {CSS,XSL}StyleSheetResource::checkNotify didn't trigger markClientFinished as Resource::checkNotify did.
This CL aligns {CSS,XSL}StyleSheetResource::checkNotify to trigger it properly.

BUG= 647151 

Review-Url: https://codereview.chromium.org/2353903002
Cr-Commit-Position: refs/heads/master@{#419969}
(cherry picked from commit 3598c8bc9c56409f7c239c377fe6e42786d6aaa0)

Review URL: https://codereview.chromium.org/2362983002 .

Cr-Commit-Position: refs/branch-heads/2840@{#504}
Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607}

[add] https://crrev.com/54c7dbb6ffaf423ca61bf7382db7a506b4b759df/third_party/WebKit/LayoutTests/http/tests/loading/css-no-cache-revalidation-expected.txt
[add] https://crrev.com/54c7dbb6ffaf423ca61bf7382db7a506b4b759df/third_party/WebKit/LayoutTests/http/tests/loading/css-no-cache-revalidation.html
[add] https://crrev.com/54c7dbb6ffaf423ca61bf7382db7a506b4b759df/third_party/WebKit/LayoutTests/http/tests/loading/resources/no-cache-css.php
[add] https://crrev.com/54c7dbb6ffaf423ca61bf7382db7a506b4b759df/third_party/WebKit/LayoutTests/http/tests/loading/resources/no-cache-xslt.php
[add] https://crrev.com/54c7dbb6ffaf423ca61bf7382db7a506b4b759df/third_party/WebKit/LayoutTests/http/tests/loading/resources/reference-css-no-cache.xhtml
[modify] https://crrev.com/54c7dbb6ffaf423ca61bf7382db7a506b4b759df/third_party/WebKit/Source/core/fetch/CSSStyleSheetResource.cpp
[modify] https://crrev.com/54c7dbb6ffaf423ca61bf7382db7a506b4b759df/third_party/WebKit/Source/core/fetch/XSLStyleSheetResource.cpp

Sign in to add a comment