A pinned notification can be removed by delete key |
|||||
Issue descriptionVersion: 55.0.2858.0 Platform: 8800.0.0 What steps will reproduce the problem? (1) Open the message center (2) Move focus to a pinned notification by pressing TAB key (3) Press delete key What is the expected output? The pinned notification remains. What do you see instead? The pinned notification disappeared.
,
Sep 30 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d78edc6840a9a42afc7b50e6e714b9fc21f0c6d8 commit d78edc6840a9a42afc7b50e6e714b9fc21f0c6d8 Author: yoshiki <yoshiki@chromium.org> Date: Fri Sep 30 12:56:45 2016 Not remove a pinned notification by user action The pinned notification should be unremovable by user action, but it was removable by delete key. This patch fixes the issue by making pinned notifications unremovable by user action. BUG= 647149 TEST=manual test Review-Url: https://codereview.chromium.org/2371693002 Cr-Commit-Position: refs/heads/master@{#422092} [modify] https://crrev.com/d78edc6840a9a42afc7b50e6e714b9fc21f0c6d8/ui/message_center/message_center_impl.cc
,
Oct 5 2016
,
Oct 6 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5ac2951337b278b6caaed5304f95db151a411983 commit 5ac2951337b278b6caaed5304f95db151a411983 Author: xiyuan <xiyuan@chromium.org> Date: Thu Oct 06 16:58:52 2016 arc: OnClosedFromAndroid removes notifications as not by_user Otherwise, a pinned notification remains in message center while the underlying ArcNotificationItem is destroyed. This would cause a crash later when message center attempts to create a view for the notification. BUG= 647149 ,649379 BUG=b/31905643 TEST=Install any app from play store. After install finishes, bring up the message center and observe no crash. Review-Url: https://codereview.chromium.org/2394483004 Cr-Commit-Position: refs/heads/master@{#423565} [modify] https://crrev.com/5ac2951337b278b6caaed5304f95db151a411983/ui/arc/notification/arc_notification_item.cc [modify] https://crrev.com/5ac2951337b278b6caaed5304f95db151a411983/ui/arc/notification/arc_notification_item.h [modify] https://crrev.com/5ac2951337b278b6caaed5304f95db151a411983/ui/arc/notification/arc_notification_manager.cc
,
Oct 27 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5ac2951337b278b6caaed5304f95db151a411983 commit 5ac2951337b278b6caaed5304f95db151a411983 Author: xiyuan <xiyuan@chromium.org> Date: Thu Oct 06 16:58:52 2016 arc: OnClosedFromAndroid removes notifications as not by_user Otherwise, a pinned notification remains in message center while the underlying ArcNotificationItem is destroyed. This would cause a crash later when message center attempts to create a view for the notification. BUG= 647149 ,649379 BUG=b/31905643 TEST=Install any app from play store. After install finishes, bring up the message center and observe no crash. Review-Url: https://codereview.chromium.org/2394483004 Cr-Commit-Position: refs/heads/master@{#423565} [modify] https://crrev.com/5ac2951337b278b6caaed5304f95db151a411983/ui/arc/notification/arc_notification_item.cc [modify] https://crrev.com/5ac2951337b278b6caaed5304f95db151a411983/ui/arc/notification/arc_notification_item.h [modify] https://crrev.com/5ac2951337b278b6caaed5304f95db151a411983/ui/arc/notification/arc_notification_manager.cc
,
Nov 2 2016
Verified on 8872.35.0, 55.0.2883.35
,
Nov 4 2016
[Automated comment] removing mislabelled merge-merged-2840 |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by yoshiki@chromium.org
, Sep 20 2016Status: Started (was: Untriaged)