New issue
Advanced search Search tips

Issue 647133 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Sep 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Use [Unscopable], instead of [Unscopeable]

Project Member Reported by hayato@chromium.org, Sep 15 2016

Issue description

It looks Blink's IDL uses [Unscopeable], while Web IDL spec uses [Unscopable].

http://heycam.github.io/webidl/#Unscopable

We should align it to [Unscopable].


 
Project Member

Comment 1 by bugdroid1@chromium.org, Sep 15 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f48c40dbcd7d0959714463d0df8ea335a19d540c

commit f48c40dbcd7d0959714463d0df8ea335a19d540c
Author: peria <peria@chromium.org>
Date: Thu Sep 15 15:53:26 2016

Replace 'Unscopeable' with 'Unscopable'

This is a mechanical change, using
 $ sed -i -e ''s/\([Uu]\)nscopeable/\1nscopable/g' *
Plus, updates a test file LayoutTests/fast/js/unscop(e)able.html
to use testharness.html.  It also removes the expected file.

BUG= 647133 

Review-Url: https://codereview.chromium.org/2341673004
Cr-Commit-Position: refs/heads/master@{#418875}

[modify] https://crrev.com/f48c40dbcd7d0959714463d0df8ea335a19d540c/third_party/WebKit/LayoutTests/fast/dom/ChildNode/after.html
[modify] https://crrev.com/f48c40dbcd7d0959714463d0df8ea335a19d540c/third_party/WebKit/LayoutTests/fast/dom/ChildNode/before.html
[modify] https://crrev.com/f48c40dbcd7d0959714463d0df8ea335a19d540c/third_party/WebKit/LayoutTests/fast/dom/ChildNode/replace-with.html
[modify] https://crrev.com/f48c40dbcd7d0959714463d0df8ea335a19d540c/third_party/WebKit/LayoutTests/fast/dom/ParentNode/append.html
[modify] https://crrev.com/f48c40dbcd7d0959714463d0df8ea335a19d540c/third_party/WebKit/LayoutTests/fast/dom/ParentNode/prepend.html
[add] https://crrev.com/f48c40dbcd7d0959714463d0df8ea335a19d540c/third_party/WebKit/LayoutTests/fast/js/unscopable.html
[delete] https://crrev.com/0118e63731d7b195258c64fefc1efbc8e44ef35b/third_party/WebKit/LayoutTests/fast/js/unscopeable-expected.txt
[delete] https://crrev.com/0118e63731d7b195258c64fefc1efbc8e44ef35b/third_party/WebKit/LayoutTests/fast/js/unscopeable.html
[modify] https://crrev.com/f48c40dbcd7d0959714463d0df8ea335a19d540c/third_party/WebKit/Source/bindings/IDLExtendedAttributes.md
[modify] https://crrev.com/f48c40dbcd7d0959714463d0df8ea335a19d540c/third_party/WebKit/Source/bindings/IDLExtendedAttributes.txt
[modify] https://crrev.com/f48c40dbcd7d0959714463d0df8ea335a19d540c/third_party/WebKit/Source/bindings/scripts/v8_interface.py
[modify] https://crrev.com/f48c40dbcd7d0959714463d0df8ea335a19d540c/third_party/WebKit/Source/bindings/templates/interface.cpp
[modify] https://crrev.com/f48c40dbcd7d0959714463d0df8ea335a19d540c/third_party/WebKit/Source/bindings/templates/interface.h
[modify] https://crrev.com/f48c40dbcd7d0959714463d0df8ea335a19d540c/third_party/WebKit/Source/bindings/templates/interface_base.cpp
[modify] https://crrev.com/f48c40dbcd7d0959714463d0df8ea335a19d540c/third_party/WebKit/Source/bindings/templates/partial_interface.cpp
[modify] https://crrev.com/f48c40dbcd7d0959714463d0df8ea335a19d540c/third_party/WebKit/Source/bindings/templates/partial_interface.h
[modify] https://crrev.com/f48c40dbcd7d0959714463d0df8ea335a19d540c/third_party/WebKit/Source/bindings/tests/idls/core/TestObject.idl
[modify] https://crrev.com/f48c40dbcd7d0959714463d0df8ea335a19d540c/third_party/WebKit/Source/bindings/tests/idls/modules/TestInterfacePartial3.idl
[modify] https://crrev.com/f48c40dbcd7d0959714463d0df8ea335a19d540c/third_party/WebKit/Source/bindings/tests/results/core/V8TestObject.cpp
[modify] https://crrev.com/f48c40dbcd7d0959714463d0df8ea335a19d540c/third_party/WebKit/Source/bindings/tests/results/modules/V8TestInterfacePartial.cpp
[modify] https://crrev.com/f48c40dbcd7d0959714463d0df8ea335a19d540c/third_party/WebKit/Source/core/dom/ChildNode.idl
[modify] https://crrev.com/f48c40dbcd7d0959714463d0df8ea335a19d540c/third_party/WebKit/Source/core/dom/Element.idl
[modify] https://crrev.com/f48c40dbcd7d0959714463d0df8ea335a19d540c/third_party/WebKit/Source/core/dom/ParentNode.idl
[modify] https://crrev.com/f48c40dbcd7d0959714463d0df8ea335a19d540c/third_party/WebKit/Source/core/testing/Internals.cpp
[modify] https://crrev.com/f48c40dbcd7d0959714463d0df8ea335a19d540c/third_party/WebKit/Source/core/testing/Internals.h
[modify] https://crrev.com/f48c40dbcd7d0959714463d0df8ea335a19d540c/third_party/WebKit/Source/core/testing/Internals.idl

Comment 2 by peria@chromium.org, Sep 16 2016

Owner: peria@chromium.org
Status: Fixed (was: Available)

Sign in to add a comment