Fragment navigation strips "offline" indicator form Location Bar |
|||||
Issue descriptionOn Android build M54: 1. Go to alexainslie.com, download that page 2. Open that page from Download Home 3. At the top-right corner, there is a rectangle (not-rendered-icon from web font). Click on it. It navigates to #nav. Observe that "Offline" indicator disappeared, while the page is still there. Likely culprit: The OfflinePageTabHelper resets the hint (offline_page_) when fragment navigation starts. NavigationHelper::IsSamePage() has to be used to check if it is the same-page navigation - however, note that this bit can only be checked from WebContentsObserver::DidFinishNavigation(), it is always false in DidStartNavigation().
,
Sep 16 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c1eac5fc313081e76aaf6286464c448cca581147 commit c1eac5fc313081e76aaf6286464c448cca581147 Author: dimich <dimich@chromium.org> Date: Fri Sep 16 03:31:00 2016 Fix the disappearance of "Offline" chip from the LocationBar when navigating to a fragment. BUG= 647117 Review-Url: https://codereview.chromium.org/2347723002 Cr-Commit-Position: refs/heads/master@{#419094} [modify] https://crrev.com/c1eac5fc313081e76aaf6286464c448cca581147/chrome/browser/android/offline_pages/offline_page_request_job_unittest.cc [modify] https://crrev.com/c1eac5fc313081e76aaf6286464c448cca581147/chrome/browser/android/offline_pages/offline_page_tab_helper.cc [modify] https://crrev.com/c1eac5fc313081e76aaf6286464c448cca581147/chrome/browser/android/offline_pages/offline_page_tab_helper.h
,
Sep 16 2016
,
Sep 16 2016
Your change meets the bar and is auto-approved for M54 (branch: 2840)
,
Sep 16 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/29569d2a466072fe5c0fb57bfd3c33d6a531eb7d commit 29569d2a466072fe5c0fb57bfd3c33d6a531eb7d Author: Dmitry Titov <dimich@chromium.org> Date: Fri Sep 16 21:23:17 2016 Fix the disappearance of "Offline" chip from the LocationBar when navigating to a fragment. BUG= 647117 Review-Url: https://codereview.chromium.org/2347723002 Cr-Commit-Position: refs/heads/master@{#419094} (cherry picked from commit c1eac5fc313081e76aaf6286464c448cca581147) Review URL: https://codereview.chromium.org/2343273002 . Cr-Commit-Position: refs/branch-heads/2840@{#397} Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607} [modify] https://crrev.com/29569d2a466072fe5c0fb57bfd3c33d6a531eb7d/chrome/browser/android/offline_pages/offline_page_request_job_unittest.cc [modify] https://crrev.com/29569d2a466072fe5c0fb57bfd3c33d6a531eb7d/chrome/browser/android/offline_pages/offline_page_tab_helper.cc [modify] https://crrev.com/29569d2a466072fe5c0fb57bfd3c33d6a531eb7d/chrome/browser/android/offline_pages/offline_page_tab_helper.h
,
Sep 20 2016
,
Oct 27 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/29569d2a466072fe5c0fb57bfd3c33d6a531eb7d commit 29569d2a466072fe5c0fb57bfd3c33d6a531eb7d Author: Dmitry Titov <dimich@chromium.org> Date: Fri Sep 16 21:23:17 2016 Fix the disappearance of "Offline" chip from the LocationBar when navigating to a fragment. BUG= 647117 Review-Url: https://codereview.chromium.org/2347723002 Cr-Commit-Position: refs/heads/master@{#419094} (cherry picked from commit c1eac5fc313081e76aaf6286464c448cca581147) Review URL: https://codereview.chromium.org/2343273002 . Cr-Commit-Position: refs/branch-heads/2840@{#397} Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607} [modify] https://crrev.com/29569d2a466072fe5c0fb57bfd3c33d6a531eb7d/chrome/browser/android/offline_pages/offline_page_request_job_unittest.cc [modify] https://crrev.com/29569d2a466072fe5c0fb57bfd3c33d6a531eb7d/chrome/browser/android/offline_pages/offline_page_tab_helper.cc [modify] https://crrev.com/29569d2a466072fe5c0fb57bfd3c33d6a531eb7d/chrome/browser/android/offline_pages/offline_page_tab_helper.h |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by dim...@chromium.org
, Sep 15 2016Owner: dim...@chromium.org
Status: Started (was: Untriaged)