New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 647112 link

Starred by 1 user
Status: Verified
Owner:
tedc...@chromium.org
Closed: Sep 2016
Cc:
maxwalker@chromium.org
tedc...@chromium.org
fgor...@chromium.org
█ talo@chromium.org
█ dah...@chromium.org
█ dfalcant...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug



Sign in to add a comment

Divider line for omnibox verbose state sizing change

Project Member Reported by rachelis@chromium.org, Sep 15 2016 
The divider line is a bit taller than intended. 

First screenshot shows the current state, second image shows the intended state. Please reference the spec found here: https://folio.googleplex.com/omnibox-spec/Touch/Spec#%2FTouch-Verbose-State-And-Dividers.png%3Fz=width
Screen Shot 2016-09-14 at 8.15.47 PM.png
174 KB View Download
unnamed.jpg
49.2 KB View Download

Comment 1 by rachelis@chromium.org, Sep 15 2016

Cc: maxwalker@chromium.org

Comment 2 by fgor...@chromium.org, Sep 15 2016

Cc: tedc...@chromium.org
Question to UX/PM: Which milestone is this for? 54/55?
Question to Ted: Can someone on your team work this out? It will be much faster for clank UI team than for me or someone on our team to work the details of spacing here. I remember doing that 7 months ago, but still...

Comment 3 by talo@chromium.org, Sep 15 2016

Cc: dah...@chromium.org dfalcant...@chromium.org
It would be great if we could do this for M54 as polish fixes. 

Ted/Dan – let us know what may make sense here!

Comment 4 by tedc...@chromium.org, Sep 15 2016

Owner: tedc...@chromium.org
Status: Started (was: Untriaged)
Attached is an updated version...let me know if that looks ok
screenshot-06936436235548db-20160915T094530.png
11.2 KB View Download

Comment 5 by maxwalker@chromium.org, Sep 16 2016 

Looks good to me - thanks!

Comment 6 by rachelis@chromium.org, Sep 16 2016 

Much better! Thanks!
Project Member

Comment 7 by bugdroid1@chromium.org, Sep 16 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b95699ec44649867daef03c0b65f9a46226a3a38

commit b95699ec44649867daef03c0b65f9a46226a3a38
Author: tedchoc <tedchoc@chromium.org>
Date: Fri Sep 16 18:30:38 2016

Limit the height of the offline omnibox divider.

BUG= 647112 

Review-Url: https://codereview.chromium.org/2340923004
Cr-Commit-Position: refs/heads/master@{#419224}

[modify] https://crrev.com/b95699ec44649867daef03c0b65f9a46226a3a38/chrome/android/java/res/layout/location_bar_status.xml

Comment 8 by tedc...@chromium.org, Sep 16 2016

Status: Fixed (was: Started)

Comment 9 by krav...@chromium.org, Sep 22 2016

Status: Verified (was: Fixed)
Verified in M55-55.0.2868.0 build
►

Sign in to add a comment