This is going to be tricky to fix

spqchan@ - do you know which cl caused this regression?

Yes, it's one of the CLs I made to fix some fullscreen issues.

It fixes the issues but introduce smaller issues like this one. This is the reason why I want to refactor the fullscreen toolbar code.

I'm thinking we should perhaps put together a test plan doc with a bunch of fullscreen use cases (like this one). That way when you make a change you can quickly run through them to see if anything broke. Also a good doc for the testers to have. What do you think?

Sounds good. This is actually part of the design doc I'm working on. I'll make sure to include cases like Active Spaces, SplitView and multiple monitors for the testers

I'm also putting together flow chart for the edge cases for a single monitor.
Here's the flow chart in progress if you're interested:
https://www.lucidchart.com/publicSegments/view/99709cab-ad79-4a41-990e-9d88a992d05e

I'm going to try to write tests for each state for the flow chart. Unfortunately, there's a lot of the stuff is difficult to write tests for (Animation and menubar events for example), so we might have to do a lot of manual testing. 

M54 Stable release is scheduled for the first week of OCT, please have the fix baked/verified in canary and request a merge to M54 ASAP.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8a690e5e200f90623e69083917fea4677e11e660

commit 8a690e5e200f90623e69083917fea4677e11e660
Author: spqchan <spqchan@chromium.org>
Date: Fri Sep 23 17:25:31 2016

[Mac] Fix for the fullscreen toolbar issue with Active Spaces

Made sure that the menubar state is correct when the active space is
changed

BUG= 647111 

Review-Url: https://codereview.chromium.org/2351283004
Cr-Commit-Position: refs/heads/master@{#420645}

[modify] https://crrev.com/8a690e5e200f90623e69083917fea4677e11e660/chrome/browser/ui/cocoa/fullscreen_toolbar_controller.mm

Your change meets the bar and is auto-approved for M54 (branch: 2840)

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a5231a257dbd8feefe0e180be0fb976e1a958ad6

commit a5231a257dbd8feefe0e180be0fb976e1a958ad6
Author: spqchan <spqchan@chromium.org>
Date: Mon Sep 26 17:26:21 2016

[Mac] Fix for the fullscreen toolbar issue with Active Spaces

Made sure that the menubar state is correct when the active space is
changed

BUG= 647111 

Review-Url: https://codereview.chromium.org/2351283004
Cr-Commit-Position: refs/heads/master@{#420645}
(cherry picked from commit 8a690e5e200f90623e69083917fea4677e11e660)

Review URL: https://codereview.chromium.org/2370893002 .

Cr-Commit-Position: refs/branch-heads/2840@{#531}
Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607}

[modify] https://crrev.com/a5231a257dbd8feefe0e180be0fb976e1a958ad6/chrome/browser/ui/cocoa/fullscreen_toolbar_controller.mm

Thanks for the fix and merging the patch to M54. 
If there is no pending work, could you please tag the bug as fixed.

Verified the fix on MAC (10.11.6) for Google Chrome Beta Version - 54.0.2840.41

Screen-recording is attached.

TE-Verified Labels are added.

@pinkerton: Could you also please have a look and confirm the fix.

Thank you.

Deleted: 647111.mov 15.2 MB

647111.mov 15.2 MB Download

Yes, appears fixed in .41. Thanks!!

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a5231a257dbd8feefe0e180be0fb976e1a958ad6

commit a5231a257dbd8feefe0e180be0fb976e1a958ad6
Author: spqchan <spqchan@chromium.org>
Date: Mon Sep 26 17:26:21 2016

[Mac] Fix for the fullscreen toolbar issue with Active Spaces

Made sure that the menubar state is correct when the active space is
changed

BUG= 647111 

Review-Url: https://codereview.chromium.org/2351283004
Cr-Commit-Position: refs/heads/master@{#420645}
(cherry picked from commit 8a690e5e200f90623e69083917fea4677e11e660)

Review URL: https://codereview.chromium.org/2370893002 .

Cr-Commit-Position: refs/branch-heads/2840@{#531}
Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607}

[modify] https://crrev.com/a5231a257dbd8feefe0e180be0fb976e1a958ad6/chrome/browser/ui/cocoa/fullscreen_toolbar_controller.mm

 Issue 626897  has been merged into this issue.