Issue metadata
Sign in to add a comment
|
Bugdroid did not report a committed CL on the bug |
||||||||||||||||||||||||
Issue descriptionCL that landed: http://crrev.com/2322693003. Bug that was not updated: http://crbug.com/592873 . CCing agable as an owner for bugdroid service. Is there some component that I should use instead?
,
Sep 15 2016
,
Sep 19 2016
Pri-2 in the absence of a priority.
,
Sep 19 2016
,
Nov 21 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/hdctools/+/7e53a2538846f7ca7f03656f570d00f83ea8bcea commit 7e53a2538846f7ca7f03656f570d00f83ea8bcea Author: Aseda Aboagye <aaboagye@google.com> Date: Fri Oct 21 18:40:46 2016 pty_driver: Freeze terminals when using regexp. The pty driver has the ability to have regular expressions to check the output after running some command. However, if a user has a serial terminal open, the command will fail because the serial console output will go to the user's terminal instead of being caught by the pty_driver functions. This commit attempts to freeze any terminals that are in use when a regexp is set. The TerminalFreezer class has been moved here from it's former home in chromite. BUG= chromium:647109 BRANCH=None TEST=Open minicom for the EC console on kevin and cyan. Verify that `dut-control power_state:rec` succeeds without having to close minicom. TEST=Verify servod starts successfully on a servo v3. Change-Id: I2a4ee4e47cc5cf735f98b770a319ab04cab5f580 Signed-off-by: Aseda Aboagye <aaboagye@google.com> Reviewed-on: https://chromium-review.googlesource.com/401529 Commit-Ready: Aseda Aboagye <aaboagye@chromium.org> Tested-by: Aseda Aboagye <aaboagye@chromium.org> Reviewed-by: Julius Werner <jwerner@chromium.org> Reviewed-by: Mike Frysinger <vapier@chromium.org> [add] https://crrev.com/7e53a2538846f7ca7f03656f570d00f83ea8bcea/servo/terminal_freezer.py [modify] https://crrev.com/7e53a2538846f7ca7f03656f570d00f83ea8bcea/servo/drv/pty_driver.py [modify] https://crrev.com/7e53a2538846f7ca7f03656f570d00f83ea8bcea/servo/servod.py
,
Nov 21 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/hdctools/+/7e53a2538846f7ca7f03656f570d00f83ea8bcea commit 7e53a2538846f7ca7f03656f570d00f83ea8bcea Author: Aseda Aboagye <aaboagye@google.com> Date: Fri Oct 21 18:40:46 2016 pty_driver: Freeze terminals when using regexp. The pty driver has the ability to have regular expressions to check the output after running some command. However, if a user has a serial terminal open, the command will fail because the serial console output will go to the user's terminal instead of being caught by the pty_driver functions. This commit attempts to freeze any terminals that are in use when a regexp is set. The TerminalFreezer class has been moved here from it's former home in chromite. BUG= chromium:647109 BRANCH=None TEST=Open minicom for the EC console on kevin and cyan. Verify that `dut-control power_state:rec` succeeds without having to close minicom. TEST=Verify servod starts successfully on a servo v3. Change-Id: I2a4ee4e47cc5cf735f98b770a319ab04cab5f580 Signed-off-by: Aseda Aboagye <aaboagye@google.com> Reviewed-on: https://chromium-review.googlesource.com/401529 Commit-Ready: Aseda Aboagye <aaboagye@chromium.org> Tested-by: Aseda Aboagye <aaboagye@chromium.org> Reviewed-by: Julius Werner <jwerner@chromium.org> Reviewed-by: Mike Frysinger <vapier@chromium.org> [add] https://crrev.com/7e53a2538846f7ca7f03656f570d00f83ea8bcea/servo/terminal_freezer.py [modify] https://crrev.com/7e53a2538846f7ca7f03656f570d00f83ea8bcea/servo/drv/pty_driver.py [modify] https://crrev.com/7e53a2538846f7ca7f03656f570d00f83ea8bcea/servo/servod.py
,
Nov 22 2016
Sorry for the above CLs, I think I made a typo in the bug description. It should have been 657109.
,
Nov 22 2016
Issue 666653 has been merged into this issue.
,
Dec 8 2016
,
Dec 8 2016
,
Dec 16 2016
Another instance - issue 664622 - https://crrev.com/bb034491431fa28ce9b2be66b17c0417dffebc13
,
Apr 27 2017
,
May 3 2017
,
May 9 2017
Issue 715798 has been merged into this issue.
,
May 19 2017
Issue 724420 has been merged into this issue.
,
Jun 2 2017
,
Oct 30 2017
,
Oct 30 2017
Issue 774638 has been merged into this issue. |
|||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||
Comment 1 by loyso@chromium.org
, Sep 15 2016