New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 647109 link

Starred by 8 users

Issue metadata

Status: Duplicate
Merged: issue 625036
Owner: ----
Closed: Apr 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: ----



Sign in to add a comment

Bugdroid did not report a committed CL on the bug

Project Member Reported by serg...@chromium.org, Sep 15 2016

Issue description

CL that landed: http://crrev.com/2322693003.
Bug that was not updated:  http://crbug.com/592873 .

CCing agable as an owner for bugdroid service. Is there some component that I should use instead?
 

Comment 1 by loyso@chromium.org, Sep 15 2016

Cc: loyso@chromium.org

Comment 2 by estaab@chromium.org, Sep 15 2016

Components: -Infra Infra>Git
Pri-2 in the absence of a priority. 
Labels: Pri-2
Project Member

Comment 5 by bugdroid1@chromium.org, Nov 21 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/hdctools/+/7e53a2538846f7ca7f03656f570d00f83ea8bcea

commit 7e53a2538846f7ca7f03656f570d00f83ea8bcea
Author: Aseda Aboagye <aaboagye@google.com>
Date: Fri Oct 21 18:40:46 2016

pty_driver: Freeze terminals when using regexp.

The pty driver has the ability to have regular expressions to check the
output after running some command.  However, if a user has a serial
terminal open, the command will fail because the serial console output
will go to the user's terminal instead of being caught by the pty_driver
functions.

This commit attempts to freeze any terminals that are in use when a
regexp is set.  The TerminalFreezer class has been moved here from it's
former home in chromite.

BUG= chromium:647109 
BRANCH=None
TEST=Open minicom for the EC console on kevin and cyan.  Verify that
`dut-control power_state:rec` succeeds without having to close minicom.
TEST=Verify servod starts successfully on a servo v3.

Change-Id: I2a4ee4e47cc5cf735f98b770a319ab04cab5f580
Signed-off-by: Aseda Aboagye <aaboagye@google.com>
Reviewed-on: https://chromium-review.googlesource.com/401529
Commit-Ready: Aseda Aboagye <aaboagye@chromium.org>
Tested-by: Aseda Aboagye <aaboagye@chromium.org>
Reviewed-by: Julius Werner <jwerner@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[add] https://crrev.com/7e53a2538846f7ca7f03656f570d00f83ea8bcea/servo/terminal_freezer.py
[modify] https://crrev.com/7e53a2538846f7ca7f03656f570d00f83ea8bcea/servo/drv/pty_driver.py
[modify] https://crrev.com/7e53a2538846f7ca7f03656f570d00f83ea8bcea/servo/servod.py

Project Member

Comment 6 by bugdroid1@chromium.org, Nov 21 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/hdctools/+/7e53a2538846f7ca7f03656f570d00f83ea8bcea

commit 7e53a2538846f7ca7f03656f570d00f83ea8bcea
Author: Aseda Aboagye <aaboagye@google.com>
Date: Fri Oct 21 18:40:46 2016

pty_driver: Freeze terminals when using regexp.

The pty driver has the ability to have regular expressions to check the
output after running some command.  However, if a user has a serial
terminal open, the command will fail because the serial console output
will go to the user's terminal instead of being caught by the pty_driver
functions.

This commit attempts to freeze any terminals that are in use when a
regexp is set.  The TerminalFreezer class has been moved here from it's
former home in chromite.

BUG= chromium:647109 
BRANCH=None
TEST=Open minicom for the EC console on kevin and cyan.  Verify that
`dut-control power_state:rec` succeeds without having to close minicom.
TEST=Verify servod starts successfully on a servo v3.

Change-Id: I2a4ee4e47cc5cf735f98b770a319ab04cab5f580
Signed-off-by: Aseda Aboagye <aaboagye@google.com>
Reviewed-on: https://chromium-review.googlesource.com/401529
Commit-Ready: Aseda Aboagye <aaboagye@chromium.org>
Tested-by: Aseda Aboagye <aaboagye@chromium.org>
Reviewed-by: Julius Werner <jwerner@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[add] https://crrev.com/7e53a2538846f7ca7f03656f570d00f83ea8bcea/servo/terminal_freezer.py
[modify] https://crrev.com/7e53a2538846f7ca7f03656f570d00f83ea8bcea/servo/drv/pty_driver.py
[modify] https://crrev.com/7e53a2538846f7ca7f03656f570d00f83ea8bcea/servo/servod.py

Sorry for the above CLs, I think I made a typo in the bug description. It should have been 657109.

Comment 8 by aga...@chromium.org, Nov 22 2016

 Issue 666653  has been merged into this issue.
Cc: tandrii@chromium.org
 Issue 671513  has been merged into this issue.
Labels: -Restrict-View-Google
Mergedinto: 625036
Status: Duplicate (was: Untriaged)
Cc: servolk@chromium.org dalecur...@chromium.org
 Issue 717630  has been merged into this issue.
 Issue 715798  has been merged into this issue.
 Issue 724420  has been merged into this issue.
Cc: raphael....@intel.com
 Issue 728972  has been merged into this issue.
Cc: magjed@chromium.org denicija@chromium.org
 Issue 734941  has been merged into this issue.
Issue 774638 has been merged into this issue.

Sign in to add a comment