New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 647095 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Sep 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Can't right-click on apps to set them to open as window

Project Member Reported by dcheng@chromium.org, Sep 15 2016

Issue description

Chrome Version       : 55.0.2859.0

What steps will reproduce the problem?
1. Go to chrome://apps
2. Right click something
3.

What is the expected result?
Context menu.

What happens instead of that?
The app launches. Instead, you have to use the keyboard context menu key to get this to work...
 

Comment 1 by tapted@chromium.org, Sep 15 2016

Cc: tapted@chromium.org dbeam@chromium.org est...@chromium.org
Components: -Platform>Apps>AppLauncher Platform>Apps>Launcher
Labels: -Pri-3 Needs-Bisect OS-Mac Pri-1
This is bizarre - on Mac (Dev/55.0.2859.0 and Canary 2860) it happens too, but flakily. Mashing right-clicks around chrome://apps eventually launches something. Does it always repro on Windows?

Comment 2 by dbeam@chromium.org, Sep 15 2016

Owner: nzolghadr@chromium.org
auxclick issue, pretty sure

Comment 3 by dbeam@chromium.org, Sep 15 2016

fwiw: it seems to reproduce 100% on windows canary

recently, nzolghadr@ added the ability to handle auxiliary clicks (i.e. not the primary mouse button).  it seems that 'auxclick' is triggering AppsPage#onClick_ and we should probably filter some e.button values out (i.e. > 1).

Comment 4 by dbeam@chromium.org, Sep 15 2016

Labels: OS-Linux
i can hit this on Linux as well

repro steps (probably same for mac):
1) right mouse down on app
2) move mouse
3) right mouse up while still on app

Comment 5 by dbeam@chromium.org, Sep 15 2016

Cc: -dbeam@chromium.org nzolghadr@chromium.org
Owner: dbeam@chromium.org
Status: Started (was: Unconfirmed)
Cc: krajshree@chromium.org
Labels: -Needs-Bisect M-55 hasbisect
Able to reproduce the issue on Windows 10, Ubuntu 14.04, Mac OS 10.11.6 using reported version #55.0.2859.0 and latest canary #55.0.2860.0.

Bisect Information:
=====================
Good build: 55.0.2853.0
Bad Build : 55.0.2854.2

Change Log URL: 
https://chromium.googlesource.com/chromium/src/+log/3eda8caca348d8c2c2f72d28af48e0757f83d1f2..7be81ca9b22fe6abb5a96d200f77167cae987b5f

From the above change log suspecting below change

Review URL: https://codereview.chromium.org/2302513002

nzolghadr@ - Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner.
Labels: -hasbisect hasbisect-per-revison
Labels: -Type-Bug Type-Bug-Regression
Project Member

Comment 9 by bugdroid1@chromium.org, Sep 15 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/40aece67bda1a31539b152d4e092b1c712417b38

commit 40aece67bda1a31539b152d4e092b1c712417b38
Author: dbeam <dbeam@chromium.org>
Date: Thu Sep 15 16:13:53 2016

chrome://apps - don't launch apps on right click. Only left or middle.

R=nzolghadr@chromium.org
BUG= 647095 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2340203002
Cr-Commit-Position: refs/heads/master@{#418880}

[modify] https://crrev.com/40aece67bda1a31539b152d4e092b1c712417b38/chrome/browser/resources/ntp4/apps_page.js

Comment 10 by dbeam@chromium.org, Sep 15 2016

Status: Fixed (was: Started)

Sign in to add a comment