New issue
Advanced search Search tips

Issue 647086 link

Starred by 1 user
Status: Verified
Owner:
mdjones@chromium.org
Closed: Sep 2016
Cc:
wychen@chromium.org
mdjones@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug



Sign in to add a comment

When "request desktop site" is checked, don't show reader mode

Project Member Reported by wychen@chromium.org, Sep 15 2016

Comment 1 by mdjones@chromium.org, Sep 16 2016

Cc: wychen@chromium.org
Labels: OS-Android
Owner: mdjones@chromium.org
Status: Started (was: Untriaged)
This one is pretty straight-forward, I'll take care of it.

Comment 2 by wychen@chromium.org, Sep 17 2016

Labels: -Pri-3 Pri-2
Thanks! This should be the fix with highest impact/effort ratio to ease the infobar annoyance issue.

Comment 4 by mdjones@chromium.org, Sep 19 2016

Status: Fixed (was: Started)

Comment 5 by wychen@chromium.org, Sep 22 2016

Labels: Merge-Request-54
Status: Verified (was: Fixed)
Verified on Canary 55.0.2867.0

Comment 6 by dimu@chromium.org, Sep 22 2016

Labels: -Merge-Request-54 Merge-Approved-54 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M54 (branch: 2840)
Project Member

Comment 7 by sheriffbot@chromium.org, Sep 26 2016 

This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 8 by bugdroid1@chromium.org, Sep 26 2016

Labels: -merge-approved-54 merge-merged-2840
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/868f7da2beed900db05262c85e986fefa4b9e4c1

commit 868f7da2beed900db05262c85e986fefa4b9e4c1
Author: Matthew Jones <mdjones@chromium.org>
Date: Mon Sep 26 15:28:52 2016

Disable Reader Mode when requesting desktop site

If requesting a desktop site on mobile, Reader Mode will no longer
trigger unless its heuristic is set to ALWAYS_TRUE.

BUG= 647086 

Review-Url: https://codereview.chromium.org/2342873005
Cr-Commit-Position: refs/heads/master@{#419562}
(cherry picked from commit 591e68b15907d0489d344083411f24b1c2c81809)

Review URL: https://codereview.chromium.org/2368243003 .

Cr-Commit-Position: refs/branch-heads/2840@{#529}
Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607}

[modify] https://crrev.com/868f7da2beed900db05262c85e986fefa4b9e4c1/chrome/android/java/src/org/chromium/chrome/browser/dom_distiller/DomDistillerTabUtils.java
[modify] https://crrev.com/868f7da2beed900db05262c85e986fefa4b9e4c1/chrome/android/java/src/org/chromium/chrome/browser/dom_distiller/ReaderModeManager.java
[modify] https://crrev.com/868f7da2beed900db05262c85e986fefa4b9e4c1/chrome/android/javatests/src/org/chromium/chrome/browser/dom_distiller/ReaderModeManagerTest.java
[modify] https://crrev.com/868f7da2beed900db05262c85e986fefa4b9e4c1/chrome/browser/dom_distiller/tab_utils_android.cc
►

Sign in to add a comment