Number not shown in the Find In Dialog when tab is in presentation mode |
|||||||||
Issue descriptionVersion: 53.0.2785.113 (64-bit) & 55.0.2860.0 canary (64-bit) OS: Mac OSX 10.12 Sierra [Gold Star Version] What steps will reproduce the problem? (1) Open Google Drive and create a new Google slide (2) Once done, open the PPT in the presentation mode. (3) Press CMD+F to open the find in dialog and search for a word which is present in the PPT and verify. What is the expected output? The number of instances present in the slide should be shown next to the word in the Find in dialog box. What do you see instead? No number is shown. Please find the attached screen shot. Please use labels and text to provide additional information.
,
Oct 4 2016
Was able to reproduce this on 10.12, Chrome 55.0.2880.0 (Developer Build). Not reproducible on 10.11. Also, on 10.12, on Stable and Canary, I can see a number, but it is sometimes clipped. See attached screenshot. Maybe there is some difference between how views are being laid out on 10.12 which causes the view showing the occurrences to get clipped. Also, https://permission.site/ can be used to reproduce this. Sarah, can you look at this?
,
Oct 14 2016
This issue occurs for me everywhere without being in presentation mode, since upgrading to macOS 10.12. Please see my comments at https://bugs.chromium.org/p/chromium/issues/detail?id=524936
,
Oct 28 2016
This issue is specific to Mac OS 10.12 and able to reproduce it on chrome latest canary M56-56.0.2902.0 as well. Since Mac OS 10.12 is rolled out officially most of the users across global and still issue persists on chrome. Could any one let us know is there any latest update available for this issue? Note: Adding RB-Stable for now, please feel free to edit if this not the case. Thanks!
,
Oct 31 2016
**** Bulk edit - please ignore if not applicable **** A friendly reminder that M55 Stable is launch is coming soon! Your bug is labelled as Stable ReleaseBlock, pls make sure to land the fix and get it merged into the release branch ASAP so it gets enough baking time in Beta (before Stable promotion). Thank you!
,
Nov 5 2016
Investigated and working on a CL. The issue was that the view was not being drawn because of how things get updated 10.12
,
Nov 7 2016
**** Bulk edit - please ignore if not applicable **** A friendly reminder that M55 Stable is launch is coming soon! Your bug is labelled as Stable ReleaseBlock, pls make sure to land the fix and get it merged into the release branch ASAP so it gets enough baking time in Beta (before Stable promotion). Thank you! Also due to Thanksgiving holidays in US, please make sure all fixes are ready and merged to M55 latest by 5:00 PM PT Friday, 11/18/16.
,
Nov 7 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a779a7e195f1fb8f7a044355f96cf8b4fb272fde commit a779a7e195f1fb8f7a044355f96cf8b4fb272fde Author: spqchan <spqchan@chromium.org> Date: Mon Nov 07 21:48:38 2016 [Mac] Fix for find bar text issue |-resetFieldEditorFrameIfNeeded| only draws if the frame has changed. Ensure that the find bar gets redrawn, even when the frame stays the same. BUG= 647078 Review-Url: https://codereview.chromium.org/2479883003 Cr-Commit-Position: refs/heads/master@{#430384} [modify] https://crrev.com/a779a7e195f1fb8f7a044355f96cf8b4fb272fde/chrome/browser/ui/cocoa/find_bar/find_bar_cocoa_controller.mm
,
Nov 7 2016
,
Nov 8 2016
Your change meets the bar and is auto-approved for M55 (branch: 2883)
,
Nov 8 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/69cba6427c6cc679855739eda4e3311473cfa5ba commit 69cba6427c6cc679855739eda4e3311473cfa5ba Author: spqchan <spqchan@chromium.org> Date: Tue Nov 08 21:43:20 2016 [Mac] Fix for find bar text issue |-resetFieldEditorFrameIfNeeded| only draws if the frame has changed. Ensure that the find bar gets redrawn, even when the frame stays the same. BUG= 647078 Review-Url: https://codereview.chromium.org/2479883003 Cr-Commit-Position: refs/heads/master@{#430384} (cherry picked from commit a779a7e195f1fb8f7a044355f96cf8b4fb272fde) Review URL: https://codereview.chromium.org/2490703002 . Cr-Commit-Position: refs/branch-heads/2883@{#498} Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768} [modify] https://crrev.com/69cba6427c6cc679855739eda4e3311473cfa5ba/chrome/browser/ui/cocoa/find_bar/find_bar_cocoa_controller.mm
,
Nov 9 2016
Tested on Mac OS 10.12.1 using chrome Beta M55 #55.0.2883.44 and followed steps: 1. From Google drive, created a new google slide. 2. Opened the created google slide in Presentation mode. 3. on cmd+F , find dialog opened and searched for a word in ppt. 4. Find dialog shows 2 instances , though there is only one instance in ppt . 5. The word searched is not highlighted in PPT . Attached screencast for reference. Could anyone confirm whether step #4 & 5 are as intended ?? Thanks !
,
Nov 9 2016
This is working correctly since "Chrome Find" searches for entire tab rendering, you have a preview and other slide deck(not right term) hence you see 2 matches.
,
Nov 9 2016
|
|||||||||
►
Sign in to add a comment |
|||||||||
Comment 1 by rsesek@chromium.org
, Sep 19 2016