"FileFlusherTest.DuplicateRequests" is flaky |
|||||||||||
Issue description"FileFlusherTest.DuplicateRequests" is flaky. This issue was created automatically by the chromium-try-flakes app. Please find the right owner to fix the respective test/step and assign this issue to them. If the step/test is infrastructure-related, please add Infra-Troopers label and change issue status to Untriaged. When done, please remove the issue from Sheriff Bug Queue by removing the Sheriff-Chromium label. We have detected 3 recent flakes. List of all flakes can be found at https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyLAsSBUZsYWtlIiFGaWxlRmx1c2hlclRlc3QuRHVwbGljYXRlUmVxdWVzdHMM. Flaky tests should be disabled within 30 minutes unless culprit CL is found and reverted. Please see more details here: https://sites.google.com/a/chromium.org/dev/developers/tree-sheriffs/sheriffing-bug-queues#triaging-auto-filed-flakiness-bugs
,
Sep 15 2016
,
Sep 15 2016
,
Sep 15 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f8838f1b9bbba7eacaf398da4eaaf9996727b502 commit f8838f1b9bbba7eacaf398da4eaaf9996727b502 Author: xiyuan <xiyuan@chromium.org> Date: Thu Sep 15 18:44:24 2016 Fix flaky FileFlusherTest.DuplicateRequests The flakyness is cause by the racing that the first flush request might be started before the duplicate request comes in. Also fixed a problem that Job::ScheduleFinish could be called twice. One from Cancel and the other from Start on a canceled job. BUG= 647070 Review-Url: https://codereview.chromium.org/2342813003 Cr-Commit-Position: refs/heads/master@{#418914} [modify] https://crrev.com/f8838f1b9bbba7eacaf398da4eaaf9996727b502/chrome/browser/chromeos/base/file_flusher.cc [modify] https://crrev.com/f8838f1b9bbba7eacaf398da4eaaf9996727b502/chrome/browser/chromeos/base/file_flusher.h [modify] https://crrev.com/f8838f1b9bbba7eacaf398da4eaaf9996727b502/chrome/browser/chromeos/base/file_flusher_unittest.cc
,
Sep 15 2016
,
Oct 7 2016
,
Nov 19 2016
,
Jan 21 2017
,
Mar 4 2017
,
Apr 17 2017
,
May 30 2017
,
Aug 1 2017
,
Oct 14 2017
|
|||||||||||
►
Sign in to add a comment |
|||||||||||
Comment 1 by grt@chromium.org
, Sep 15 2016Owner: xiy...@chromium.org
Status: Assigned (was: Untriaged)
Here's an example failure: [ RUN ] FileFlusherTest.DuplicateRequests ../../chrome/browser/chromeos/base/file_flusher_unittest.cc:147: Failure Value of: GetFlushCount("dir1/file3") Actual: 2 Expected: 1 [ FAILED ] FileFlusherTest.DuplicateRequests (7 ms) Please fix, thanks.