New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 647067 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner:
Last visit > 30 days ago
Closed: Sep 2016
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Win_DRMemory_Full failed because of ScreenCapturerTest.CaptureUpdatedRegion

Project Member Reported by zijiehe@chromium.org, Sep 14 2016

Issue description

ScreenCapturerTest.CaptureUpdatedRegion* tests are flaky.
 
Status: WontFix (was: Assigned)
Please use bugs.webrtc.org bug tracker for bugs that are specific to WebRTC standalone. 

Project Member

Comment 2 by bugdroid1@chromium.org, Sep 15 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/external/webrtc.git/+/0a6e0dc471a90229c4f9a5a876e4ffafc4233c97

commit 0a6e0dc471a90229c4f9a5a876e4ffafc4233c97
Author: stefan <stefan@webrtc.org>
Date: Thu Sep 15 12:04:34 2016

Disable all screen-capturer tests

ScreenCapturerTest.CaptureUpdatedRegion* tests are flaky and are running in the
wrong executable.

BUG= webrtc:6366 ,  chromium:647067 
NOTRY=True

Review-Url: https://codereview.webrtc.org/2342823002
Cr-Commit-Position: refs/heads/master@{#14232}

[modify] https://crrev.com/0a6e0dc471a90229c4f9a5a876e4ffafc4233c97/webrtc/modules/desktop_capture/screen_capturer_unittest.cc

Project Member

Comment 3 by bugdroid1@chromium.org, Oct 21 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/external/webrtc.git/+/84fbf9ee380ba107d8ba851dcd721b764d396d99

commit 84fbf9ee380ba107d8ba851dcd721b764d396d99
Author: zijiehe <zijiehe@chromium.org>
Date: Fri Oct 21 00:00:37 2016

SUCCEEDED macro is misused

SUCCEEDED macro is designed for HRESULT instead of BOOL.
This change exposes my lack of knowledge of native Windows APIs. :(

BUG=https://bugs.chromium.org/p/chromium/issues/detail?id=647067

Review-Url: https://codereview.webrtc.org/2440563003
Cr-Commit-Position: refs/heads/master@{#14716}

[modify] https://crrev.com/84fbf9ee380ba107d8ba851dcd721b764d396d99/webrtc/modules/desktop_capture/screen_drawer_win.cc

Sign in to add a comment