[remoting host] Building remoting_me2me_host seems to pull in a lot of WebKit. |
|||
Issue descriptionTried building remoting_me2me_host on Linux and noticed that it spent a lot of time compiling WebKit code. The host process shouldn't need anything from WebKit. The dependency-chain (from gn path) looks like this: //remoting/host:remoting_me2me_host --[private]--> //remoting/host:remoting_me2me_host_static --[private]--> //remoting/host:host --[private]--> //content/public/common:common --[public]--> //content:content --[public]--> //content/ppapi_plugin:ppapi_plugin_sources --[private]--> //third_party/WebKit/public:blink --[private]--> //third_party/WebKit/Source/web:web --[private]--> //third_party/WebKit/Source/core:core
,
Sep 14 2016
From talking with Scott, this issue seems to be that both remoting/ and content/ define ParamTraits<net::IPAddress>, and somehow content/ was being pulled in by the Android build, leading to duplicate definitions. Ideally we should track down that dependency and remove it, but that still leaves us with two definitions for ParamTraits<net::IPAddress>. I wonder if it makes sense to move that definition out of content; perhaps in net? Dirk, I believe you and Scott discussed this briefly; WDYT?
,
Sep 15 2016
,
Sep 15 2016
I don't recall discussing this, but I agree that moving the definition into net seems at least plausible.
,
Oct 6 2016
|
|||
►
Sign in to add a comment |
|||
Comment 1 by lambroslambrou@chromium.org
, Sep 14 2016