Here's a better example.

Part of the problem is the fact that the stroke width is 1px instead of 1pt, so the line is too thin on a Retina Mac. The stroke width bug is being tracked in  Issue 644550 .

Deleted: Screen Shot 2016-09-16 at 4.32.02 PM.png 30.4 KB

	Screen Shot 2016-09-16 at 4.32.02 PM.png 30.4 KB View Download

Setting as blocked by  Issue 644550  because increasing the stroke width to 1pt (from the current px) might solve the problem.

The specs have been updated accordingly. Please assign the bug to me if there are any further questions or concerns.

https://folio.googleplex.com/chrome-ux-specs-and-sources/Chrome%20browser%20(MD)/Secondary%20UI%20Previews%20and%20specs%20(exports)#%2FSPEC-secondary-UI-04a-buttons-light-theme.png%3Fz=width

Hello kylixrd@ - can you make this change? Basically the button stroke needs to be changed to FFF 0.2a.

The class is MdTextButton, and it only applies to buttons that are not "prominent."

Hello bettes@,

In the button spec, the second column (Normal) says the stroke is #000 0.2a. However in the bottom row, third column, it says the normal button stroke is #000 0.1a. These values should be the same?

The textfield / dropdown button spec says the stroke there should be #000 0.14a - seems like it should be the same as the normal buttons?


https://folio.googleplex.com/chrome-ux-specs-and-sources/Chrome%20browser%20(MD)/Secondary%20UI%20Previews%20and%20specs%20(exports)/Spec#%2FSPEC-secondary-UI-04a-buttons-light-theme.png

https://folio.googleplex.com/chrome-ux-specs-and-sources/Chrome%20browser%20(MD)/Secondary%20UI%20Previews%20and%20specs%20(exports)/Spec#%2FSPEC-secondary-UI-06-dropdown-textfields.png

Actually, I see that in your message to chrome-harmony you state this:

Increased alpha on stroke to 0.20a for buttons, text-fields, and dropdown

So the spec just needs to be updated.

Here's the link to your post.

https://groups.google.com/a/google.com/forum/#!search/chrome-harmony%7Csort:relevance/chrome-harmony/tUe9loNX3hs/2Agbrp1CDwAJ

This is to bring them in line with the spec.

Currently the dropdown button stroke is also 1pt when it should be 1px. That should also be fixed at this time if it's still the case.

estade@ - are you available to make this change? My guess is it's not a lot a of work.

the button spec still seems to be experiencing a lot of churn, and I'm waiting for that to die down before making changes. Yes, individual changes such as changing a color are not usually(tm) a lot of work.

Hi estade@,

I don't know that the spec is final, but I wouldn't say it's going through a ton of churn. Changing the stroke to #000 0.2a is the latest from bettes@. We won't actually know how well it works until this change lands and we take a look at it.

Do you have time to make this change? Specifically, changing the button, textfield, and dropdown button strokes to #000 0.2a. I ask because I want this change made ASAP. If you do have the time I will assign it to you.

Spec updated. I'd agree, it'd be nice to see this live so that we can move forward with the rest of the dialog updates. 

ellyjones@ will make the changes.

the answer to the question shrike asked a short time ago is yes.

I think it's important that the same person who works on this also fixes the shadows (since the shadow spec changed as well).

whoops, I misclicked and deleted your comment Jayson. Feel free to re-post it.

estade@, I guess I'll just ask you to please not reassign bugs that I have already assigned to others. According to c#11 you had no intention of working on this change at this time, so I talked to ellyjones@ who agreed to do this work tomorrow. As the TL of this project I am assigning it back to her because I need it to get done, and in so doing I know for certain that it will get worked on tomorrow.

ellyjones@ - this is assigned back to you. This is a simple change that I just need to get done. If estade@ is determined to make the change and posts a cl for it this evening then you do not need to proceed, but if no such cl exists tomorrow, please put together a cl. Thank you.

I'm glad for the explanation. As it turns out, I asked you the same thing about reassigning bugs, but you've decided to ignore that. Also: started means started.

there's a patch posted for review here: https://codereview.chromium.org/2400563004/

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b440caef76273a30858144990c14bc4fa9793525

commit b440caef76273a30858144990c14bc4fa9793525
Author: estade <estade@chromium.org>
Date: Thu Oct 06 21:33:21 2016

Adjust shadow and stroke of MdTextButton.

Also fix the appearance of the "Show All" button on the download shelf when using custom themes (this regressed at some point in M55, as it works properly in my M54 build).

BUG= 647047 

Review-Url: https://codereview.chromium.org/2400563004
Cr-Commit-Position: refs/heads/master@{#423689}

[modify] https://crrev.com/b440caef76273a30858144990c14bc4fa9793525/ash/common/system/chromeos/session/logout_button_tray.cc
[modify] https://crrev.com/b440caef76273a30858144990c14bc4fa9793525/chrome/browser/ui/views/download/download_shelf_view.cc
[modify] https://crrev.com/b440caef76273a30858144990c14bc4fa9793525/chrome/browser/ui/views/infobars/confirm_infobar.cc
[modify] https://crrev.com/b440caef76273a30858144990c14bc4fa9793525/ui/views/animation/ink_drop_painted_layer_delegates.cc
[modify] https://crrev.com/b440caef76273a30858144990c14bc4fa9793525/ui/views/animation/ink_drop_painted_layer_delegates.h
[modify] https://crrev.com/b440caef76273a30858144990c14bc4fa9793525/ui/views/controls/button/md_text_button.cc
[modify] https://crrev.com/b440caef76273a30858144990c14bc4fa9793525/ui/views/controls/button/md_text_button.h

Verified the issue on windows 10, Ubuntu 14.04 and Mac 10.12 using chrome dev version #55.0.2883.6 as per comment #0.

The steps followed to reproduce the issue are as follows:
-----------
1. Launched chrome browser.
2. Opened wikipedia and clicked on star symbol in order to bookmark the page.
3. Observed that two buttons in the bookmarks dialog on the Mac did not show dark strokes. Same behavior is with windows also.

Checked the two buttons "remove" and "edit" on both the reported version #55.0.2860.0 and chrome dev version #55.0.2883.6. The strokes of these buttons in both these versions show the same behavior.

Please find attached the screenshots.

estade@ -  Could you please check the attached screen shots and confirm if this is the expected behavior.

Deleted: 55.0.2860.0.png 25.9 KB

	55.0.2860.0.png 25.9 KB View Download

Deleted: 55.0.2883.6.png 25.8 KB

	55.0.2883.6.png 25.8 KB View Download

Those screenshots are of the Cocoa version of this dialog, not the Views version. I don't think this bug needs verification, though.

ellyjones@, thank you for the update.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b440caef76273a30858144990c14bc4fa9793525

commit b440caef76273a30858144990c14bc4fa9793525
Author: estade <estade@chromium.org>
Date: Thu Oct 06 21:33:21 2016

Adjust shadow and stroke of MdTextButton.

Also fix the appearance of the "Show All" button on the download shelf when using custom themes (this regressed at some point in M55, as it works properly in my M54 build).

BUG= 647047 

Review-Url: https://codereview.chromium.org/2400563004
Cr-Commit-Position: refs/heads/master@{#423689}

[modify] https://crrev.com/b440caef76273a30858144990c14bc4fa9793525/ash/common/system/chromeos/session/logout_button_tray.cc
[modify] https://crrev.com/b440caef76273a30858144990c14bc4fa9793525/chrome/browser/ui/views/download/download_shelf_view.cc
[modify] https://crrev.com/b440caef76273a30858144990c14bc4fa9793525/chrome/browser/ui/views/infobars/confirm_infobar.cc
[modify] https://crrev.com/b440caef76273a30858144990c14bc4fa9793525/ui/views/animation/ink_drop_painted_layer_delegates.cc
[modify] https://crrev.com/b440caef76273a30858144990c14bc4fa9793525/ui/views/animation/ink_drop_painted_layer_delegates.h
[modify] https://crrev.com/b440caef76273a30858144990c14bc4fa9793525/ui/views/controls/button/md_text_button.cc
[modify] https://crrev.com/b440caef76273a30858144990c14bc4fa9793525/ui/views/controls/button/md_text_button.h

[Automated comment] removing mislabelled merge-merged-2840