New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 647043 link

Starred by 3 users
Status: Verified
Owner:
afakhry@chromium.org
Closed: Oct 2016
Cc:
█ scunning...@chromium.org
abodenha@chromium.org
dchan@chromium.org
█ dskaram@chromium.org
█ krishna...@chromium.org
█ josa...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Unwanted Chrome logo on SAML signin title bar

Project Member Reported by cernekee@chromium.org, Sep 14 2016 
On cyan 54.0.2837.0 / 8743.0.0, there is an unwanted Chrome logo on the upper left of the SSO signin dialog. (bad.png)

On cyan 54.0.2831.0 / 8734.0.0, everything was fine. (good.png)

Repro steps:

1) Get to the Chrome OS login page
2) Click "add a user" or otherwise get to a point where you can enter an email address
3) Enter adfs-test1@crosdev2.biz
4) If there is a certificate expiration warning, click Advanced, then scroll down, then click Proceed Anyway

Looking at the 2831->2837 delta in Goldeneye, this commit jumped out at me:

https://chromium.googlesource.com/chromium/src/+/7e40f625dc05c8932f66064cb9059c467cd27034
good.png
1.4 MB View Download
bad.png
1.4 MB View Download

Comment 1 by cernekee@chromium.org, Sep 14 2016 

> adfs-test1@crosdev2.biz

Or try: adfs-test1@devices.nomadicfeet.com and then hit cancel when the dialog comes up.

Comment 2 by weifangsun@chromium.org, Sep 15 2016

Status: Assigned (was: Untriaged)

Comment 3 by dskaram@google.com, Sep 15 2016 

Note that this becomes much worse when the message is longer e.g. when there is video running on that screen in cases like QR code login.

Comment 4 by trapti@chromium.org, Sep 15 2016

Cc: dchan@chromium.org scunning...@chromium.org krishna...@chromium.org
Could see chrome logo in clever badge(QR) sign in too

Peppy
M	ChromeOS	Chrome	ARC	Type	Channel
54	8743.28.0	54.0.2840.25	3268846	release	dev

Comment 5 by trapti@chromium.org, Sep 15 2016 

Attaching for reference
IMG_0593.JPG
669 KB View Download

Comment 6 by dskaram@chromium.org, Sep 22 2016

Labels: ReleaseBlock-Stable
Any updates on this? We have an upcoming launch for QR codes and this is quite an embarrassing glitch in the UI.

Comment 7 by zalcorn@chromium.org, Sep 22 2016 

alemate@ is OOO until late next week, how soon is your launch?

Comment 8 by dskaram@google.com, Sep 26 2016 

Launch is first week of October. Though if this is only on beta, then we're fine. If this made it to stable, we really have to merge a fix back before that.

Comment 9 by krishna...@chromium.org, Oct 4 2016

Cc: abodenha@chromium.org
Any updates on this?

Comment 10 by krishna...@chromium.org, Oct 10 2016

Cc: josa...@chromium.org
@zalcorn, @abodenha,
R54 Stable is around the corner ie, mid next week). 
This is a P1 + a R54 Stable Blocker.
+josafat, as well.

Comment 11 by abodenha@chromium.org, Oct 10 2016

Owner: afakhry@chromium.org
afakhry@ can you take a look at this?

Comment 12 by josa...@chromium.org, Oct 12 2016 

afakhry@ were you able to evaluate this blocking issue?

Comment 13 by afakhry@chromium.org, Oct 12 2016

Status: Started (was: Assigned)

Comment 14 by afakhry@chromium.org, Oct 12 2016 

Able to repro on ToT. Will look into it now.

Comment 15 by afakhry@chromium.org, Oct 12 2016 

It is indeed a regression caused by https://codereview.chromium.org/2247723002. CL with fix is up for review.
Project Member

Comment 16 by bugdroid1@chromium.org, Oct 12 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/74307c9d468b802c64200aa07c96ba01248b3026

commit 74307c9d468b802c64200aa07c96ba01248b3026
Author: afakhry <afakhry@chromium.org>
Date: Wed Oct 12 22:20:20 2016

Fix regression showing chrome logo in SAML signin title bar

A more specific CSS rule added recently overrides the less specific
rules that hides that logo in various login screens. This CL adds the
class no-logo to those screens for the display manager to hide that logo.

BUG= 647043 
TEST=Add a new user with a SAML-enabled account and make sure the unwanted
logo doesn't show up.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2412253002
Cr-Commit-Position: refs/heads/master@{#424879}

[modify] https://crrev.com/74307c9d468b802c64200aa07c96ba01248b3026/chrome/browser/resources/chromeos/login/oobe_screen_user_image.css
[modify] https://crrev.com/74307c9d468b802c64200aa07c96ba01248b3026/chrome/browser/resources/chromeos/login/oobe_screen_user_image.html
[modify] https://crrev.com/74307c9d468b802c64200aa07c96ba01248b3026/chrome/browser/resources/chromeos/login/screen_confirm_password.css
[modify] https://crrev.com/74307c9d468b802c64200aa07c96ba01248b3026/chrome/browser/resources/chromeos/login/screen_confirm_password.html
[modify] https://crrev.com/74307c9d468b802c64200aa07c96ba01248b3026/chrome/browser/resources/chromeos/login/screen_fatal_error.css
[modify] https://crrev.com/74307c9d468b802c64200aa07c96ba01248b3026/chrome/browser/resources/chromeos/login/screen_fatal_error.html
[modify] https://crrev.com/74307c9d468b802c64200aa07c96ba01248b3026/chrome/browser/resources/chromeos/login/screen_gaia_signin.css
[modify] https://crrev.com/74307c9d468b802c64200aa07c96ba01248b3026/chrome/browser/resources/chromeos/login/screen_gaia_signin.html
[modify] https://crrev.com/74307c9d468b802c64200aa07c96ba01248b3026/chrome/browser/resources/chromeos/login/screen_password_changed.css
[modify] https://crrev.com/74307c9d468b802c64200aa07c96ba01248b3026/chrome/browser/resources/chromeos/login/screen_password_changed.html

Comment 17 by afakhry@chromium.org, Oct 12 2016

Labels: Merge-Request-55 Merge-Request-54

Comment 18 by josa...@chromium.org, Oct 13 2016

Labels: -Merge-Request-54 -Merge-Request-55 Merge-Approved-54 Merge-Approved-55
Project Member

Comment 19 by bugdroid1@chromium.org, Oct 13 2016

Labels: -merge-approved-54 merge-merged-2840
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/31be6fad2470400b02b9bdd6d0a245a3b0670cdc

commit 31be6fad2470400b02b9bdd6d0a245a3b0670cdc
Author: Ahmed Fakhry <afakhry@google.com>
Date: Thu Oct 13 17:02:50 2016

[Merge to M54] Fix regression showing chrome logo in SAML signin title bar

A more specific CSS rule added recently overrides the less specific
rules that hides that logo in various login screens. This CL adds the
class no-logo to those screens for the display manager to hide that logo.

TBR=xiyuan@chromium.org
BUG= 647043 
TEST=Add a new user with a SAML-enabled account and make sure the unwanted
logo doesn't show up.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2412253002
Cr-Commit-Position: refs/heads/master@{#424879}
(cherry picked from commit 74307c9d468b802c64200aa07c96ba01248b3026)

Review URL: https://codereview.chromium.org/2414683004 .

Cr-Commit-Position: refs/branch-heads/2840@{#737}
Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607}

[modify] https://crrev.com/31be6fad2470400b02b9bdd6d0a245a3b0670cdc/chrome/browser/resources/chromeos/login/oobe_screen_user_image.css
[modify] https://crrev.com/31be6fad2470400b02b9bdd6d0a245a3b0670cdc/chrome/browser/resources/chromeos/login/oobe_screen_user_image.html
[modify] https://crrev.com/31be6fad2470400b02b9bdd6d0a245a3b0670cdc/chrome/browser/resources/chromeos/login/screen_confirm_password.css
[modify] https://crrev.com/31be6fad2470400b02b9bdd6d0a245a3b0670cdc/chrome/browser/resources/chromeos/login/screen_confirm_password.html
[modify] https://crrev.com/31be6fad2470400b02b9bdd6d0a245a3b0670cdc/chrome/browser/resources/chromeos/login/screen_fatal_error.css
[modify] https://crrev.com/31be6fad2470400b02b9bdd6d0a245a3b0670cdc/chrome/browser/resources/chromeos/login/screen_fatal_error.html
[modify] https://crrev.com/31be6fad2470400b02b9bdd6d0a245a3b0670cdc/chrome/browser/resources/chromeos/login/screen_gaia_signin.css
[modify] https://crrev.com/31be6fad2470400b02b9bdd6d0a245a3b0670cdc/chrome/browser/resources/chromeos/login/screen_gaia_signin.html
[modify] https://crrev.com/31be6fad2470400b02b9bdd6d0a245a3b0670cdc/chrome/browser/resources/chromeos/login/screen_password_changed.css
[modify] https://crrev.com/31be6fad2470400b02b9bdd6d0a245a3b0670cdc/chrome/browser/resources/chromeos/login/screen_password_changed.html
Project Member

Comment 20 by bugdroid1@chromium.org, Oct 13 2016

Labels: -merge-approved-55 merge-merged-2883
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f4c402c2f96203d11b00aa41cbfcd427998f3639

commit f4c402c2f96203d11b00aa41cbfcd427998f3639
Author: Ahmed Fakhry <afakhry@google.com>
Date: Thu Oct 13 17:09:49 2016

[Merge to M55] Fix regression showing chrome logo in SAML signin title bar

A more specific CSS rule added recently overrides the less specific
rules that hides that logo in various login screens. This CL adds the
class no-logo to those screens for the display manager to hide that logo.

TBR=xiyuan@chromium.org
BUG= 647043 
TEST=Add a new user with a SAML-enabled account and make sure the unwanted
logo doesn't show up.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2412253002
Cr-Commit-Position: refs/heads/master@{#424879}
(cherry picked from commit 74307c9d468b802c64200aa07c96ba01248b3026)

Review URL: https://codereview.chromium.org/2421533002 .

Cr-Commit-Position: refs/branch-heads/2883@{#88}
Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768}

[modify] https://crrev.com/f4c402c2f96203d11b00aa41cbfcd427998f3639/chrome/browser/resources/chromeos/login/oobe_screen_user_image.css
[modify] https://crrev.com/f4c402c2f96203d11b00aa41cbfcd427998f3639/chrome/browser/resources/chromeos/login/oobe_screen_user_image.html
[modify] https://crrev.com/f4c402c2f96203d11b00aa41cbfcd427998f3639/chrome/browser/resources/chromeos/login/screen_confirm_password.css
[modify] https://crrev.com/f4c402c2f96203d11b00aa41cbfcd427998f3639/chrome/browser/resources/chromeos/login/screen_confirm_password.html
[modify] https://crrev.com/f4c402c2f96203d11b00aa41cbfcd427998f3639/chrome/browser/resources/chromeos/login/screen_fatal_error.css
[modify] https://crrev.com/f4c402c2f96203d11b00aa41cbfcd427998f3639/chrome/browser/resources/chromeos/login/screen_fatal_error.html
[modify] https://crrev.com/f4c402c2f96203d11b00aa41cbfcd427998f3639/chrome/browser/resources/chromeos/login/screen_gaia_signin.css
[modify] https://crrev.com/f4c402c2f96203d11b00aa41cbfcd427998f3639/chrome/browser/resources/chromeos/login/screen_gaia_signin.html
[modify] https://crrev.com/f4c402c2f96203d11b00aa41cbfcd427998f3639/chrome/browser/resources/chromeos/login/screen_password_changed.css
[modify] https://crrev.com/f4c402c2f96203d11b00aa41cbfcd427998f3639/chrome/browser/resources/chromeos/login/screen_password_changed.html

Comment 21 by afakhry@chromium.org, Oct 13 2016

Status: Fixed (was: Started)

Comment 22 by trapti@google.com, Oct 14 2016 

Could repro in M55 PEPPY

M	ChromeOS	Chrome	ARC	Type	Channel
55	8872.8.0	55.0.2883.11	3345311	release	dev

Comment 23 by trapti@google.com, Oct 14 2016

Labels: M-55

Comment 24 by afakhry@chromium.org, Oct 14 2016 

55.0.2883.11 didn't pick the merge yet.

Comment 25 by trapti@google.com, Oct 14 2016 

Not available in today's M55.

Comment 26 by trapti@google.com, Oct 14 2016 

Yes @afakhry you are right.

Comment 27 by trapti@google.com, Oct 17 2016

Status: Verified (was: Fixed)
Verified in Peppy.No unwanted chrome logo seen.

M	ChromeOS	Chrome	ARC	Type	Channel
55	8872.14.0	55.0.2883.17	3356632	release	dev

Comment 28 by trapti@google.com, Oct 17 2016

Status: Fixed (was: Verified)

Comment 29 by trapti@google.com, Oct 19 2016

Status: Verified (was: Fixed)
Verified in M54 Pit device

M	ChromeOS	Chrome	ARC	Type	Channel
54	8743.69.0	54.0.2840.68	3364514	release	beta
Project Member

Comment 30 by bugdroid1@chromium.org, Oct 27 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f4c402c2f96203d11b00aa41cbfcd427998f3639

commit f4c402c2f96203d11b00aa41cbfcd427998f3639
Author: Ahmed Fakhry <afakhry@google.com>
Date: Thu Oct 13 17:09:49 2016

[Merge to M55] Fix regression showing chrome logo in SAML signin title bar

A more specific CSS rule added recently overrides the less specific
rules that hides that logo in various login screens. This CL adds the
class no-logo to those screens for the display manager to hide that logo.

TBR=xiyuan@chromium.org
BUG= 647043 
TEST=Add a new user with a SAML-enabled account and make sure the unwanted
logo doesn't show up.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2412253002
Cr-Commit-Position: refs/heads/master@{#424879}
(cherry picked from commit 74307c9d468b802c64200aa07c96ba01248b3026)

Review URL: https://codereview.chromium.org/2421533002 .

Cr-Commit-Position: refs/branch-heads/2883@{#88}
Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768}

[modify] https://crrev.com/f4c402c2f96203d11b00aa41cbfcd427998f3639/chrome/browser/resources/chromeos/login/oobe_screen_user_image.css
[modify] https://crrev.com/f4c402c2f96203d11b00aa41cbfcd427998f3639/chrome/browser/resources/chromeos/login/oobe_screen_user_image.html
[modify] https://crrev.com/f4c402c2f96203d11b00aa41cbfcd427998f3639/chrome/browser/resources/chromeos/login/screen_confirm_password.css
[modify] https://crrev.com/f4c402c2f96203d11b00aa41cbfcd427998f3639/chrome/browser/resources/chromeos/login/screen_confirm_password.html
[modify] https://crrev.com/f4c402c2f96203d11b00aa41cbfcd427998f3639/chrome/browser/resources/chromeos/login/screen_fatal_error.css
[modify] https://crrev.com/f4c402c2f96203d11b00aa41cbfcd427998f3639/chrome/browser/resources/chromeos/login/screen_fatal_error.html
[modify] https://crrev.com/f4c402c2f96203d11b00aa41cbfcd427998f3639/chrome/browser/resources/chromeos/login/screen_gaia_signin.css
[modify] https://crrev.com/f4c402c2f96203d11b00aa41cbfcd427998f3639/chrome/browser/resources/chromeos/login/screen_gaia_signin.html
[modify] https://crrev.com/f4c402c2f96203d11b00aa41cbfcd427998f3639/chrome/browser/resources/chromeos/login/screen_password_changed.css
[modify] https://crrev.com/f4c402c2f96203d11b00aa41cbfcd427998f3639/chrome/browser/resources/chromeos/login/screen_password_changed.html
Project Member

Comment 31 by bugdroid1@chromium.org, Oct 27 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/31be6fad2470400b02b9bdd6d0a245a3b0670cdc

commit 31be6fad2470400b02b9bdd6d0a245a3b0670cdc
Author: Ahmed Fakhry <afakhry@google.com>
Date: Thu Oct 13 17:02:50 2016

[Merge to M54] Fix regression showing chrome logo in SAML signin title bar

A more specific CSS rule added recently overrides the less specific
rules that hides that logo in various login screens. This CL adds the
class no-logo to those screens for the display manager to hide that logo.

TBR=xiyuan@chromium.org
BUG= 647043 
TEST=Add a new user with a SAML-enabled account and make sure the unwanted
logo doesn't show up.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2412253002
Cr-Commit-Position: refs/heads/master@{#424879}
(cherry picked from commit 74307c9d468b802c64200aa07c96ba01248b3026)

Review URL: https://codereview.chromium.org/2414683004 .

Cr-Commit-Position: refs/branch-heads/2840@{#737}
Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607}

[modify] https://crrev.com/31be6fad2470400b02b9bdd6d0a245a3b0670cdc/chrome/browser/resources/chromeos/login/oobe_screen_user_image.css
[modify] https://crrev.com/31be6fad2470400b02b9bdd6d0a245a3b0670cdc/chrome/browser/resources/chromeos/login/oobe_screen_user_image.html
[modify] https://crrev.com/31be6fad2470400b02b9bdd6d0a245a3b0670cdc/chrome/browser/resources/chromeos/login/screen_confirm_password.css
[modify] https://crrev.com/31be6fad2470400b02b9bdd6d0a245a3b0670cdc/chrome/browser/resources/chromeos/login/screen_confirm_password.html
[modify] https://crrev.com/31be6fad2470400b02b9bdd6d0a245a3b0670cdc/chrome/browser/resources/chromeos/login/screen_fatal_error.css
[modify] https://crrev.com/31be6fad2470400b02b9bdd6d0a245a3b0670cdc/chrome/browser/resources/chromeos/login/screen_fatal_error.html
[modify] https://crrev.com/31be6fad2470400b02b9bdd6d0a245a3b0670cdc/chrome/browser/resources/chromeos/login/screen_gaia_signin.css
[modify] https://crrev.com/31be6fad2470400b02b9bdd6d0a245a3b0670cdc/chrome/browser/resources/chromeos/login/screen_gaia_signin.html
[modify] https://crrev.com/31be6fad2470400b02b9bdd6d0a245a3b0670cdc/chrome/browser/resources/chromeos/login/screen_password_changed.css
[modify] https://crrev.com/31be6fad2470400b02b9bdd6d0a245a3b0670cdc/chrome/browser/resources/chromeos/login/screen_password_changed.html
►

Sign in to add a comment