New issue
Advanced search Search tips

Issue 647031 link

Starred by 0 users

Issue metadata

Status: Fixed
Owner:
Closed: Jan 2017
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

Remove set magnifier state from palette delegate.

Project Member Reported by sammiequon@chromium.org, Sep 14 2016

Issue description

The magnifier flow should be directly from ash/common -> ash instead of ash/common -> chromeos -> ash. 

 
Status: Started (was: Assigned)
Project Member

Comment 2 by bugdroid1@chromium.org, Jan 25 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/238ae7416733aa814efc0218eb627a185953f825

commit 238ae7416733aa814efc0218eb627a185953f825
Author: sammiequon <sammiequon@chromium.org>
Date: Wed Jan 25 18:58:10 2017

chromeos: Removed enable magnifier from palette delegate.

Instead of delegating this call via //ash/common -> //chrome -> //ash, go direct from //ash/common -> //ash.

BUG= 647031 
TEST=none

Review-Url: https://codereview.chromium.org/2642723007
Cr-Commit-Position: refs/heads/master@{#446070}

[modify] https://crrev.com/238ae7416733aa814efc0218eb627a185953f825/ash/aura/wm_shell_aura.cc
[modify] https://crrev.com/238ae7416733aa814efc0218eb627a185953f825/ash/aura/wm_shell_aura.h
[modify] https://crrev.com/238ae7416733aa814efc0218eb627a185953f825/ash/common/palette_delegate.h
[modify] https://crrev.com/238ae7416733aa814efc0218eb627a185953f825/ash/common/system/chromeos/palette/tools/magnifier_mode.cc
[modify] https://crrev.com/238ae7416733aa814efc0218eb627a185953f825/ash/common/test/test_palette_delegate.cc
[modify] https://crrev.com/238ae7416733aa814efc0218eb627a185953f825/ash/common/test/test_palette_delegate.h
[modify] https://crrev.com/238ae7416733aa814efc0218eb627a185953f825/ash/common/wm_shell.h
[modify] https://crrev.com/238ae7416733aa814efc0218eb627a185953f825/ash/mus/bridge/wm_shell_mus.cc
[modify] https://crrev.com/238ae7416733aa814efc0218eb627a185953f825/ash/mus/bridge/wm_shell_mus.h
[modify] https://crrev.com/238ae7416733aa814efc0218eb627a185953f825/ash/shell/shell_delegate_impl.cc
[modify] https://crrev.com/238ae7416733aa814efc0218eb627a185953f825/chrome/browser/ui/ash/palette_delegate_chromeos.cc
[modify] https://crrev.com/238ae7416733aa814efc0218eb627a185953f825/chrome/browser/ui/ash/palette_delegate_chromeos.h

Status: Fixed (was: Started)

Sign in to add a comment