New issue
Advanced search Search tips

Issue 647030 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Dec 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

MD Settings: Blank page when directly navigating to chrome://md-settings/searchEngines

Project Member Reported by dpa...@chromium.org, Sep 14 2016

Issue description

Bisection showed https://chromium.googlesource.com/chromium/src/+log/3839dbc4efacbba65f5d395301f2fecb9c58c1fa..fd2573b67e03eb3cc60ba6b5dbfadf77a08bd331

Suspecting r412896.

@stevenjb: This is yet another regression from the same CL (see also  crbug.com/647023 ,  crbug.com/645444 ). Should we revert?
 
If we revert we loose iron-list's keyboard focus. I would rather fix any issues and move forward. 

Comment 2 by dpa...@chromium.org, Sep 15 2016

Resizing the window makes the list contents appear. I am pretty sure that this is an iron-list behavior which we've encountered before. IIRC if the iron-list is not explicitly sized, then it shows no contents on first load.

Potential fixes
1) Change this back to a dom-repeat instead of iron-list, 
2) Manually fire a 'resize' event,
3) Figure out why the list is not explicitly sized (more info at https://github.com/PolymerElements/iron-list#sizing-iron-list).
Status: Started (was: Untriaged)
If we do (1) we have to work out another option for keyboard focus, plus we loose some of the benefits of iron-list for large lists.

There is supposed to be an explicit call when the list changes already, but in other places we've need to do something more robust, it is probably time to generalize that pattern.

Labels: M-56
Status: Fixed (was: Started)
I believe this is fixed now.

Sign in to add a comment