Infobars cover bottom of omnibox with gray background |
|||||
Issue descriptionChrome 55.0.2860.0 OSX 10.11.6 What steps will reproduce the problem? (1) Run Chrome with a flag that triggers an infobar, e.g. ` --disable-web-security --user-data-dir="/tmp/bla1"` What is the expected output? The infobar has a triangle pointing up onto an otherwise unobstructed infobar. What do you see instead? The height of the triangle also extends the gray color of the infobar onto the omnibox. Please use labels and text to provide additional information.
,
Sep 14 2016
Bisect range: https://chromium.googlesource.com/chromium/src/+log/03ec7e3dd354a3cc0d3357c14ecc21e1085bbbaa..f714d2bd4450811bae2c849b075344eb31814cd6 Suspecting https://chromium.googlesource.com/chromium/src/+/6b1939a26d2839136aeeba2aa0e359fce0c20281 sdy@, could you see if your change caused this?
,
Sep 14 2016
,
Sep 14 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/02a4849687aa7a52e3af8959484f7f8b6b9335cf commit 02a4849687aa7a52e3af8959484f7f8b6b9335cf Author: sdy <sdy@chromium.org> Date: Wed Sep 14 23:09:45 2016 Revert of BackgroundGradientView: -drawBackground: → -drawRect: (patchset #2 id:40001 of https://codereview.chromium.org/2336453002/ ) Reason for revert: AnimatableView inherits from BackgroundGradientView, so a number of other views which *don't* want backgrounds end up inheriting from BackgroundGradientView. This widened the scope of the change beyond what I intended. Original issue's description: > BackgroundGradientView: -drawBackground: → -drawRect: > > BackgroundGradientView had a -drawBackground: method that its clients > were expected to call. This change moves background drawing to > -drawRect: so that the it happens by default. > > Subclasses that did custom drawing already override -drawRect:, but this > removes a couple of overrides that just forwarded to -drawBackground:. > > BUG= 589943 > > Committed: https://crrev.com/6b1939a26d2839136aeeba2aa0e359fce0c20281 > Cr-Commit-Position: refs/heads/master@{#418358} TBR=thakis@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG= 647018 Review-Url: https://codereview.chromium.org/2339143003 Cr-Commit-Position: refs/heads/master@{#418714} [modify] https://crrev.com/02a4849687aa7a52e3af8959484f7f8b6b9335cf/chrome/browser/ui/cocoa/background_gradient_view.h [modify] https://crrev.com/02a4849687aa7a52e3af8959484f7f8b6b9335cf/chrome/browser/ui/cocoa/background_gradient_view.mm [modify] https://crrev.com/02a4849687aa7a52e3af8959484f7f8b6b9335cf/chrome/browser/ui/cocoa/background_gradient_view_unittest.mm [modify] https://crrev.com/02a4849687aa7a52e3af8959484f7f8b6b9335cf/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_toolbar_view.mm [modify] https://crrev.com/02a4849687aa7a52e3af8959484f7f8b6b9335cf/chrome/browser/ui/cocoa/download/download_shelf_view_cocoa.mm [modify] https://crrev.com/02a4849687aa7a52e3af8959484f7f8b6b9335cf/chrome/browser/ui/cocoa/find_bar/find_bar_view_cocoa.mm [modify] https://crrev.com/02a4849687aa7a52e3af8959484f7f8b6b9335cf/chrome/browser/ui/cocoa/tabs/tab_strip_view.mm [modify] https://crrev.com/02a4849687aa7a52e3af8959484f7f8b6b9335cf/chrome/browser/ui/cocoa/toolbar/toolbar_view_cocoa.mm
,
Sep 15 2016
Give me a heads up if you notice anything similar in the next few weeks — I'm working on the downloads bar and might touch other Mac UI code in the process.
,
Sep 15 2016
Issue 647138 has been merged into this issue. |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by lgar...@chromium.org
, Sep 14 2016