New issue
Advanced search Search tips

Issue 647016 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Sep 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

cc_perftest failure on chromium.perf most Android bots at 415925:415955 due to removed .isolate file

Project Member Reported by oysteine@chromium.org, Sep 14 2016

Issue description

Example failing bots:

https://uberchromegw.corp.google.com/i/chromium.perf/builders/Android%20Nexus6%20Perf%20%282%29
https://uberchromegw.corp.google.com/i/chromium.perf/builders/Android%20Nexus6%20Perf%20%282%29
https://uberchromegw.corp.google.com/i/chromium.perf/builders/Android%20Nexus9%20Perf%20%282%29

Link to failing step log: https://uberchromegw.corp.google.com/i/chromium.perf/builders/Android%20Nexus7v2%20Perf%20%282%29/builds/2834/steps/cc_perftests/logs/stdio

First seen: https://uberchromegw.corp.google.com/i/chromium.perf/builders/Android%20Nexus9%20Perf%20%282%29/builds/3085

If the test is disabled, please downgrade to Pri-2.


C  161.748s Main  [CRASH] BspTreePerfTest.BspTreeCubes_2:
C  161.748s Main  [ RUN      ] BspTreePerfTest.BspTreeCubes_2
C  161.748s Main  ../../cc/output/bsp_tree_perftest.cc:63: Failure
C  161.748s Main  Value of: PathService::Get(CCPaths::DIR_TEST_DATA, &test_data_dir)
C  161.748s Main    Actual: false
C  161.748s Main  Expected: true
C  161.748s Main  ../../base/test/values_test_util.cc:71: Failure
C  161.748s Main  Failed
C  161.748s Main  Failed to parse "": Line: 1, column: 1, Unexpected token.
C  161.748s Main  [ CRASHED 

 
Cc: mar...@chromium.org
+maruel: Guessing https://codereview.chromium.org/2257893002 ?

Traceback (most recent call last):
  File "/b/rr/tmpcGJJOq/w/src/build/android/test_runner.py", line 947, in main
    return RunTestsCommand(args)
  File "/b/rr/tmpcGJJOq/w/src/build/android/test_runner.py", line 767, in RunTestsCommand
    return RunTestsInPlatformMode(args)
  File "/b/rr/tmpcGJJOq/w/src/build/android/test_runner.py", line 813, in RunTestsInPlatformMode
    with test_instance_factory.CreateTestInstance(args, infra_error) as test:
  File "/b/rr/tmpcGJJOq/w/src/build/android/pylib/base/test_instance_factory.py", line 16, in CreateTestInstance
    args, isolator.Isolator(), error_func)
  File "/b/rr/tmpcGJJOq/w/src/build/android/pylib/gtest/gtest_test_instance.py", line 260, in __init__
    not isolator.IsIsolateEmpty(args.isolate_file_path)):
  File "/b/rr/tmpcGJJOq/w/src/build/android/pylib/utils/isolator.py", line 59, in IsIsolateEmpty
    with open(isolate_path) as f:
IOError: [Errno 2] No such file or directory: '/b/rr/tmpcGJJOq/w/src/cc/cc_perftests.isolate'
Cc: -mar...@chromium.org dpranke@chromium.org
Owner: mar...@chromium.org
Summary: cc_perftest failure on chromium.perf most Android bots at 415925:415955 due to removed .isolate file (was: cc_perftest failure on chromium.perf most Android bots at 415925:415955)
Readding that specific file in https://codereview.chromium.org/2346463003/ until a proper fix can be done.
Labels: -Pri-1 Pri-2

Comment 4 by mar...@chromium.org, Sep 14 2016

Cc: jbudorick@chromium.org mar...@chromium.org
Owner: ----
+John since this is Android. As an immediate fix reinstating the file is probably the right thing to do but for the long term, the file should eventually be deleted (?) John knows more than me on that side.
Cc: agrieve@chromium.org
Owner: jbudorick@chromium.org
Status: Assigned (was: Untriaged)
Yes, this is concerning and I'm not sure that re-adding the file is even the right thing to do, since it might be out of date.
So, has this step been failing for thirteen days and we're just noticing it now? 
#6 Yes. (╯°□°)╯︵ ┻━┻

Status: Started (was: Assigned)
Project Member

Comment 9 by bugdroid1@chromium.org, Sep 15 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bdd1590930602f1c7a13339331f373885141d443

commit bdd1590930602f1c7a13339331f373885141d443
Author: jbudorick <jbudorick@chromium.org>
Date: Thu Sep 15 21:05:42 2016

[Android] Specify data for cc_perftests.

BUG= 647016 
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel

Review-Url: https://codereview.chromium.org/2340923002
Cr-Commit-Position: refs/heads/master@{#418973}

[modify] https://crrev.com/bdd1590930602f1c7a13339331f373885141d443/cc/BUILD.gn

Project Member

Comment 10 by bugdroid1@chromium.org, Sep 16 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/eb3571503fc7213ea019c09373e7573e232d11ee

commit eb3571503fc7213ea019c09373e7573e232d11ee
Author: jbudorick <jbudorick@chromium.org>
Date: Fri Sep 16 18:09:08 2016

[Android] Use generated wrapper scripts for gtest perf tests.

s.t. cc_perftests can find the device .isolate file we now generate.

BUG= 647016 

Review-Url: https://codereview.chromium.org/2342253002
Cr-Commit-Position: refs/heads/master@{#419214}

[modify] https://crrev.com/eb3571503fc7213ea019c09373e7573e232d11ee/testing/scripts/gtest_perf_test.py

Project Member

Comment 12 by 42576172...@developer.gserviceaccount.com, Sep 16 2016


===== BISECT JOB RESULTS =====
Status: completed


===== TESTED REVISIONS =====
Revision         Exit Code  Std Dev  N   Good?
chromium@415937  1          N/A      20  good
chromium@419176  1          N/A      20  bad

Bisect job ran on: android_s5_perf_bisect
Bug ID: 647016

Test Command: src/build/android/test_runner.py gtest --release -s cc_perftests --verbose
Test Metric: schedule_tasks_bitmap_raster_buffer_provider/32_4
Relative Change: 0.00%
Score: 0

Buildbot stdio: http://build.chromium.org/p/tryserver.chromium.perf/builders/android_s5_perf_bisect/builds/1006
Job details: https://chromeperf.appspot.com/buildbucket_job_status/9001331830630850144


Not what you expected? We'll investigate and get back to you!
  https://chromeperf.appspot.com/bad_bisect?try_job_id=6460142906769408

| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
|  X  | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with component Tests>AutoBisect.  Thank you!
Status: Fixed (was: Started)
Green on N6 starting w/ https://build.chromium.org/p/chromium.perf/builders/Android%20Nexus6%20Perf%20%282%29/builds/3741, should see this step go green on other builders over the course of the afternoon.
Project Member

Comment 15 by 42576172...@developer.gserviceaccount.com, Sep 16 2016


===== BISECT JOB RESULTS =====
Status: completed


===== TESTED REVISIONS =====
Revision         Exit Code  Std Dev  N  Good?
chromium@418955  0          N/A      1  good
chromium@419204  0          N/A      1  bad

Bisect job ran on: linux_perf_bisect
Bug ID: 647016

Test Command: ./src/out/Release/cc_perftests --test-launcher-print-test-stdio=always --verbose
Test Metric: push_properties_to/push_properties_to
Relative Change: 0.00%
Score: 0

Buildbot stdio: http://build.chromium.org/p/tryserver.chromium.perf/builders/linux_perf_bisect/builds/6715
Job details: https://chromeperf.appspot.com/buildbucket_job_status/9001325281147617056


Not what you expected? We'll investigate and get back to you!
  https://chromeperf.appspot.com/bad_bisect?try_job_id=5894930243780608

| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
|  X  | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with component Tests>AutoBisect.  Thank you!

Sign in to add a comment