New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 647015 link

Starred by 1 user

Issue metadata

Status: Archived
Owner: ----
Closed: Sep 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

Add NV12 buffer scanout support from exo to ozone.

Project Member Reported by dcasta...@chromium.org, Sep 14 2016

Issue description

This will allow chrome to import NV12 buffers from exo and do the compositing via GL.

This landed with https://codereview.chromium.org/2296433002 I'm opening this bug to track merging to M54

 
Labels: -Merge-Request-54 Merge-Approved-54
This has baked in canary for a day, and meets the bar for M54.  Approving for merge.
Project Member

Comment 2 by bugdroid1@chromium.org, Sep 14 2016

Labels: -merge-approved-54 merge-merged-2840
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/407cbebbe8e6eb6d6c8429302a4521c5a79ad58a

commit 407cbebbe8e6eb6d6c8429302a4521c5a79ad58a
Author: dcastagna <dcastagna@chromium.org>
Date: Wed Sep 14 21:41:41 2016

Add NV12 buffer scanout support from exo to ozone.

Let exo import NV12 scanout buffers and use them to composite.

BUG= 647015 ,  646148 , b/31159410, b/29625228
NOTRY=true
NOPRESUBMIT=true
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2296433002
Cr-Commit-Position: refs/heads/master@{#418096}
(cherry picked from commit 1e8cdd4dc52fa218459fdc699adc301d36915438)

Review-Url: https://codereview.chromium.org/2347453002
Cr-Commit-Position: refs/branch-heads/2840@{#369}
Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607}

[modify] https://crrev.com/407cbebbe8e6eb6d6c8429302a4521c5a79ad58a/components/exo/buffer.cc
[modify] https://crrev.com/407cbebbe8e6eb6d6c8429302a4521c5a79ad58a/components/exo/wayland/server.cc
[modify] https://crrev.com/407cbebbe8e6eb6d6c8429302a4521c5a79ad58a/gpu/command_buffer/service/feature_info.cc
[modify] https://crrev.com/407cbebbe8e6eb6d6c8429302a4521c5a79ad58a/ui/ozone/gl/gl_image_ozone_native_pixmap.cc

Project Member

Comment 3 by bugdroid1@chromium.org, Sep 22 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a96359efd69b8d28c8bcc0af623a4e69a265d36a

commit a96359efd69b8d28c8bcc0af623a4e69a265d36a
Author: dcastagna <dcastagna@chromium.org>
Date: Thu Sep 22 21:50:58 2016

Revert of Add NV12 buffer scanout support from exo to ozone. (patchset #1 id:1 of https://codereview.chromium.org/2347453002/ )

Reason for revert:
This broke YouTube, Hangout, and camera app on many ChromeOS devices. The video was black. See  http://crbug.com/648528 

Original issue's description:
> Add NV12 buffer scanout support from exo to ozone.
>
> Let exo import NV12 scanout buffers and use them to composite.
>
> BUG= 647015 ,  646148 , b/31159410, b/29625228
> NOTRY=true
> NOPRESUBMIT=true
> CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
>
> Review-Url: https://codereview.chromium.org/2296433002
> Cr-Commit-Position: refs/heads/master@{#418096}
> (cherry picked from commit 1e8cdd4dc52fa218459fdc699adc301d36915438)

TBR=reveman@chromium.org
NOTRY=true
NOPRESUBMIT=true
BUG= 647015 ,  646148 , b/31159410, b/29625228

Review-Url: https://codereview.chromium.org/2360323004
Cr-Commit-Position: refs/branch-heads/2840@{#499}
Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607}

[modify] https://crrev.com/a96359efd69b8d28c8bcc0af623a4e69a265d36a/components/exo/buffer.cc
[modify] https://crrev.com/a96359efd69b8d28c8bcc0af623a4e69a265d36a/components/exo/wayland/server.cc
[modify] https://crrev.com/a96359efd69b8d28c8bcc0af623a4e69a265d36a/gpu/command_buffer/service/feature_info.cc
[modify] https://crrev.com/a96359efd69b8d28c8bcc0af623a4e69a265d36a/ui/ozone/gl/gl_image_ozone_native_pixmap.cc

Comment 4 by dchan@chromium.org, Oct 7 2016

Labels: VerifyIn-55
Project Member

Comment 5 by bugdroid1@chromium.org, Oct 27 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/407cbebbe8e6eb6d6c8429302a4521c5a79ad58a

commit 407cbebbe8e6eb6d6c8429302a4521c5a79ad58a
Author: dcastagna <dcastagna@chromium.org>
Date: Wed Sep 14 21:41:41 2016

Add NV12 buffer scanout support from exo to ozone.

Let exo import NV12 scanout buffers and use them to composite.

BUG= 647015 ,  646148 , b/31159410, b/29625228
NOTRY=true
NOPRESUBMIT=true
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2296433002
Cr-Commit-Position: refs/heads/master@{#418096}
(cherry picked from commit 1e8cdd4dc52fa218459fdc699adc301d36915438)

Review-Url: https://codereview.chromium.org/2347453002
Cr-Commit-Position: refs/branch-heads/2840@{#369}
Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607}

[modify] https://crrev.com/407cbebbe8e6eb6d6c8429302a4521c5a79ad58a/components/exo/buffer.cc
[modify] https://crrev.com/407cbebbe8e6eb6d6c8429302a4521c5a79ad58a/components/exo/wayland/server.cc
[modify] https://crrev.com/407cbebbe8e6eb6d6c8429302a4521c5a79ad58a/gpu/command_buffer/service/feature_info.cc
[modify] https://crrev.com/407cbebbe8e6eb6d6c8429302a4521c5a79ad58a/ui/ozone/gl/gl_image_ozone_native_pixmap.cc

Project Member

Comment 6 by bugdroid1@chromium.org, Oct 27 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a96359efd69b8d28c8bcc0af623a4e69a265d36a

commit a96359efd69b8d28c8bcc0af623a4e69a265d36a
Author: dcastagna <dcastagna@chromium.org>
Date: Thu Sep 22 21:50:58 2016

Revert of Add NV12 buffer scanout support from exo to ozone. (patchset #1 id:1 of https://codereview.chromium.org/2347453002/ )

Reason for revert:
This broke YouTube, Hangout, and camera app on many ChromeOS devices. The video was black. See  http://crbug.com/648528 

Original issue's description:
> Add NV12 buffer scanout support from exo to ozone.
>
> Let exo import NV12 scanout buffers and use them to composite.
>
> BUG= 647015 ,  646148 , b/31159410, b/29625228
> NOTRY=true
> NOPRESUBMIT=true
> CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
>
> Review-Url: https://codereview.chromium.org/2296433002
> Cr-Commit-Position: refs/heads/master@{#418096}
> (cherry picked from commit 1e8cdd4dc52fa218459fdc699adc301d36915438)

TBR=reveman@chromium.org
NOTRY=true
NOPRESUBMIT=true
BUG= 647015 ,  646148 , b/31159410, b/29625228

Review-Url: https://codereview.chromium.org/2360323004
Cr-Commit-Position: refs/branch-heads/2840@{#499}
Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607}

[modify] https://crrev.com/a96359efd69b8d28c8bcc0af623a4e69a265d36a/components/exo/buffer.cc
[modify] https://crrev.com/a96359efd69b8d28c8bcc0af623a4e69a265d36a/components/exo/wayland/server.cc
[modify] https://crrev.com/a96359efd69b8d28c8bcc0af623a4e69a265d36a/gpu/command_buffer/service/feature_info.cc
[modify] https://crrev.com/a96359efd69b8d28c8bcc0af623a4e69a265d36a/ui/ozone/gl/gl_image_ozone_native_pixmap.cc

Comment 7 by dchan@google.com, Nov 19 2016

Labels: VerifyIn-56

Comment 8 by dchan@google.com, Jan 21 2017

Labels: VerifyIn-57

Comment 9 by dchan@google.com, Mar 4 2017

Labels: VerifyIn-58

Comment 10 by dchan@google.com, Apr 17 2017

Labels: VerifyIn-59

Comment 11 by dchan@google.com, May 30 2017

Labels: VerifyIn-60
Labels: VerifyIn-61

Comment 13 by dchan@chromium.org, Oct 14 2017

Status: Archived (was: Fixed)

Sign in to add a comment