Issue metadata
Sign in to add a comment
|
Verbose state is misaligned for RTL locales |
||||||||||||||||||||||||
Issue descriptionChrome 55.0.2860.0 OSX 10.11.6 What steps will reproduce the problem? (1) Launch Chrome in Hebrew or Arabic. (2) Visit google.com What is the expected output? The "Secure" verbose state fits in place. What do you see instead? It overlaps the division bar between the verbose state and the URL. spqchan@, any chance this is a simple fix?
,
Sep 14 2016
,
Oct 19 2016
,
Nov 23 2016
,
Jan 13 2017
+lgrey who it looks like has worked on some RTL stuff for the security chip lately (https://codereview.chromium.org/2563593003, https://codereview.chromium.org/2594543004)
,
Feb 15 2017
ping I know this is not impactful for most users, but verbose states still look super clumsy for RTL users.
,
Feb 15 2017
Sorry for not getting to this sooner, RTL work should go lgrey@ who is currently on a leave. However, he should return in about a week. I'll check with him about this once he returns
,
Feb 21 2017
,
Feb 22 2017
For reference, see attached image for how this looks with the experimental RTL flag on. shrike@ do you think it's worth trying to address this before the RTL work lands?
,
Feb 22 2017
I do. Can we just remove the experimental conditional flag around this bit of code? How do things look with Arabic? The screenshot in c#1 shows some strange clipping along the bottom of the omnibox.
,
Feb 22 2017
Arabic attached. The entire layout of the decoration is flipped under the RTL flag, so I think it might be a little odd without the whole Omnibox being flipped. I could just put another branch in the drawing code to adjust the text rect for the language = RTL, but RTL flag off case
,
Feb 22 2017
OK. My main concern is that what we have currently looks unprofessional. If we don't want to flip the RTL flag for just the chip I would like us to fix the visual bugs in c#1.
,
Feb 22 2017
With https://codereview.chromium.org/2710043002 applied:
,
Feb 23 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2f8ae52186762d312b8fbbf44043ced4ef6a333c commit 2f8ae52186762d312b8fbbf44043ced4ef6a333c Author: lgrey <lgrey@chromium.org> Date: Thu Feb 23 15:51:04 2017 [Mac] Ensure security state label doesn't overlap divider See bug for screenshots BUG= 647014 Review-Url: https://codereview.chromium.org/2710043002 Cr-Commit-Position: refs/heads/master@{#452499} [modify] https://crrev.com/2f8ae52186762d312b8fbbf44043ced4ef6a333c/chrome/browser/ui/cocoa/location_bar/security_state_bubble_decoration.mm
,
Feb 27 2017
Confirmed on Canary |
|||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||
Comment 1 by lgar...@chromium.org
, Sep 14 2016213 KB
213 KB View Download
233 KB
233 KB View Download