New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 647005 link

Starred by 1 user
Status: Fixed
Owner:
msw@chromium.org
Closed: Feb 2018
Cc:
mahmadi@chromium.org
█ n...@chromium.org
█ mlerman@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

Remove UserManagerView, etc. from the Chrome OS build.

Project Member Reported by msw@chromium.org, Sep 14 2016 
Remove UserManagerView, etc. from the Chrome OS build.

UserManagerView is not used on Chrome OS / Ash, and should not be built there.
  chrome/browser/ui/views/profiles/user_manager_view.h|cc

This is potentially related to some Metro cleanup, like  Issue 558054 .

Comment 1 by msw@chromium.org, Sep 14 2016

Components: UI>Browser>Profiles

Comment 2 by abodenha@chromium.org, Sep 15 2016

Owner: msw@chromium.org
Status: Assigned (was: Untriaged)
Project Member

Comment 3 by bugdroid1@chromium.org, Feb 8 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0fc30aa4f23513c69111a03583cdb340bfb97216

commit 0fc30aa4f23513c69111a03583cdb340bfb97216
Author: Mike Wasserman <msw@chromium.org>
Date: Thu Feb 08 18:43:20 2018

Exclude UserManager[View] and ProfileHelper from Chrome OS

This code is not used on Chrome OS, and shouldn't be built.
Guard use in cross-platform files with preprocessor checks.

Bug:  647005 
Test: Builders pass, no user management flows broken.
Change-Id: I2a82ba1b077504b9351233b29adfe5128c52a4d6
Reviewed-on: https://chromium-review.googlesource.com/907369
Commit-Queue: Michael Wasserman <msw@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#535458}
[modify] https://crrev.com/0fc30aa4f23513c69111a03583cdb340bfb97216/chrome/browser/browser_process_impl.cc
[modify] https://crrev.com/0fc30aa4f23513c69111a03583cdb340bfb97216/chrome/browser/lifetime/application_lifetime.cc
[modify] https://crrev.com/0fc30aa4f23513c69111a03583cdb340bfb97216/chrome/browser/profiles/avatar_menu.cc
[modify] https://crrev.com/0fc30aa4f23513c69111a03583cdb340bfb97216/chrome/browser/profiles/profile_window.cc
[modify] https://crrev.com/0fc30aa4f23513c69111a03583cdb340bfb97216/chrome/browser/signin/chrome_signin_client.cc
[modify] https://crrev.com/0fc30aa4f23513c69111a03583cdb340bfb97216/chrome/browser/ui/BUILD.gn
[modify] https://crrev.com/0fc30aa4f23513c69111a03583cdb340bfb97216/chrome/browser/ui/app_list/profile_loader.cc
[modify] https://crrev.com/0fc30aa4f23513c69111a03583cdb340bfb97216/chrome/browser/ui/extensions/extension_enable_flow.cc
[modify] https://crrev.com/0fc30aa4f23513c69111a03583cdb340bfb97216/chrome/browser/ui/startup/startup_browser_creator.cc
[modify] https://crrev.com/0fc30aa4f23513c69111a03583cdb340bfb97216/chrome/browser/ui/views/task_manager_view.cc
[modify] https://crrev.com/0fc30aa4f23513c69111a03583cdb340bfb97216/chrome/browser/ui/webui/settings/people_handler.cc
[modify] https://crrev.com/0fc30aa4f23513c69111a03583cdb340bfb97216/chrome/browser/ui/webui/settings/profile_info_handler.cc
[modify] https://crrev.com/0fc30aa4f23513c69111a03583cdb340bfb97216/chrome/browser/ui/webui/signin/login_ui_service.cc

Comment 4 by msw@chromium.org, Feb 8 2018

Status: Fixed (was: Assigned)
►

Sign in to add a comment