[scroll anchoring] interactions with extension settings page "developer mode" checkbox |
||
Issue descriptionWhat steps will reproduce the problem? 1. Enable scroll anchoring 1. Go to chrome://extensions/ with some extensions installed (e.g. corp account) 2. Scroll down or to the right a tiny bit (so you are not at 0,0) 3. Click the "developer mode" checkbox What is the expected result? A row of buttons appears below the header. What happens instead of that? Scroll anchoring anchors to the first item in the extension list, which is pushed down by the buttons. (The header is skipped due to being position:fixed.) The scroll anchoring adjustment causes the buttons to be offscreen. (This breaks AutoScrollExtensionSettingsWebUITest.testAutoScroll in issue 597479 .)
,
Sep 14 2016
I agree it's the right thing if you've scrolled down by more than the height of the buttons. It's less obviously right if you're only scrolled to the right, or if you've scrolled down by just a few pixels.
,
Sep 14 2016
Right. I think we shouldn't make adjustments in the direction of the zero scroll position. The latter sounds like the fundamental problem of anchoring where the change happens within the viewport but above the anchor element.
,
Sep 14 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/101eea619734b9b9362b5557f2999317ea743a0b commit 101eea619734b9b9362b5557f2999317ea743a0b Author: skobes <skobes@chromium.org> Date: Wed Sep 14 21:29:41 2016 Workaround for scroll anchoring issue with AutoScrollExtensionSettingsWebUITest. BUG= 646977 Review-Url: https://codereview.chromium.org/2343683002 Cr-Commit-Position: refs/heads/master@{#418680} [modify] https://crrev.com/101eea619734b9b9362b5557f2999317ea743a0b/chrome/browser/ui/webui/extensions/extension_settings_browsertest.js
,
Sep 15 2016
Hm...that's interesting. I agree with Yash that the vertical scrolling case seems like the right behavior, but that we shouldn't scroll anchor vertically if you're only horizontally scrolled. I wonder, should we actually just only ever scroll anchor vertically?
,
Sep 15 2016
Yeah it's probably fine to anchor only on the axis of the writing-mode.
,
Sep 22 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f347a360168703ac909eee252afbdd79849354ca commit f347a360168703ac909eee252afbdd79849354ca Author: skobes <skobes@chromium.org> Date: Thu Sep 22 14:12:26 2016 Only anchor along the scroller's block layout axis. Also update corner selection to use the style of the scroller, not that of the anchor node, for consistency. BUG= 646977 Review-Url: https://codereview.chromium.org/2360833002 Cr-Commit-Position: refs/heads/master@{#420329} [modify] https://crrev.com/f347a360168703ac909eee252afbdd79849354ca/chrome/browser/ui/webui/extensions/extension_settings_browsertest.js [modify] https://crrev.com/f347a360168703ac909eee252afbdd79849354ca/third_party/WebKit/Source/core/layout/ScrollAnchor.cpp [modify] https://crrev.com/f347a360168703ac909eee252afbdd79849354ca/third_party/WebKit/Source/core/layout/ScrollAnchorTest.cpp [modify] https://crrev.com/f347a360168703ac909eee252afbdd79849354ca/third_party/WebKit/Source/web/tests/VisualViewportTest.cpp
,
Sep 22 2016
|
||
►
Sign in to add a comment |
||
Comment 1 by ymalik@chromium.org
, Sep 14 2016