clock looks weird when shelf is vertically aligned. |
||||||
Issue descriptionVersion: M54 OS: Chrome OS What steps will reproduce the problem? (1) set ash-md to experimental (2) change shelf alignment to vertically aligned What is the expected output? The time can be properly seen. What do you see instead? The time cannot be properly seen. (refer to the picture) Please use labels and text to provide additional information.
,
Oct 5 2016
,
Oct 5 2016
I fixed it while working on updating spacing between items in the system tray area.
,
Oct 6 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d73de42d6da01d9c7c24c0b6573e89ce6bab3a3f commit d73de42d6da01d9c7c24c0b6573e89ce6bab3a3f Author: yiyix <yiyix@chromium.org> Date: Thu Oct 06 01:00:24 2016 Update spacing between material design icons in the system tray Updated spacing between material design icons to 6dp; adjusted the spacing between the hours and minutes when the clock is aligned vertically. TEST=MANUAL - Measured the distance between tray items using gimp while setting the shelf alignment to bottom, right and left. BUG=630296, 646975 Review-Url: https://codereview.chromium.org/2390003002 Cr-Commit-Position: refs/heads/master@{#423366} [modify] https://crrev.com/d73de42d6da01d9c7c24c0b6573e89ce6bab3a3f/ash/common/system/date/date_view.cc [modify] https://crrev.com/d73de42d6da01d9c7c24c0b6573e89ce6bab3a3f/ash/common/system/tray/tray_constants.cc [modify] https://crrev.com/d73de42d6da01d9c7c24c0b6573e89ce6bab3a3f/ash/common/system/tray/tray_constants.h [modify] https://crrev.com/d73de42d6da01d9c7c24c0b6573e89ce6bab3a3f/ash/common/system/tray/tray_utils.cc [modify] https://crrev.com/d73de42d6da01d9c7c24c0b6573e89ce6bab3a3f/ash/common/system/user/tray_user.cc
,
Oct 7 2016
Yi, does the CL in #4 fix this issue?
,
Oct 7 2016
Verified fixed on ToT.
,
Oct 19 2016
Verified on ChromeOS 8872.16.0, 55.0.2883.20
,
Oct 27 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d73de42d6da01d9c7c24c0b6573e89ce6bab3a3f commit d73de42d6da01d9c7c24c0b6573e89ce6bab3a3f Author: yiyix <yiyix@chromium.org> Date: Thu Oct 06 01:00:24 2016 Update spacing between material design icons in the system tray Updated spacing between material design icons to 6dp; adjusted the spacing between the hours and minutes when the clock is aligned vertically. TEST=MANUAL - Measured the distance between tray items using gimp while setting the shelf alignment to bottom, right and left. BUG=630296, 646975 Review-Url: https://codereview.chromium.org/2390003002 Cr-Commit-Position: refs/heads/master@{#423366} [modify] https://crrev.com/d73de42d6da01d9c7c24c0b6573e89ce6bab3a3f/ash/common/system/date/date_view.cc [modify] https://crrev.com/d73de42d6da01d9c7c24c0b6573e89ce6bab3a3f/ash/common/system/tray/tray_constants.cc [modify] https://crrev.com/d73de42d6da01d9c7c24c0b6573e89ce6bab3a3f/ash/common/system/tray/tray_constants.h [modify] https://crrev.com/d73de42d6da01d9c7c24c0b6573e89ce6bab3a3f/ash/common/system/tray/tray_utils.cc [modify] https://crrev.com/d73de42d6da01d9c7c24c0b6573e89ce6bab3a3f/ash/common/system/user/tray_user.cc
,
Nov 4 2016
[Automated comment] removing mislabelled merge-merged-2840 |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by tdander...@chromium.org
, Sep 14 2016Status: Available (was: Untriaged)