New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 646973 link

Starred by 1 user
Status: Fixed
Owner:
█ junov@chromium.org
Last visit > 30 days ago
Closed: Sep 2016
Cc:
xidac...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Flaky layout tests under virtual/gpu/fast/canvas

Project Member Reported by junov@chromium.org, Sep 14 2016 
Test failures observed on first try, pass on second try:

[356/509] virtual/gpu/fast/canvas/canvas-pattern-behaviour.html failed unexpectedly (text diff)       
[357/509] virtual/gpu/fast/canvas/canvas-pattern-modify.html failed unexpectedly (text diff)
[358/509] virtual/gpu/fast/canvas/canvas-pattern-no-repeat-with-transformations.html failed unexpectedly (image diff)
[359/509] virtual/gpu/fast/canvas/canvas-pattern-set-transform.html failed unexpectedly (text diff)
[360/509] virtual/gpu/fast/canvas/canvas-pattern-transform.html failed unexpectedly (text diff)
[381/509] virtual/gpu/fast/canvas/canvas-shadow-source-in.html failed unexpectedly (image diff)
[408/509] virtual/gpu/fast/canvas/canvas-to-canvas.html failed unexpectedly (text diff)
[442/509] virtual/gpu/fast/canvas/canvasDrawingIntoSelf.html failed unexpectedly (reference mismatch)
[446/509] virtual/gpu/fast/canvas/downsample-quality.html failed unexpectedly (image diff)
[455/509] virtual/gpu/fast/canvas/drawImage-with-globalAlpha.html failed unexpectedly (image diff)
[456/509] virtual/gpu/fast/canvas/drawImage-with-negative-source-destination.html failed unexpectedly (text diff)
[458/509] virtual/gpu/fast/canvas/drawImage.html failed unexpectedly (reference mismatch)
[477/509] virtual/gpu/fast/canvas/pattern-with-transform.html failed unexpectedly (text diff)
[479/509] virtual/gpu/fast/canvas/pixelated-canvas.html failed unexpectedly (image diff)
[486/509] virtual/gpu/fast/canvas/rendering-contexts-back-references.html failed unexpectedly (asserts failed)

Xidachen@ isolated the culprit CL to be this one:
https://codereview.chromium.org/2300633004/
Project Member

Comment 1 by bugdroid1@chromium.org, Sep 15 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bb27517d08d74205ceaddc98cfae311916883d09

commit bb27517d08d74205ceaddc98cfae311916883d09
Author: junov <junov@chromium.org>
Date: Thu Sep 15 21:58:43 2016

Make SharedGpuContext recover automatically after a context loss

The lack of gpu context recovery was causing some layout tests
to be flaky. After running the test
virtual/gpu/fast/canvas/canvas-lost-gpu-context.html all subsequent
gpu tests run in the same instance of content_shell would fail.

BUG= 646973 

Review-Url: https://codereview.chromium.org/2335223004
Cr-Commit-Position: refs/heads/master@{#418998}

[modify] https://crrev.com/bb27517d08d74205ceaddc98cfae311916883d09/third_party/WebKit/Source/platform/BUILD.gn
[modify] https://crrev.com/bb27517d08d74205ceaddc98cfae311916883d09/third_party/WebKit/Source/platform/graphics/gpu/SharedGpuContext.cpp
[modify] https://crrev.com/bb27517d08d74205ceaddc98cfae311916883d09/third_party/WebKit/Source/platform/graphics/gpu/SharedGpuContext.h
[add] https://crrev.com/bb27517d08d74205ceaddc98cfae311916883d09/third_party/WebKit/Source/platform/graphics/gpu/SharedGpuContextTest.cpp

Comment 2 by xidac...@chromium.org, Sep 16 2016

Status: Fixed (was: Assigned)
►

Sign in to add a comment