New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 646938 link

Starred by 4 users

Issue metadata

Status: Fixed
Owner:
Closed: May 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Mac
Pri: 2
Type: Bug-Regression



Sign in to add a comment

Fix and re-enable blink_perf.pywebsocket

Project Member Reported by oysteine@chromium.org, Sep 14 2016

Issue description

Revision range first seen:
Link to failing step log: https://uberchromegw.corp.google.com/i/chromium.perf/builders/Linux%20Perf%20%281%29/builds/13233/steps/blink_perf.pywebsocket/logs/stdio


If the test is disabled, please downgrade to Pri-2.

 
[2016-09-13 23:14:25,159] [ERROR] __main__.WebSocketServer: Exception in processing request from: ('::ffff:127.0.0.1', 39832, 0, 0)
Traceback (most recent call last):
  File "/usr/lib/python2.7/SocketServer.py", line 593, in process_request_thread
    self.finish_request(request, client_address)
  File "/usr/lib/python2.7/SocketServer.py", line 334, in finish_request
    self.RequestHandlerClass(request, client_address, self)
  File "/b/c/b/Linux_Perf__1_/src/third_party/pywebsocket/src/mod_pywebsocket/standalone.py", line 695, in __init__
    self, request, client_address, server)
  File "/usr/lib/python2.7/SocketServer.py", line 651, in __init__
    self.finish()
  File "/usr/lib/python2.7/SocketServer.py", line 710, in finish
    self.wfile.close()
  File "/usr/lib/python2.7/socket.py", line 279, in close
    self.flush()
  File "/usr/lib/python2.7/socket.py", line 303, in flush
    self._sock.sendall(view[write_offset:write_offset+buffer_size])
error: [Errno 32] Broken pipe
Project Member

Comment 4 by 42576172...@developer.gserviceaccount.com, Sep 14 2016

Bisect failed: http://build.chromium.org/p/tryserver.chromium.perf/builders/linux_perf_bisect/builds/6711
Failure reason: the build has failed due to infrastructure failure.

The bot has recovered.
This seems more flaky than outright broken. Here's a snippet of the failure:

       OK ] XHR-receive-blob-worker-sync-verify.html (20124 ms)
[2016-09-16 03:11:56,146] [ERROR] __main__.WebSocketServer: Exception in processing request from: ('::ffff:127.0.0.1', 51220, 0, 0)
Traceback (most recent call last):
  File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/SocketServer.py", line 599, in process_request_thread
    self.finish_request(request, client_address)
  File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/SocketServer.py", line 334, in finish_request
    self.RequestHandlerClass(request, client_address, self)
  File "/b/c/b/Mac_10_11_Perf__1_/src/third_party/pywebsocket/src/mod_pywebsocket/standalone.py", line 695, in __init__
    self, request, client_address, server)
  File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/SocketServer.py", line 657, in __init__
    self.finish()
  File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/SocketServer.py", line 716, in finish
    self.wfile.close()
  File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/socket.py", line 283, in close
    self.flush()
  File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/socket.py", line 307, in flush
    self._sock.sendall(view[write_offset:write_offset+buffer_size])
error: [Errno 32] Broken pipe
Project Member

Comment 10 by 42576172...@developer.gserviceaccount.com, Sep 16 2016

Bisect failed: http://build.chromium.org/p/tryserver.chromium.perf/builders/android_s5_perf_bisect/builds/1005
Failure reason: the build has failed due to infrastructure failure.

Project Member

Comment 11 by 42576172...@developer.gserviceaccount.com, Sep 16 2016

Bisect failed: http://build.chromium.org/p/tryserver.chromium.perf/builders/android_s5_perf_bisect/builds/1007
Failure reason: the build has failed due to infrastructure failure.

Project Member

Comment 12 by 42576172...@developer.gserviceaccount.com, Sep 16 2016

Bisect failed: http://build.chromium.org/p/tryserver.chromium.perf/builders/mac_10_11_perf_bisect/builds/913
Failure reason: the build has failed due to infrastructure failure.

Labels: OS-Android OS-Linux OS-Mac
The bisect cannot locate the first revision to break like this.. strangely the test runs for over one hour without output hence the breakages in #10 to #12

Pinging the owners of the test to see if they have any insight.
Project Member

Comment 14 by bugdroid1@chromium.org, Sep 19 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9095d34f8382f06cf36acfb3f57745cf8be50b18

commit 9095d34f8382f06cf36acfb3f57745cf8be50b18
Author: robertocn <robertocn@chromium.org>
Date: Mon Sep 19 12:27:55 2016

Disabling blink_perf.pywebsocket due to flake.

BUG= 646938 
TBR=nednguyen,yhirano@chromium.org

Review-Url: https://codereview.chromium.org/2347413002
Cr-Commit-Position: refs/heads/master@{#419436}

[modify] https://crrev.com/9095d34f8382f06cf36acfb3f57745cf8be50b18/tools/perf/benchmarks/blink_perf.py

Summary: Fix and re-enable blink_perf.pywebsocket (was: blink_perf.pywebsocket failure on chromium.perf non-Windows at 418457:418488)
Labels: -Pri-1 Pri-2
Cc: benjhayden@chromium.org
 Issue 649976  has been merged into this issue.
 Issue 650062  has been merged into this issue.
 Issue 650061  has been merged into this issue.
 Issue 650054  has been merged into this issue.
 Issue 650053  has been merged into this issue.
 Issue 650050  has been merged into this issue.
 Issue 650046  has been merged into this issue.
 Issue 650016  has been merged into this issue.
Issue 650004 has been merged into this issue.
 Issue 650003  has been merged into this issue.
 Issue 641087  has been merged into this issue.
Components: Blink>Network
Status: Available (was: Untriaged)
Owner: ricea@chromium.org
Status: Assigned (was: Available)
Please close this once the removal is complete.

Comment 32 by ricea@chromium.org, May 22 2017

Status: Fixed (was: Assigned)
Fixed by deleting the benchmarks.

Sign in to add a comment