Make servo verify failures advisory
Reported by
jrbarnette@chromium.org,
Sep 14 2016
|
||||
Issue description
Currently, when a ServoHost fails verify(), it will return
the Servo object as None, to prevent the servo from being used.
That's not always the best thing to do. At minimum, it can
happen that a servo that fails the 'pwr_button' or 'lid_open'
tests is usable, at least for the reset repair action.
There are at least two ways to do better:
1) Keep track of which servo verifiers failed, and use that
information to decide which repair actions to try.
2) Just don't block using the servo merely because verify()
failed.
The recommendation here is for option 2). It's probably
easier, and probably good enough.
,
Feb 6 2017
Downgrading. This issue isn't currently causing pain (that I'm aware of). I note that realistically, ignoring failures from the "pwr_button" verifier is probably not a good idea (because it commonly indicates a disconnected ribbon cable), so only the "lid_open" test is a likely candidate for "not a fatal failure".
,
Feb 21 2018
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue. Sorry for the inconvenience if the bug really should have been left as Available. If you change it back, also remove the "Hotlist-Recharge-Cold" label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
May 15 2018
|
||||
►
Sign in to add a comment |
||||
Comment 1 by autumn@chromium.org
, Sep 20 2016