New issue
Advanced search Search tips

Issue 646926 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jan 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug

Blocking:
issue 600815



Sign in to add a comment

event dispatcher does not work correctly in high-dpi

Project Member Reported by riajiang@chromium.org, Sep 14 2016

Issue description

When running in mash mode with force-device-scale-factor=2, events are being dispatched to the wrong position.

 
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 11 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8ee02a33407c0456fcd4dd4ee919f66c12a88669

commit 8ee02a33407c0456fcd4dd4ee919f66c12a88669
Author: riajiang <riajiang@chromium.org>
Date: Tue Oct 11 20:57:40 2016

Fix event dispatching and window resizing in high-dpi mode.

TODO:
1. Currently there are no hover effects for backwards, forwards, refresh
and app menu button.
2. Minimize, Maximize and Close buttons are not receiving events in the
bottom half area, which will be fixed in another CL by changing client_area.

BUG= 646926 ,  646927 
TEST=manual (with --force-device-scale-factor=2)

Review-Url: https://codereview.chromium.org/2341483004
Cr-Commit-Position: refs/heads/master@{#424542}

[modify] https://crrev.com/8ee02a33407c0456fcd4dd4ee919f66c12a88669/ui/aura/window_event_dispatcher.cc
[modify] https://crrev.com/8ee02a33407c0456fcd4dd4ee919f66c12a88669/ui/aura/window_event_dispatcher.h
[modify] https://crrev.com/8ee02a33407c0456fcd4dd4ee919f66c12a88669/ui/views/mus/window_tree_host_mus.cc
[modify] https://crrev.com/8ee02a33407c0456fcd4dd4ee919f66c12a88669/ui/views/widget/desktop_aura/desktop_window_tree_host_x11.cc

Project Member

Comment 2 by bugdroid1@chromium.org, Nov 17 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/075c4290cdfc0cfca43c2114bce282ea9389e6fc

commit 075c4290cdfc0cfca43c2114bce282ea9389e6fc
Author: riajiang <riajiang@chromium.org>
Date: Thu Nov 17 23:13:59 2016

Scale client area, hit test mask and bounds by device_scale_factor.

Fixes the second TODO of CL https://codereview.chromium.org/2341483004/.

TODO:
1. Chrome browser doesn't show up with window bounds scaling.
2. Also scale window bounds in aura::mus::WindowTreeClient once window
bounds work correctly.

BUG= 646926 
TEST=manual (with --force-device-scale-factor=2)

Review-Url: https://codereview.chromium.org/2447303002
Cr-Commit-Position: refs/heads/master@{#433009}

[modify] https://crrev.com/075c4290cdfc0cfca43c2114bce282ea9389e6fc/services/ui/demo/mus_demo.cc
[modify] https://crrev.com/075c4290cdfc0cfca43c2114bce282ea9389e6fc/services/ui/demo/mus_demo.h
[modify] https://crrev.com/075c4290cdfc0cfca43c2114bce282ea9389e6fc/services/ui/public/cpp/tests/BUILD.gn
[modify] https://crrev.com/075c4290cdfc0cfca43c2114bce282ea9389e6fc/services/ui/public/cpp/tests/window_server_test_base.cc
[modify] https://crrev.com/075c4290cdfc0cfca43c2114bce282ea9389e6fc/services/ui/public/cpp/tests/window_server_test_base.h
[modify] https://crrev.com/075c4290cdfc0cfca43c2114bce282ea9389e6fc/services/ui/public/cpp/tests/window_tree_client_unittest.cc
[modify] https://crrev.com/075c4290cdfc0cfca43c2114bce282ea9389e6fc/services/ui/public/cpp/window_tree_client.cc
[modify] https://crrev.com/075c4290cdfc0cfca43c2114bce282ea9389e6fc/services/ui/test_wm/BUILD.gn
[modify] https://crrev.com/075c4290cdfc0cfca43c2114bce282ea9389e6fc/services/ui/test_wm/test_wm.cc
[modify] https://crrev.com/075c4290cdfc0cfca43c2114bce282ea9389e6fc/ui/aura/mus/window_tree_client.cc
[modify] https://crrev.com/075c4290cdfc0cfca43c2114bce282ea9389e6fc/ui/gfx/geometry/dip_util.cc
[modify] https://crrev.com/075c4290cdfc0cfca43c2114bce282ea9389e6fc/ui/gfx/geometry/dip_util.h

Cc: rbasuvula@chromium.org
Labels: Needs-Feedback
Tested in chrome dev #56.0.2924.3 on Windows 10 & Mac 10.12 and observed that

1.Mouse hover effects for backwards, forwards, refresh and app menu button - Working fine.

Could anyone please check and let us know the expected behavior of the issue and please provide any other test cases required to proceed with.

A screen cast is attached which was when performed on Mac OS.

Thank you! 


646926.mp4
2.7 MB View Download
Event dispatching is working fine in non-mash mode (without --mash flag). All these changes are not being used in branch 56.
Labels: -Needs-Feedback M-56 OS-Linux
Great , thanks for the update. Please request a merge to M56 branch when needed.
Labels: -M-56
-label M-56 as it's not going to be on M56.
Labels: Proj-Mustash-Milestone-Tadpole Pri-1
Components: Internals>MUS
Status: Fixed (was: Started)
Components: -Internals>MUS Internals>Services>WindowService

Sign in to add a comment