New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 646906 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Android MediaRouter only (left Chro...
Closed: Sep 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 1
Type: Bug

Blocking:
issue 497735



Sign in to add a comment

Unassociate MediaSession from media players

Project Member Reported by zqzh...@chromium.org, Sep 14 2016

Issue description

Since MediaSession is no longer associated with media elements, we should decouple them both in Blink and content.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Sep 22 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f85a8f824b6910c68aebca56f3dcac00bc473147

commit f85a8f824b6910c68aebca56f3dcac00bc473147
Author: zqzhang <zqzhang@chromium.org>
Date: Thu Sep 22 19:12:09 2016

Unassociating MediaSession from media players (in blink & content)

Since media elements no long joins MediaSession, we should
decouple them.

This is part of a greater effort of making MediaSession API
implementation in sync with the spec.
https://docs.google.com/a/google.com/document/d/1RNaWRpEDCGfDI5HEmMYxqA2QaD2eAOuhTlmuKoWMA8Y/edit?usp=sharing

BUG= 646906 

Review-Url: https://codereview.chromium.org/2338223003
Cr-Commit-Position: refs/heads/master@{#420418}

[modify] https://crrev.com/f85a8f824b6910c68aebca56f3dcac00bc473147/chrome/browser/media/android/remote/remote_media_player_bridge.cc
[modify] https://crrev.com/f85a8f824b6910c68aebca56f3dcac00bc473147/content/browser/media/android/browser_media_player_manager.cc
[modify] https://crrev.com/f85a8f824b6910c68aebca56f3dcac00bc473147/content/browser/media/android/media_player_renderer.cc
[modify] https://crrev.com/f85a8f824b6910c68aebca56f3dcac00bc473147/content/common/media/media_player_messages_android.h
[modify] https://crrev.com/f85a8f824b6910c68aebca56f3dcac00bc473147/content/renderer/media/android/renderer_media_player_manager.cc
[modify] https://crrev.com/f85a8f824b6910c68aebca56f3dcac00bc473147/content/renderer/media/android/renderer_media_player_manager.h
[modify] https://crrev.com/f85a8f824b6910c68aebca56f3dcac00bc473147/content/renderer/media/android/webmediaplayer_android.cc
[modify] https://crrev.com/f85a8f824b6910c68aebca56f3dcac00bc473147/content/renderer/media/android/webmediaplayer_android.h
[modify] https://crrev.com/f85a8f824b6910c68aebca56f3dcac00bc473147/content/renderer/render_frame_impl.cc
[modify] https://crrev.com/f85a8f824b6910c68aebca56f3dcac00bc473147/content/renderer/render_frame_impl.h
[modify] https://crrev.com/f85a8f824b6910c68aebca56f3dcac00bc473147/media/base/android/media_player_android.cc
[modify] https://crrev.com/f85a8f824b6910c68aebca56f3dcac00bc473147/media/base/android/media_player_android.h
[modify] https://crrev.com/f85a8f824b6910c68aebca56f3dcac00bc473147/media/base/android/media_player_bridge.cc
[modify] https://crrev.com/f85a8f824b6910c68aebca56f3dcac00bc473147/media/base/android/media_player_bridge.h
[modify] https://crrev.com/f85a8f824b6910c68aebca56f3dcac00bc473147/media/base/android/media_player_bridge_unittest.cc
[modify] https://crrev.com/f85a8f824b6910c68aebca56f3dcac00bc473147/media/base/android/media_source_player.cc
[modify] https://crrev.com/f85a8f824b6910c68aebca56f3dcac00bc473147/media/base/android/media_source_player.h
[modify] https://crrev.com/f85a8f824b6910c68aebca56f3dcac00bc473147/media/base/android/media_source_player_unittest.cc
[modify] https://crrev.com/f85a8f824b6910c68aebca56f3dcac00bc473147/media/blink/renderer_media_player_interface.h
[modify] https://crrev.com/f85a8f824b6910c68aebca56f3dcac00bc473147/media/blink/webmediaplayer_cast_android.cc
[modify] https://crrev.com/f85a8f824b6910c68aebca56f3dcac00bc473147/media/blink/webmediaplayer_impl_unittest.cc
[modify] https://crrev.com/f85a8f824b6910c68aebca56f3dcac00bc473147/media/blink/webmediaplayer_params.cc
[modify] https://crrev.com/f85a8f824b6910c68aebca56f3dcac00bc473147/media/blink/webmediaplayer_params.h
[modify] https://crrev.com/f85a8f824b6910c68aebca56f3dcac00bc473147/third_party/WebKit/Source/modules/mediasession/BUILD.gn
[delete] https://crrev.com/b8de5d6342b868aa86568f82cec143fd5b304384/third_party/WebKit/Source/modules/mediasession/HTMLMediaElementMediaSession.cpp
[delete] https://crrev.com/b8de5d6342b868aa86568f82cec143fd5b304384/third_party/WebKit/Source/modules/mediasession/HTMLMediaElementMediaSession.h
[delete] https://crrev.com/b8de5d6342b868aa86568f82cec143fd5b304384/third_party/WebKit/Source/modules/mediasession/HTMLMediaElementMediaSession.idl
[modify] https://crrev.com/f85a8f824b6910c68aebca56f3dcac00bc473147/third_party/WebKit/Source/modules/modules_idl_files.gni
[modify] https://crrev.com/f85a8f824b6910c68aebca56f3dcac00bc473147/third_party/WebKit/Source/web/FrameLoaderClientImpl.cpp
[modify] https://crrev.com/f85a8f824b6910c68aebca56f3dcac00bc473147/third_party/WebKit/public/web/WebFrameClient.h

Status: Fixed (was: Assigned)

Sign in to add a comment