New issue
Advanced search Search tips

Issue 646904 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Sep 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Feature



Sign in to add a comment

Mechanical refactoring of BrowserProcessImpl::component_updater()

Project Member Reported by sorin@chromium.org, Sep 14 2016

Issue description

Remove the nested if statements and simplify the ownership transfer of the object.

 

Comment 1 by sorin@chromium.org, Sep 14 2016

Components: Internals>Installer>Components
Project Member

Comment 2 by bugdroid1@chromium.org, Sep 15 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7a43e83784853f6d73842e9ec60feab67daed8b8

commit 7a43e83784853f6d73842e9ec60feab67daed8b8
Author: sorin <sorin@chromium.org>
Date: Thu Sep 15 21:29:29 2016

Mechanical refactoring of BrowserProcessImpl::component_updater().

Bring the code to C++11 standard and streamline the execution path inside the function.

BUG= 646904 

Review-Url: https://codereview.chromium.org/2340003002
Cr-Commit-Position: refs/heads/master@{#418982}

[modify] https://crrev.com/7a43e83784853f6d73842e9ec60feab67daed8b8/chrome/browser/browser_process_impl.cc

Comment 3 by sorin@chromium.org, Sep 16 2016

Status: Fixed (was: Started)

Sign in to add a comment