[Offline Pages] Background loading should not be started if Chrome is in foreground on a Svelte device |
|||||
Issue descriptionI added patches to trigger background loading upon adding the request or resuming but I did not first check if the device IsLowEndDevice() or not. We need to check that and not do the immediate trigger on low end devices per our design discussion in July/August about allowing the PrerenderManager to prerender on low end devices as we don't want to crash chrome inadvertently because of this.
,
Sep 15 2016
,
Sep 15 2016
,
Sep 15 2016
Your change meets the bar and is auto-approved for M54 (branch: 2840)
,
Sep 15 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7e4886b51a6fd5258d2c6f750d4537141c3588f3 commit 7e4886b51a6fd5258d2c6f750d4537141c3588f3 Author: Pete Williamson <petewil@chromium.org> Date: Thu Sep 15 23:09:33 2016 [Offline Pages] Gates immediate triggering (non scheduled) of background loading by whether low end device. Makes unit tests conditional on this check - ran unit tests on both svelte and regular devices locally. BUG= 646888 Review-Url: https://codereview.chromium.org/2338313002 Cr-Commit-Position: refs/heads/master@{#418622} (cherry picked from commit 5bbcafffea9aea16942ca3a0c0e5c38473b4afa8) Review URL: https://codereview.chromium.org/2342803003 . Cr-Commit-Position: refs/branch-heads/2840@{#384} Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607} [modify] https://crrev.com/7e4886b51a6fd5258d2c6f750d4537141c3588f3/components/offline_pages/background/request_coordinator.cc [modify] https://crrev.com/7e4886b51a6fd5258d2c6f750d4537141c3588f3/components/offline_pages/background/request_coordinator_unittest.cc
,
Oct 27 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7e4886b51a6fd5258d2c6f750d4537141c3588f3 commit 7e4886b51a6fd5258d2c6f750d4537141c3588f3 Author: Pete Williamson <petewil@chromium.org> Date: Thu Sep 15 23:09:33 2016 [Offline Pages] Gates immediate triggering (non scheduled) of background loading by whether low end device. Makes unit tests conditional on this check - ran unit tests on both svelte and regular devices locally. BUG= 646888 Review-Url: https://codereview.chromium.org/2338313002 Cr-Commit-Position: refs/heads/master@{#418622} (cherry picked from commit 5bbcafffea9aea16942ca3a0c0e5c38473b4afa8) Review URL: https://codereview.chromium.org/2342803003 . Cr-Commit-Position: refs/branch-heads/2840@{#384} Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607} [modify] https://crrev.com/7e4886b51a6fd5258d2c6f750d4537141c3588f3/components/offline_pages/background/request_coordinator.cc [modify] https://crrev.com/7e4886b51a6fd5258d2c6f750d4537141c3588f3/components/offline_pages/background/request_coordinator_unittest.cc |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by bugdroid1@chromium.org
, Sep 14 2016