New issue
Advanced search Search tips

Issue 646874 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug-Regression



Sign in to add a comment

3.8%-5.9% regression in speedometer at 418451:418467

Project Member Reported by nikolaos@chromium.org, Sep 14 2016

Issue description

See the link to graphs below.
 
All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=646874

Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?keys=agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICgmZa0oAkM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICgmd2hvwkM


Bot(s) for this bug's original alert(s):

chromium-rel-mac10
Project Member

Comment 3 by 42576172...@developer.gserviceaccount.com, Sep 14 2016

Cc: donnd@chromium.org
Owner: donnd@chromium.org

=== Auto-CCing suspected CL author donnd@chromium.org ===

Hi donnd@chromium.org, the bisect results pointed to your CL below as possibly
causing a regression. Please have a look at this info and see whether
your CL be related.


===== BISECT JOB RESULTS =====
Status: completed


===== SUSPECTED CL(s) =====
Subject : [TTS] Gather surrounding text on Tap before any UX.
Author  : donnd
Commit description:
  
Extract the text tapped on to use as a signal in Tap Suppression.
The text is extracted before any UX is displayed in order to allow the
tap to be totally ignored when appropriate.  Feeding the surrounding
text into the logic of TTS will be done separately.

This adds several files that are part of the 2016-refactoring.
See crbug.com/624609 and go/cs-refactoring-2016.

This CL is part of the refactoring-2016 effort, see go/cs-refactoring-2016
for details.

BUG=634136, 624609

Review-Url: https://codereview.chromium.org/2211353002
Cr-Commit-Position: refs/heads/master@{#418464}
Commit  : 3f11e42880b1b7b6608e2d57fa538552318367ae
Date    : Wed Sep 14 02:57:46 2016


===== TESTED REVISIONS =====
Revision         Mean     Std Dev  N    Good?
chromium@418450  544.668  12.324   18   good
chromium@418459  539.519  10.9726  18   good
chromium@418463  547.802  11.1146  93   good
chromium@418464  552.203  12.7872  134  bad    <--
chromium@418465  552.7    13.6173  89   bad
chromium@418467  552.935  13.3193  41   bad

Bisect job ran on: mac_10_10_perf_bisect
Bug ID: 646874

Test Command: src/tools/perf/run_benchmark -v --browser=release --output-format=chartjson --upload-results --also-run-disabled-tests speedometer
Test Metric: jQuery-TodoMVC/jQuery-TodoMVC
Relative Change: 2.41%
Score: 99.0

Buildbot stdio: http://build.chromium.org/p/tryserver.chromium.perf/builders/mac_10_10_perf_bisect/builds/2369
Job details: https://chromeperf.appspot.com/buildbucket_job_status/9001534036680818064


Not what you expected? We'll investigate and get back to you!
  https://chromeperf.appspot.com/bad_bisect?try_job_id=5843110456721408

| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
|  X  | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with component Tests>AutoBisect.  Thank you!

Comment 4 by donnd@chromium.org, Sep 16 2016

Cc: -donnd@chromium.org twelling...@chromium.org
Components: UI>Browser>Mobile>TouchToSearch
Labels: OS-Android
cc Theresa - FYI looks like I'll have to address speed issues with the gather surrounding Cl before relanding it.

Comment 5 by donnd@chromium.org, Feb 9 2017

nikolaos@, I want to reland a version of the above CL that caused this performance regression.  However I don't know how to verify that it won't cause a similar performance problem.  Also, I'm confused by the graphs I see here - they look like Mac issues?  This change only affected Android.  https://chromeperf.appspot.com/group_report?bug_id=646874
I'm sorry for the delay.  After uploading your CL, you should be able to run the perf trybots.  The command line in the comments above show you which test and architecture it was.  At least, this is how it works for the V8 commit queue; I believe it should work for chromium as well.

If you need anything else related to this, and to avoid delayed responses from my part, I suggest that you direct any further questions to the current perf sheriff (I don't work for Google since last October).

Best regards,
Nikos.

Comment 7 by donnd@chromium.org, Jun 5 2017

Status: Fixed (was: Assigned)
Now permanently fixed through refactoring that only gathers surrounding text once.

Sign in to add a comment