Project: chromium Issues People Development process History Sign in
New issue
Advanced search Search tips
Starred by 2 users
Status: Fixed
Owner:
Closed: Jan 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Feature

Blocking:
issue 563816



Sign in to add a comment
Make commit() work with preserveDrawingBuffer : true
Project Member Reported by xidac...@chromium.org, Sep 14 2016 Back to list
In this CL:
https://codereview.chromium.org/2328463004/

The WebGL's commit() doesn't work with {preserveDrawingBuffer : true}. We should make it work.
 
Cc: junov@chromium.org
Owner: ----
Status: Available
Comment 2 by junov@chromium.org, Dec 16 2016
Blocking: 563816
Cc: -junov@chromium.org
Owner: junov@chromium.org
Status: Assigned
Comment 3 by junov@chromium.org, Dec 16 2016
Labels: -Type-Bug Type-Feature
Comment 4 by xlai@chromium.org, Jan 9 2017
Owner: xlai@chromium.org
Status: Started
I guess this one is relevant to the https://bugs.chromium.org/p/chromium/issues/detail?id=657531
Project Member Comment 5 by bugdroid1@chromium.org, Jan 12 2017
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6a05eae35091da67cadd2458ffe0c5c87a3cf1ef

commit 6a05eae35091da67cadd2458ffe0c5c87a3cf1ef
Author: xlai <xlai@chromium.org>
Date: Thu Jan 12 21:52:13 2017

Make OffscreenCanvas Webgl Context work with preserveDrawingBuffer flag

BUG= 646864 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2627793003
Cr-Commit-Position: refs/heads/master@{#443374}

[add] https://crrev.com/6a05eae35091da67cadd2458ffe0c5c87a3cf1ef/third_party/WebKit/LayoutTests/fast/canvas/OffscreenCanvas-webgl-preserveDrawingBuffer.html
[modify] https://crrev.com/6a05eae35091da67cadd2458ffe0c5c87a3cf1ef/third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.cpp
[modify] https://crrev.com/6a05eae35091da67cadd2458ffe0c5c87a3cf1ef/third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.h

Comment 6 by xlai@chromium.org, Jan 13 2017
Components: Blink>Canvas
Status: Fixed
Sign in to add a comment