New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 646840 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Sep 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug



Sign in to add a comment

capture_unittests failing on 2 builders in VideoCaptureDeviceTest.TakePhoto

Project Member Reported by aber...@chromium.org, Sep 14 2016

Issue description

capture_unittests failing on 2 builders

Type: build-failure

Builders failed on: 
- Lollipop Low-end Tester: 
  https://build.chromium.org/p/chromium.android/builders/Lollipop%20Low-end%20Tester
- Lollipop Phone Tester: 
  https://build.chromium.org/p/chromium.android/builders/Lollipop%20Phone%20Tester

Log of failure:

C   23.316s Main  [FAIL] VideoCaptureDeviceTest.TakePhoto:
C   23.316s Main  [ RUN      ] VideoCaptureDeviceTest.TakePhoto
C   23.316s Main  ../../media/capture/video/video_capture_device_unittest.cc:517: Failure
C   23.316s Main  Mock function called more times than expected - returning directly.
C   23.316s Main      Function call: OnError(@0xbef6ebb4 16-byte object <48-38 6E-A3 FF-57 57-A3 CA-00 00-00 81-13 86-A2>, @0xbef6ebc4 "failed to stop capture")
C   23.316s Main           Expected: to be never called
C   23.316s Main             Actual: called once - over-saturated and active
C   23.316s Main  ../../media/capture/video/video_capture_device_unittest.cc:517: Failure
C   23.316s Main  Mock function called more times than expected - returning directly.
C   23.317s Main      Function call: OnError(@0xbef6eadc 16-byte object <48-38 6E-A3 FF-57 57-A3 CA-00 00-00 81-13 86-A2>, @0xbef6eaec "failed to stop capture")
C   23.317s Main           Expected: to be never called
C   23.317s Main             Actual: called twice - over-saturated and active
C   23.317s Main  ../../media/capture/video/video_capture_device_unittest.cc:532: Failure
C   23.317s Main  Actual function call count doesn't match EXPECT_CALL(*image_capture_client_.get(), OnCorrectPhotoTaken())...
C   23.317s Main           Expected: to be called once
C   23.317s Main             Actual: never called - unsatisfied and active
C   23.317s Main  [  FAILED  ] VideoCaptureDeviceTest.TakePhoto (1097 ms)
C

 
Cc: mcasas@chromium.org
Labels: OS-Android
I haven't yet managed to reproduce (the test passed on an M device, and I am still setting up an L device), but it looks as if this test was only recently enabled for L (https://codereview.chromium.org/2340573002). Has it been tested on L?

Comment 2 by mcasas@chromium.org, Sep 14 2016

#1: Not explicitly, no. 
Ok, I have just tested a checkout from just after https://codereview.chromium.org/2340573002 landed, and it fails on Android L, so I am going to revert the CL.
Cc: -mcasas@chromium.org
Labels: Pri-2 Type-Bug
Owner: mcasas@chromium.org
Please test on Android L before resubmitting.
Project Member

Comment 5 by bugdroid1@chromium.org, Sep 14 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2cedd2f7b2e116a977cb4812e2479733d295b96a

commit 2cedd2f7b2e116a977cb4812e2479733d295b96a
Author: aberent <aberent@chromium.org>
Date: Wed Sep 14 16:22:20 2016

Revert of ImageCapture: Connect takePhoto() VideoCaptureDeviceTest (patchset #1 id:1 of https://codereview.chromium.org/2340573002/ )

Reason for revert:
Fails on Android L.

BUG= 646840 

Original issue's description:
> ImageCapture: Connect takePhoto() VideoCaptureDeviceTest
>
> This CL enables VideoCaptureDeviceTest.TakePhoto for
> Android. (Note that, due to other circumstances, it'll
> only be enabled for devices implementing the Camera2
> API in non-legacy mode).
>
> The only modification is that Android creates JPEGs
> with APP1 JFIF header, because it includes EXIF information.
>
> BUG= 518807 , 626857
>
> Committed: https://crrev.com/a8ae6bfb0e432ee220b641b0e8bb3f4800a7448a
> Cr-Commit-Position: refs/heads/master@{#418423}

TBR=emircan@chromium.org,chfremer@chromium.org,mcasas@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= 518807 , 626857

Review-Url: https://codereview.chromium.org/2344503003
Cr-Commit-Position: refs/heads/master@{#418580}

[modify] https://crrev.com/2cedd2f7b2e116a977cb4812e2479733d295b96a/media/capture/video/video_capture_device_unittest.cc

Comment 6 by mcasas@chromium.org, Sep 15 2016

Components: Blink>MediaStream>ImageCapture
Status: Assigned (was: Available)

Comment 7 by mcasas@chromium.org, Sep 23 2016

Cc: mcasas@chromium.org
Owner: aber...@chromium.org
Status: Fixed (was: Assigned)
aberent@ fixed it by #5

Comment 8 by sshru...@google.com, Nov 23 2016

Components: -Blink>MediaStream>ImageCapture Blink>ImageCapture

Sign in to add a comment