Sebastien, can I ask you to make "Starred" and "Shared" icons for this feature?

They are small, so dedicated PNG images should look better.

See attached.

Deleted: assets.zip 2.4 KB

assets.zip 2.4 KB Download

Deleted: preview.png 70.7 KB

	preview.png 70.7 KB View Download

Thank you!

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/930f5e4f70364038b391654606445005bd65df27

commit 930f5e4f70364038b391654606445005bd65df27
Author: harukam <harukam@google.com>
Date: Fri Sep 16 04:21:15 2016

Parse 'starred' attribute to FileLables in DriveAPI.

Additionally parsing 'starred' attribute is necessary in order to implement showing 'starred' icon for Files app.

BUG= 646839 
TEST=google_apis_unittests --gtest_filter=DriveAPIParserTest.FileListParser

Review-Url: https://codereview.chromium.org/2344113002
Cr-Commit-Position: refs/heads/master@{#419097}

[modify] https://crrev.com/930f5e4f70364038b391654606445005bd65df27/google_apis/drive/drive_api_parser.cc
[modify] https://crrev.com/930f5e4f70364038b391654606445005bd65df27/google_apis/drive/drive_api_parser.h
[modify] https://crrev.com/930f5e4f70364038b391654606445005bd65df27/google_apis/drive/drive_api_parser_unittest.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/68666d15026e666c18587cf73b560cf1076b818a

commit 68666d15026e666c18587cf73b560cf1076b818a
Author: harukam <harukam@google.com>
Date: Thu Sep 29 12:00:01 2016

Added 'starred' to EntryProperty in FileManagerPrivateAPI.

We need to get 'starred' attribute of Drive file/directory in order to show 'starred' icon in Files app.

BUG= 646839 
TEST=unit_tests --gtest_filter=ResourceEntryConversionTest*

There has been no 'starred' property in Drive API on chromeOS until before.
It's necessary to update all resources from server just once,
so that we can avoid holding an old DB which has no 'starred' property.
We realized it by using 'starred_property_initialized' flag.
The below test ensures that the flag correctly changes.

TEST=unit_tests --gtest_filter=ResourceMetadataStorageTest.ChangeStarredPropertyInitialized

It is manually tested that the change list is reloaded for an old DB,
and an updated DB gets right 'starred' values.

Review-Url: https://codereview.chromium.org/2346873004
Cr-Commit-Position: refs/heads/master@{#421802}

[modify] https://crrev.com/68666d15026e666c18587cf73b560cf1076b818a/chrome/browser/chromeos/extensions/file_manager/private_api_drive.cc
[modify] https://crrev.com/68666d15026e666c18587cf73b560cf1076b818a/chrome/common/extensions/api/file_manager_private.idl
[modify] https://crrev.com/68666d15026e666c18587cf73b560cf1076b818a/components/drive/drive.proto
[modify] https://crrev.com/68666d15026e666c18587cf73b560cf1076b818a/components/drive/resource_entry_conversion.cc
[modify] https://crrev.com/68666d15026e666c18587cf73b560cf1076b818a/components/drive/resource_entry_conversion_unittest.cc
[modify] https://crrev.com/68666d15026e666c18587cf73b560cf1076b818a/components/drive/resource_metadata_storage.cc
[modify] https://crrev.com/68666d15026e666c18587cf73b560cf1076b818a/components/drive/resource_metadata_storage_unittest.cc
[modify] https://crrev.com/68666d15026e666c18587cf73b560cf1076b818a/components/drive/service/drive_api_service.cc

weifangsun@: IIUC, we will be able to work on this item after we decided how we show this in the context menu.

Could you give us the language and the position in the context menu for the star menu item?