New issue
Advanced search Search tips

Issue 646837 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner: ----
Closed: Sep 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Launch-OWP
Launch-Accessibility: ----
Launch-Exp-Leadership: ----
Launch-Leadership: ----
Launch-Legal: ----
Launch-M-Approved: ----
Launch-M-Target: ----
Launch-Privacy: ----
Launch-Security: ----
Launch-Test: ----
Launch-UI: ----
Rollout-Type: ----



Sign in to add a comment

MediaStreamTrackEvent constructor

Project Member Reported by foolip@chromium.org, Sep 14 2016

Issue description

https://w3c.github.io/mediacapture-main/getusermedia.html#mediastreamtrackevent

This interface currently has [NoInterfaceObject] in Blink's IDL, but should have a constructor. This is a very simply fix, most of the work is in writing a test for it.
 

Comment 1 by rbyers@chromium.org, Sep 15 2016

Labels: Hotlist-Interop
Every other browser has this - Hotlist-interop

Comment 2 by hta@chromium.org, Sep 15 2016

According to https://developer.mozilla.org/en-US/docs/Web/API/MediaStreamTrackEvent, Chrome and Firefox has this.
Edge also has it; I'm not sure whether the info about Internet Explorer or Apple is accurate.

"Always cite sources".

Comment 3 by phistuck@gmail.com, Sep 15 2016

#2 -
MDN is not an authoritative source, Chrome itself is...

> MediaStreamTrackEvent
VM204:1 Uncaught ReferenceError: MediaStreamTrackEvent is not defined

The constructor is indeed missing (at least in non experimental configuration).

Comment 4 by hta@chromium.org, Sep 15 2016

Chrome status is asked,  and will fix. It is the other browsers' status I was commenting on.

Comment 5 by phistuck@gmail.com, Sep 15 2016

Sorry, that was unclear.
[triage]: hta@, can you assign this bug to a suitable owner then?

Comment 7 by foolip@chromium.org, Sep 16 2016

Blockedon: 647693
I have a CL for this, but it's blocked on fixing  issue 647693 .

Comment 8 by foolip@chromium.org, Sep 16 2016

CL is https://codereview.chromium.org/2347103003, will send to review when the stage is set for it.
Project Member

Comment 9 by bugdroid1@chromium.org, Sep 19 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2ac9af4ca46c355761e49dcc3b58bc3c7cc02de1

commit 2ac9af4ca46c355761e49dcc3b58bc3c7cc02de1
Author: foolip <foolip@chromium.org>
Date: Mon Sep 19 16:15:57 2016

Import wpt@1f2080f9ffa00ad27eb764b83fbc10960a95d6aa

Using update-w3c-deps in Chromium 6c4ad33831899ad35888e65ae473a27a0c817e23.

BUG= 646837 
R=rbyers@chromium.org

Review-Url: https://codereview.chromium.org/2341333002
Cr-Commit-Position: refs/heads/master@{#419475}

[modify] https://crrev.com/2ac9af4ca46c355761e49dcc3b58bc3c7cc02de1/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/2ac9af4ca46c355761e49dcc3b58bc3c7cc02de1/third_party/WebKit/LayoutTests/imported/wpt/dom/nodes/Document-createEvent-expected.txt
[modify] https://crrev.com/2ac9af4ca46c355761e49dcc3b58bc3c7cc02de1/third_party/WebKit/LayoutTests/imported/wpt/dom/nodes/Document-createEvent.html
[modify] https://crrev.com/2ac9af4ca46c355761e49dcc3b58bc3c7cc02de1/third_party/WebKit/LayoutTests/imported/wpt/html/dom/documents/dom-tree-accessors/document.forms.html
[modify] https://crrev.com/2ac9af4ca46c355761e49dcc3b58bc3c7cc02de1/third_party/WebKit/LayoutTests/imported/wpt/html/dom/elements-embedded.js
[modify] https://crrev.com/2ac9af4ca46c355761e49dcc3b58bc3c7cc02de1/third_party/WebKit/LayoutTests/imported/wpt/html/dom/elements-metadata.js
[modify] https://crrev.com/2ac9af4ca46c355761e49dcc3b58bc3c7cc02de1/third_party/WebKit/LayoutTests/imported/wpt/html/dom/elements-tabular.js
[modify] https://crrev.com/2ac9af4ca46c355761e49dcc3b58bc3c7cc02de1/third_party/WebKit/LayoutTests/imported/wpt/html/dom/elements-text.js
[modify] https://crrev.com/2ac9af4ca46c355761e49dcc3b58bc3c7cc02de1/third_party/WebKit/LayoutTests/imported/wpt/html/dom/reflection.js
[modify] https://crrev.com/2ac9af4ca46c355761e49dcc3b58bc3c7cc02de1/third_party/WebKit/LayoutTests/imported/wpt/html/semantics/embedded-content/media-elements/interfaces/HTMLElement/HTMLTrackElement/src.html
[modify] https://crrev.com/2ac9af4ca46c355761e49dcc3b58bc3c7cc02de1/third_party/WebKit/LayoutTests/imported/wpt/html/semantics/forms/constraints/form-validation-checkValidity-expected.txt
[modify] https://crrev.com/2ac9af4ca46c355761e49dcc3b58bc3c7cc02de1/third_party/WebKit/LayoutTests/imported/wpt/html/semantics/forms/constraints/form-validation-checkValidity.html
[modify] https://crrev.com/2ac9af4ca46c355761e49dcc3b58bc3c7cc02de1/third_party/WebKit/LayoutTests/imported/wpt/html/semantics/forms/constraints/form-validation-reportValidity-expected.txt
[modify] https://crrev.com/2ac9af4ca46c355761e49dcc3b58bc3c7cc02de1/third_party/WebKit/LayoutTests/imported/wpt/html/semantics/forms/constraints/form-validation-reportValidity.html
[add] https://crrev.com/2ac9af4ca46c355761e49dcc3b58bc3c7cc02de1/third_party/WebKit/LayoutTests/imported/wpt/html/semantics/forms/the-input-element/cloning-steps.html
[add] https://crrev.com/2ac9af4ca46c355761e49dcc3b58bc3c7cc02de1/third_party/WebKit/LayoutTests/imported/wpt/html/semantics/forms/the-textarea-element/cloning-steps.html
[add] https://crrev.com/2ac9af4ca46c355761e49dcc3b58bc3c7cc02de1/third_party/WebKit/LayoutTests/imported/wpt/mediacapture-streams/MediaStreamTrackEvent-constructor.https-expected.txt
[add] https://crrev.com/2ac9af4ca46c355761e49dcc3b58bc3c7cc02de1/third_party/WebKit/LayoutTests/imported/wpt/mediacapture-streams/MediaStreamTrackEvent-constructor.https.html
[delete] https://crrev.com/d73506ec0027380e8cfb4b8b81f3342860bb8f0e/third_party/WebKit/LayoutTests/imported/wpt/pointerevents/pointerevent_pointerdown-manual.html
[delete] https://crrev.com/d73506ec0027380e8cfb4b8b81f3342860bb8f0e/third_party/WebKit/LayoutTests/imported/wpt/pointerevents/pointerevent_pointerenter-manual.html
[delete] https://crrev.com/d73506ec0027380e8cfb4b8b81f3342860bb8f0e/third_party/WebKit/LayoutTests/imported/wpt/pointerevents/pointerevent_pointerenter_nohover-manual.html
[delete] https://crrev.com/d73506ec0027380e8cfb4b8b81f3342860bb8f0e/third_party/WebKit/LayoutTests/imported/wpt/pointerevents/pointerevent_pointerleave_after_pointerup_nohover-manual.html
[delete] https://crrev.com/d73506ec0027380e8cfb4b8b81f3342860bb8f0e/third_party/WebKit/LayoutTests/imported/wpt/pointerevents/pointerevent_pointerleave_mouse-manual.html
[delete] https://crrev.com/d73506ec0027380e8cfb4b8b81f3342860bb8f0e/third_party/WebKit/LayoutTests/imported/wpt/pointerevents/pointerevent_pointerleave_touch-manual.html
[delete] https://crrev.com/d73506ec0027380e8cfb4b8b81f3342860bb8f0e/third_party/WebKit/LayoutTests/imported/wpt/pointerevents/pointerevent_pointermove_pointertype-manual.html
[delete] https://crrev.com/d73506ec0027380e8cfb4b8b81f3342860bb8f0e/third_party/WebKit/LayoutTests/imported/wpt/pointerevents/pointerevent_pointerout-manual.html
[delete] https://crrev.com/d73506ec0027380e8cfb4b8b81f3342860bb8f0e/third_party/WebKit/LayoutTests/imported/wpt/pointerevents/pointerevent_pointerout_after_pointerup_nohover-manual.html
[delete] https://crrev.com/d73506ec0027380e8cfb4b8b81f3342860bb8f0e/third_party/WebKit/LayoutTests/imported/wpt/pointerevents/pointerevent_pointerover-manual.html
[delete] https://crrev.com/d73506ec0027380e8cfb4b8b81f3342860bb8f0e/third_party/WebKit/LayoutTests/imported/wpt/pointerevents/pointerevent_pointertype_mouse-manual.html
[delete] https://crrev.com/d73506ec0027380e8cfb4b8b81f3342860bb8f0e/third_party/WebKit/LayoutTests/imported/wpt/pointerevents/pointerevent_pointertype_pen-manual.html
[delete] https://crrev.com/d73506ec0027380e8cfb4b8b81f3342860bb8f0e/third_party/WebKit/LayoutTests/imported/wpt/pointerevents/pointerevent_pointertype_touch-manual.html
[delete] https://crrev.com/d73506ec0027380e8cfb4b8b81f3342860bb8f0e/third_party/WebKit/LayoutTests/imported/wpt/pointerevents/pointerevent_pointerup-manual.html
[delete] https://crrev.com/d73506ec0027380e8cfb4b8b81f3342860bb8f0e/third_party/WebKit/LayoutTests/imported/wpt/pointerevents/pointerevent_pointerup_isprimary_same_as_pointerdown-manual.html
[delete] https://crrev.com/d73506ec0027380e8cfb4b8b81f3342860bb8f0e/third_party/WebKit/LayoutTests/imported/wpt/pointerevents/pointerevent_pointerup_pointertype-manual.html
[modify] https://crrev.com/2ac9af4ca46c355761e49dcc3b58bc3c7cc02de1/third_party/WebKit/LayoutTests/imported/wpt/pointerevents/pointerevent_support.js
[modify] https://crrev.com/2ac9af4ca46c355761e49dcc3b58bc3c7cc02de1/third_party/WebKit/LayoutTests/platform/win7/imported/wpt/html/semantics/forms/constraints/form-validation-reportValidity-expected.txt

Labels: -Type-Bug Type-Launch-OWP
Labels: OWP-Standards-OfficialSpec OWP-Type-NewAPI
Labels: M-55
Blockedon: -647693
Project Member

Comment 14 by bugdroid1@chromium.org, Sep 22 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3e97df71c62e1626b87744e93b2614ae65cdace7

commit 3e97df71c62e1626b87744e93b2614ae65cdace7
Author: foolip <foolip@chromium.org>
Date: Thu Sep 22 19:15:58 2016

Implement the MediaStreamTrackEvent constructor

Intent to Implement and Ship:
https://groups.google.com/a/chromium.org/d/msg/blink-dev/tfnjsv9jKVg/ZJ79fG_yAQAJ

BUG= 646837 

Review-Url: https://codereview.chromium.org/2347103003
Cr-Commit-Position: refs/heads/master@{#420421}

[delete] https://crrev.com/390848df5ac12b2401dd39e1ef0bfe4d83e324fc/third_party/WebKit/LayoutTests/imported/wpt/mediacapture-streams/MediaStreamTrackEvent-constructor.https-expected.txt
[modify] https://crrev.com/3e97df71c62e1626b87744e93b2614ae65cdace7/third_party/WebKit/LayoutTests/virtual/stable/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/3e97df71c62e1626b87744e93b2614ae65cdace7/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/3e97df71c62e1626b87744e93b2614ae65cdace7/third_party/WebKit/Source/modules/mediastream/MediaStream.cpp
[modify] https://crrev.com/3e97df71c62e1626b87744e93b2614ae65cdace7/third_party/WebKit/Source/modules/mediastream/MediaStreamEvent.cpp
[modify] https://crrev.com/3e97df71c62e1626b87744e93b2614ae65cdace7/third_party/WebKit/Source/modules/mediastream/MediaStreamEvent.h
[modify] https://crrev.com/3e97df71c62e1626b87744e93b2614ae65cdace7/third_party/WebKit/Source/modules/mediastream/MediaStreamTrackEvent.cpp
[modify] https://crrev.com/3e97df71c62e1626b87744e93b2614ae65cdace7/third_party/WebKit/Source/modules/mediastream/MediaStreamTrackEvent.h
[modify] https://crrev.com/3e97df71c62e1626b87744e93b2614ae65cdace7/third_party/WebKit/Source/modules/mediastream/MediaStreamTrackEvent.idl
[add] https://crrev.com/3e97df71c62e1626b87744e93b2614ae65cdace7/third_party/WebKit/Source/modules/mediastream/MediaStreamTrackEventInit.idl
[modify] https://crrev.com/3e97df71c62e1626b87744e93b2614ae65cdace7/third_party/WebKit/Source/modules/modules_idl_files.gni
[modify] https://crrev.com/3e97df71c62e1626b87744e93b2614ae65cdace7/third_party/WebKit/Source/modules/peerconnection/RTCPeerConnection.cpp

Status: Fixed (was: Untriaged)

Sign in to add a comment