New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 646825 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner:
Last visit > 30 days ago
Closed: Sep 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

10.7% regression in system_health.memory_desktop at 418225:418264

Project Member Reported by ulan@google.com, Sep 14 2016

Issue description

See the link to graphs below.
 

Comment 1 by ulan@google.com, Sep 14 2016

All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=646825

Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?keys=agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICgmb39vAkM


Bot(s) for this bug's original alert(s):

chromium-rel-win7-gpu-nvidia
Project Member

Comment 3 by 42576172...@developer.gserviceaccount.com, Sep 14 2016

Bisect failed: http://build.chromium.org/p/tryserver.chromium.perf/builders/winx64nvidia_perf_bisect/builds/1864
Failure reason: the build has failed due to infrastructure failure.

Project Member

Comment 4 by sheriffbot@chromium.org, Sep 15 2016

Labels: Hotlist-Google
Labels: Hotlist-SystemHealthBankruptcy
Status: Archived (was: Assigned)
Temporarily declaring bankruptcy on the *desktop* system health benchmark.
The number of alerts became unmanageable and the overall process needs to be improved to make it sustainable.
The alerts have been turned off and I'm archiving the outstanding regressions.
Note: this is just about desktop, the mobile system health stays up. 
Project Member

Comment 7 by 42576172...@developer.gserviceaccount.com, Apr 12 2017

Cc: rnep...@chromium.org
Owner: rnep...@chromium.org

=== Auto-CCing suspected CL author rnephew@chromium.org ===

Hi rnephew@chromium.org, the bisect results pointed to your CL, please take a look at the
results.


=== BISECT JOB RESULTS ===
Perf regression found with culprit

Suspected Commit
  Author : rnephew
  Commit : 8a487cef9afc07dc5d9ee7392b583f1da8be274a
  Date   : Tue Sep 13 15:37:50 2016
  Subject: Reland [Telemetry] Convert long running user stories to the System Health format.

Bisect Details
  Configuration: winx64nvidia_perf_bisect
  Benchmark    : system_health.memory_desktop
  Metric       : memory:chrome:renderer_processes:reported_by_chrome:v8:heap:effective_size_avg/memory:chrome:renderer_processes:reported_by_chrome:v8:heap:effective_size_avg
  Change       : 12.50% | 32878383.0204 -> 36989006.214

Revision             Result                   N
chromium@418224      32878383 +- 826276       6      good
chromium@418244      33946199 +- 705765       6      good
chromium@418254      33728721 +- 1092758      6      good
chromium@418255      33425561 +- 868389       6      good
chromium@418256      37115614 +- 1110539      6      bad       <--
chromium@418257      36600937 +- 1360359      5      bad
chromium@418259      36556230 +- 1201680      6      bad
chromium@418264      36989006 +- 696864       6      bad

Please refer to the following doc on diagnosing memory regressions:
  https://chromium.googlesource.com/chromium/src/+/master/docs/memory-infra/memory_benchmarks.md

To Run This Test
  src/tools/perf/run_benchmark -v --browser=release_x64 --output-format=chartjson --upload-results --also-run-disabled-tests system_health.memory_desktop

Debug Info
  https://chromeperf.appspot.com/buildbucket_job_status/8982632402001589344

Is this bisect wrong?
  https://chromeperf.appspot.com/bad_bisect?try_job_id=5257656082628608


| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
|  X  | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with component Speed>Bisection.  Thank you!
Status: WontFix (was: Archived)
This is a summary metric, and this added new stories that are likely to have more usage than the average story (since they are long running tests). 
Project Member

Comment 9 by 42576172...@developer.gserviceaccount.com, Apr 12 2017

Cc: u...@chromium.org
 Issue 646831  has been merged into this issue.

Sign in to add a comment