New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 646801 link

Starred by 1 user
Status: Fixed
Owner:
finnur@chromium.org
Closed: Sep 2016
Cc:
ajha@chromium.org
█ kavvaru@chromium.org
█ brajkumar@chromium.org
█ durga.behera@chromium.org
dpa...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression: Browser crashes on clicking on delete icon in chrome://md-settings/siteSettings/siteDetails page.

Project Member Reported by bj00129...@techmahindra.com, Sep 14 2016 
Version: 54.0.2840.27 Beta
OS: Ubuntu 14.04, Windows

Test url: https://accounts.google.com/ServiceLogin?service=wise&passive=1209600&continue=https%3A%2F%2Fdocs.google.com%2Fdocument%2F%3Fusp%3Dchrome_app&followup=https%3A%2F%2Fdocs.google.com%2Fdocument%2F%3Fusp%3Dchrome_app&ltmpl=docs#identifier

Precondition: Make sure to signin to above test url such that usage details are seen in chrome://md-settings/siteSettings/siteDetails

What steps will reproduce the problem?
(1)Launch chrome>>Navigate to chrome://md-settings/siteSettings/all>>Click on any link for site details  
(2)Now click on delete icon present under usage section and Observe browser crash( Please refer video)

Expected: Browser should not crash upon clicking on delete icon of chrome://md-settings/siteSettings/siteDetails page
Actual: Instead browser crash is seen.

Crash ids: b12628bd00000000

This is Regression issue broken in M-54.
Good build:54.0.2831.0 Dev
Bad build:54.0.2832.0 Dev

Unable to do tool bisect as links are not seen in chromium builds.Hence providing Manual Changelog URL.

CHANGELOG:
https://chromium.googlesource.com/chromium/src/+log/54.0.2831.0..54.0.2832.0?pretty=fuller&n=10000

Suspecting  https://codereview.chromium.org/2249873003 from manual changelog.

@tommycli: Please help in re-assigning if this is not related to your change.

Attaching screen-cast for reference.
Actual_Crashallsite-1.ogv
4.2 MB View Download

Comment 1 by ajha@chromium.org, Sep 14 2016

Labels: -M-55 ReleaseBlock-Stable M-54 OS-Mac
Able to reproduce the issue on the latest canary(55.0.2860.0) on Mac OS 10.11.6.

Stack trace of the crash id:
=============================
Thread 0 CRASHED [SIGILL @ 0x00007f72c42da723 ] MAGIC SIGNATURE THREAD
0x00007f72c42da723	(chrome -./out/Release/../../base/memory/ref_counted.h:137 )	settings::SiteSettingsHandler::HandleClearUsage
0x00007f72c4252306	(chrome -./out/Release/../../chrome/browser/ui/webui/chrome_web_ui_controller_factory.cc:643 )	ChromeWebUIControllerFactory::GetWebUIType
0x00007f72c4255fc5	(chrome -./out/Release/../../chrome/browser/ui/webui/chrome_web_ui_controller_factory.cc:649 )	ChromeWebUIControllerFactory::UseWebUIForURL
0x00007f72c14de657	(chrome -./out/Release/../../build/linux/debian_wheezy_amd64-sysroot/usr/lib/gcc/x86_64-linux-gnu/4.6/../../../../include/c++/4.6/bits/char_traits.h:257 )	<name omitted>
0x00007f72c196c195	(chrome -./out/Release/../../base/callback.h:388 )	<name omitted>
0x00007f72c196c8df	(chrome + 0x00fdc8df )	
0x00007f72c196ca12	(chrome -./out/Release/../../base/tuple.h:144 )	<name omitted>
0x00007f72c196c86f	(chrome -./out/Release/../../content/browser/webui/web_ui_impl.cc:91 )	<name omitted>
0x00007f72c632a51c	(chrome + 0x0599a51c )	_fini
0x00007f72c632adff	(chrome + 0x0599adff )	_fini
0x00007f72c196c820	(chrome -./out/Release/../../content/browser/webui/web_ui_impl.cc:91 )	<name omitted>
0x00007f72c195a056	(chrome -./out/Release/../../content/browser/web_contents/web_contents_impl.cc:654 )	<name omitted>
0x00007f72c2ac60c3	(chrome -./out/Release/../../base/profiler/scoped_profile.cc:31 )	<name omitted>
0x00007f72c1558f9c	(chrome -./out/Release/../../gpu/ipc/client/command_buffer_proxy_impl.cc:114 )	<name omitted>
0x00007f72c6305bf2	(chrome + 0x05975bf2 )	_fini
0x00007f72c6305b4c	(chrome + 0x05975b4c )	_fini
0x00007f72c18a68c2	(chrome -./out/Release/../../content/browser/renderer_host/render_view_host_impl.cc:836 )	<name omitted>
0x00007f72c18828ae	(chrome -./out/Release/../../content/browser/renderer_host/render_widget_host_impl.cc:459 )	<name omitted>
0x00007f72ba4c492c	(libc-2.19.so -clock_gettime.c:115 )	__clock_gettime
0x00001a8a3b3f737f		
0x00007f72c186c302	(chrome -./out/Release/../../content/browser/renderer_host/render_process_host_impl.cc:1907 )	<name omitted>
0x00007f72ba4c492c	(libc-2.19.so -clock_gettime.c:115 )	__clock_gettime
0x00007f72c2ae8bc2	(chrome -./out/Release/../../base/time/time_posix.cc:98 )	<name omitted>
0x00007f72c2b0f6f2	(chrome -./out/Release/../../base/profiler/tracked_time.cc:51 )	<name omitted>
0x00007f72c3778469	(chrome -./out/Release/../../ipc/ipc_channel_proxy.cc:314 )	<name omitted>
0x00007f72c63fe580	(chrome + 0x05a6e580 )	_fini
0x00007f72c2b0aba2	(chrome -./out/Release/../../base/callback.h:388 )	<name omitted>
0x00007f72c377828a	(chrome -./out/Release/../../ipc/ipc_channel_proxy.cc:128 )	<name omitted>
0x00007f72c64828b8	(chrome + 0x05af28b8 )	_fini
0x00007f72c2aadd48	(chrome -./out/Release/../../base/message_loop/message_loop.cc:488 )	<name omitted>
0x00007f72c055c8b8	(libpthread-2.19.so + 0x0000f8b8 )	
0x00007f72c055c8b8	(libpthread-2.19.so + 0x0000f8b8 )	
0x00007f72b94b0068	(libxcb.so.1.1.0 + 0x0000c068 )	
0x00007f72c055c8b8	(libpthread-2.19.so + 0x0000f8b8 )	
0x00007f72c64828b8	(chrome + 0x05af28b8 )	_fini
0x00007f72c2aae0a7	(chrome -./out/Release/../../base/message_loop/message_loop.cc:497 )	<name omitted>
0x00007f72c2aad79a	(chrome -./out/Release/../../base/message_loop/message_loop.cc:621 )	<name omitted>
0x00007f72c15bd72f	(chrome + 0x00c2d72f )	
0x00007f72c64828d7	(chrome + 0x05af28d7 )	_fini
0x00007f72c64828b8	(chrome + 0x05af28b8 )	_fini
0x00007f72c377828a	(chrome -./out/Release/../../ipc/ipc_channel_proxy.cc:128 )	<name omitted>
0x00007f72c15bd72f	(chrome + 0x00c2d72f )	
0x00007f72c64828d7	(chrome + 0x05af28d7 )	_fini
0x00007f72c64828b8	(chrome + 0x05af28b8 )	_fini
0x00007f72c377828a	(chrome -./out/Release/../../ipc/ipc_channel_proxy.cc:128 )	<name omitted>
0x00007f72bf189bb7	(libX11.so.6.3.0 + 0x0003bbb7 )	
0x00007f72bf189cfb	(libX11.so.6.3.0 + 0x0003bcfb )	
0x00007f72c2aaf54f	(chrome + 0x0211f54f )	
0x00007f72c2aaf568	(chrome -./out/Release/../../base/message_loop/message_pump_glib.cc:267 )	WorkSourceDispatch
0x00007f72bf4cbe03	(libglib-2.0.so.0.4002.0 + 0x00048e03 )	
0x00007f72bf4dab3f	(libglib-2.0.so.0.4002.0 + 0x00057b3f )	
0x00007f72bf4cc047	(libglib-2.0.so.0.4002.0 + 0x00049047 )	
0x00007f72bf4cc0eb	(libglib-2.0.so.0.4002.0 + 0x000490eb )	
0x00007f72c2aaf455	(chrome -./out/Release/../../base/message_loop/message_pump_glib.cc:309 )	base::MessagePumpGlib::Run
0x00007f72c1485dff	(chrome + 0x00af5dff )	
0x00007f72c1485e83	(chrome + 0x00af5e83 )	
0x00007f72c2ac798d	(chrome -./out/Release/../../base/run_loop.cc:35 )	<name omitted>
0x00007f72c2943ae1	(chrome -./out/Release/../../chrome/browser/chrome_browser_main.cc:2130 )	ChromeBrowserMainParts::MainMessageLoopRun
0x00007f72c1673a0b	(chrome -./out/Release/../../content/browser/browser_main_runner.cc:64 )	content::BrowserMainRunnerImpl::Initialize
0x00007f72c1485e83	(chrome + 0x00af5e83 )	
0x00007f72c1671787	(chrome -./out/Release/../../content/browser/browser_main_loop.cc:959 )	content::BrowserMainLoop::RunMainMessageLoopParts
0x00007f72c1673b1c	(chrome -./out/Release/../../content/browser/browser_main_runner.cc:155 )	content::BrowserMainRunnerImpl::Run
0x00007f72c1673eb8	(chrome -./out/Release/../../content/browser/browser_main.cc:46 )	content::BrowserMain
0x00007f72c2716066	(chrome -./out/Release/../../content/app/content_main_runner.cc:405 )	content::RunNamedProcessTypeMain
0x00007f72c2716976	(chrome -./out/Release/../../content/app/content_main_runner.cc:786 )	content::ContentMainRunnerImpl::Run
0x00007f72c271548d	(chrome -./out/Release/../../content/app/content_main.cc:20 )	content::ContentMain
0x00007f72c1485ffa	(chrome -./out/Release/../../chrome/app/chrome_main.cc:85 )	ChromeMain
0x00007f72ba3ddec4	(libc-2.19.so -libc-start.c:287 )	__libc_start_main
0x00007f72c1485eac	(chrome + 0x00af5eac )	_start
Project Member

Comment 2 by sheriffbot@chromium.org, Sep 14 2016

Labels: Fracas FoundIn-M-55
Users experienced this crash on the following builds:

Mac Canary 55.0.2860.0 -  1.06 CPM, 1 reports, 1 clients (signature settings::SiteSettingsHandler::HandleClearUsage)

If this update was incorrect, please add "Fracas-Wrong" label to prevent future updates.

- Go/Fracas
Project Member

Comment 3 by sheriffbot@chromium.org, Sep 15 2016

Labels: FoundIn-M-54
Users experienced this crash on the following builds:

Linux Beta 54.0.2840.27 -  5.49 CPM, 3 reports, 1 clients (signature settings::SiteSettingsHandler::HandleClearUsage)

If this update was incorrect, please add "Fracas-Wrong" label to prevent future updates.

- Go/Fracas

Comment 4 by ligim...@chromium.org, Sep 16 2016 

M54 Stable release is scheduled for the first week of OCT, please have the fix baked/verified in canary and request a merge to M54 ASAP.

Comment 5 by tommycli@chromium.org, Sep 16 2016

Labels: -ReleaseBlock-Stable
Owner: finnur@chromium.org
MD Settings is not shipped by default in 54, so not a release block. Thanks.

Comment 6 by finnur@chromium.org, Sep 20 2016

Status: Started (was: Assigned)
Project Member

Comment 7 by bugdroid1@chromium.org, Sep 21 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8b38a4bfb8ceae1cd31616c146c699616fa26f94

commit 8b38a4bfb8ceae1cd31616c146c699616fa26f94
Author: finnur <finnur@chromium.org>
Date: Wed Sep 21 19:24:40 2016

Site Settings Desktop: Fix crash when deleting storage for a site.

BUG= 646801 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2358563002
Cr-Commit-Position: refs/heads/master@{#420133}

[modify] https://crrev.com/8b38a4bfb8ceae1cd31616c146c699616fa26f94/chrome/browser/resources/settings/site_settings/site_details.js
[modify] https://crrev.com/8b38a4bfb8ceae1cd31616c146c699616fa26f94/chrome/browser/ui/webui/settings/site_settings_handler.cc

Comment 8 by finnur@chromium.org, Sep 22 2016

Status: Fixed (was: Started)
Should be fixed now.
►

Sign in to add a comment