New issue
Advanced search Search tips

Issue 646795 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Sep 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug-Security
Team-Accessibility



Sign in to add a comment

Heap-use-after-free in id

Project Member Reported by ClusterFuzz, Sep 14 2016

Issue description

Detailed report: https://cluster-fuzz.appspot.com/testcase?key=5263210183917568

Fuzzer: libfuzzer_ax_tree_fuzzer
Job Type: libfuzzer_chrome_asan
Platform Id: linux

Crash Type: Heap-use-after-free READ 4
Crash Address: 0x612000000df8
Crash State:
  id
  HasChangedNode
  DestroySubtree
  
Recommended Security Severity: High

Regressed: https://cluster-fuzz.appspot.com/revisions?job=libfuzzer_chrome_asan&range=418295:418446

Minimized Testcase (0.14 Kb): https://cluster-fuzz.appspot.com/download/AMIfv965PxN_mS9snIgBnGu4dT9QqzUKKFhUIIWRDShOxbXoovMo9U_Ez7Gs0Oo5TT3AdvzFSO4DBVaABTy_fKe3702bK1o2CY_4lDxdvzMhX0bfxPHrAPv1YTp9A2hcEtntI2xe4kvsTRtKzXaHlXePj46-R_YQtQ?testcase_id=5263210183917568

Issue filed automatically.

See https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/reproducing.md for more information.
 
Project Member

Comment 1 by sheriffbot@chromium.org, Sep 14 2016

Labels: M-55
Project Member

Comment 2 by sheriffbot@chromium.org, Sep 14 2016

Labels: ReleaseBlock-Beta
This issue is a security regression. If you are not able to fix this quickly, please revert the change that introduced it.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 3 by sheriffbot@chromium.org, Sep 14 2016

Labels: Pri-1
Components: UI>Accessibility
Owner: dmazz...@chromium.org
Status: Assigned (was: Untriaged)
Dominic,

AXTree fuzzer related.
Status: Started (was: Assigned)
Two other minimized testcases (646695, 646696) were the same root cause, fix here.

https://codereview.chromium.org/2377443002

Project Member

Comment 6 by bugdroid1@chromium.org, Sep 28 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c4d7605d5a8d55c703e6ac30754375b661478128

commit c4d7605d5a8d55c703e6ac30754375b661478128
Author: dmazzoni <dmazzoni@chromium.org>
Date: Wed Sep 28 22:17:25 2016

Fix another bug in AXTree caught by libfuzzer

There were three cases found by libfuzzer but they all had the same
root cause. Very similar to the previous issues fixed, basically
cleaning up memory properly if we get a bogus tree with things like
circular references.

Specifically, when the root of the tree changes but then
unserialization fails, we destroy the whole tree on exiting
because there's no other way to preserve it. After deleting
the old root, we then need to clean up |node|, but not if
it was already deleted or reused.

Previously we were checking if |node| was the same as |old_root|,
but really we wanted to check if |node| was deleted at all,
since it may have been a child of |old_root|.

BUG= 646795 

Review-Url: https://codereview.chromium.org/2377443002
Cr-Commit-Position: refs/heads/master@{#421658}

[modify] https://crrev.com/c4d7605d5a8d55c703e6ac30754375b661478128/ui/accessibility/ax_tree.cc
[modify] https://crrev.com/c4d7605d5a8d55c703e6ac30754375b661478128/ui/accessibility/ax_tree_unittest.cc

Project Member

Comment 7 by ClusterFuzz, Sep 29 2016

Labels: ClusterFuzz-Verified
Status: Verified (was: Started)
ClusterFuzz testcase is verified as fixed, closing issue.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.
Project Member

Comment 8 by ClusterFuzz, Sep 29 2016

ClusterFuzz has detected this issue as fixed in range 421621:421693.

Detailed report: https://cluster-fuzz.appspot.com/testcase?key=5263210183917568

Fuzzer: libfuzzer_ax_tree_fuzzer
Job Type: libfuzzer_chrome_asan
Platform Id: linux

Crash Type: Heap-use-after-free READ 4
Crash Address: 0x612000000df8
Crash State:
  id
  HasChangedNode
  DestroySubtree
  
Recommended Security Severity: High

Regressed: https://cluster-fuzz.appspot.com/revisions?job=libfuzzer_chrome_asan&range=418295:418446
Fixed: https://cluster-fuzz.appspot.com/revisions?job=libfuzzer_chrome_asan&range=421621:421693

Minimized Testcase (0.14 Kb): https://cluster-fuzz.appspot.com/download/AMIfv965PxN_mS9snIgBnGu4dT9QqzUKKFhUIIWRDShOxbXoovMo9U_Ez7Gs0Oo5TT3AdvzFSO4DBVaABTy_fKe3702bK1o2CY_4lDxdvzMhX0bfxPHrAPv1YTp9A2hcEtntI2xe4kvsTRtKzXaHlXePj46-R_YQtQ?testcase_id=5263210183917568

See https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/reproducing.md for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 9 by sheriffbot@chromium.org, Sep 30 2016

Labels: -Restrict-View-SecurityTeam Restrict-View-SecurityNotify
Labels: -ReleaseBlock-Beta
Project Member

Comment 11 by sheriffbot@chromium.org, Jan 5 2017

Labels: -Restrict-View-SecurityNotify allpublic
This bug has been closed for more than 14 weeks. Removing security view restrictions.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Sign in to add a comment