New issue
Advanced search Search tips

Issue 646794 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Sep 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 614645



Sign in to add a comment

stop reading file list from cctest.gyp

Project Member Reported by jochen@chromium.org, Sep 14 2016

Issue description

We should just duplicate the file list, as gyp is deprecated and gn should be the source of truth.

this would also allow for getting rid of the script execution to extract the file list.
 

Comment 1 by jochen@chromium.org, Sep 14 2016

same for unittests.gyp

Comment 3 by jochen@chromium.org, Sep 14 2016

Owner: jochen@chromium.org
Status: Fixed (was: Untriaged)
Project Member

Comment 4 by bugdroid1@chromium.org, Sep 16 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/8d007434386dfdeabd217c873b9d97b2c3e3b5ee

commit 8d007434386dfdeabd217c873b9d97b2c3e3b5ee
Author: vogelheim <vogelheim@chromium.org>
Date: Fri Sep 16 13:59:40 2016

Also build parsing/test-scanner-streams.

crrev.com/2339933002 and crrev.com/2314663002 were overlapping, so
this slipped through the cracks.

R=jochen@chromium.org
BUG=v8:4947,  chromium:646794 

Review-Url: https://codereview.chromium.org/2343093002
Cr-Commit-Position: refs/heads/master@{#39474}

[modify] https://crrev.com/8d007434386dfdeabd217c873b9d97b2c3e3b5ee/test/cctest/BUILD.gn

Project Member

Comment 5 by bugdroid1@chromium.org, Sep 19 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b22ae2a3b910f839feb51bbcfc0b08d5a75bc4e9

commit b22ae2a3b910f839feb51bbcfc0b08d5a75bc4e9
Author: jochen <jochen@chromium.org>
Date: Mon Sep 19 11:46:23 2016

Remove whitelist entry for v8 test files

We no longer read the sources from the gyp files

BUG= 646794 
R=machenbach@chromium.org,brettw@chromium.org

Review-Url: https://codereview.chromium.org/2334303004
Cr-Commit-Position: refs/heads/master@{#419432}

[modify] https://crrev.com/b22ae2a3b910f839feb51bbcfc0b08d5a75bc4e9/.gn

Sign in to add a comment